Use a string format for safer printing.

The string was directly used as the string format, which would have caused printf to expect additional arguments when it contains formatting elements. Bug 18720257 Change-Id: Ie4391097e58d4cab2793a05eda2b03acd02d7f22 Reviewed-on: https://swiftshader-review.googlesource.com/2656Reviewed-by: Greg Hartman <ghartman@google.com> Tested-by: Greg Hartman <ghartman@google.com> Reviewed-by: Nicolas Capens <capn@google.com>

Use a string format for safer printing.
db04c064 · Ping-Hao Wu · Nicolas Capens · df84738c · db04c064 · db04c064
Commit db04c064 authored Mar 20, 2015 by Ping-Hao Wu Committed by Nicolas Capens Mar 20, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

Shader.cpp src/OpenGL/libGL/Shader.cpp +1 -1

Shader.cpp src/OpenGL/libGLESv2/Shader.cpp +1 -1

Shader.cpp src/Radiance/libRAD/Shader.cpp +2 -2

No files found.
--- a/src/OpenGL/libGL/Shader.cpp
+++ b/src/OpenGL/libGL/Shader.cpp
@@ -208,7 +208,7 @@ void Shader::compile()
 		char buffer[256];
 		sprintf(buffer, "shader-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		getShader()->print("shader-output-%d-%d.txt", getName(), serial);
 		serial++;

--- a/src/OpenGL/libGLESv2/Shader.cpp
+++ b/src/OpenGL/libGLESv2/Shader.cpp
@@ -208,7 +208,7 @@ void Shader::compile()
 		char buffer[256];
 		sprintf(buffer, "shader-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		getShader()->print("shader-output-%d-%d.txt", getName(), serial);
 		serial++;

--- a/src/Radiance/libRAD/Shader.cpp
+++ b/src/Radiance/libRAD/Shader.cpp
@@ -387,7 +387,7 @@ void VertexShader::compile()
 		char buffer[256];
 		sprintf(buffer, "vertex-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		vertexShader->print("vertex-output-%d-%d.txt", getName(), serial);
 		serial++;
@@ -472,7 +472,7 @@ void FragmentShader::compile()
 		char buffer[256];
 		sprintf(buffer, "pixel-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		pixelShader->print("pixel-output-%d-%d.txt", getName(), serial);
 		serial++;