Skip to content

S
swiftshader
Commit df913b91 by Ian Elliott
Options

Change sampledImageIntegerSampleCounts to sampleCounts

The logic of PhysicalDevice::getImageFormatProperties(), as well as testing with ANGLE, shows that multisampling of integer formats is supported and works. The value of VkPhysicalDeviceLimits::sampledImageIntegerSampleCounts should therefore be set to: VK_SAMPLE_COUNT_1_BIT | VK_SAMPLE_COUNT_4_BIT Bug: b/147438583 Change-Id: Iaa7bd22789fd20b4e7975d3d2ffee2a8f90b006b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40068Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Tested-by: 's avatarIan Elliott <ianelliott@google.com>
parent f6d3cbb2
Showing with 1 addition and 1 deletion
src/Vulkan/VkPhysicalDevice.cpp
...@@ -260,7 +260,7 @@ const VkPhysicalDeviceLimits &PhysicalDevice::getLimits() const ...@@ -260,7 +260,7 @@ const VkPhysicalDeviceLimits &PhysicalDevice::getLimits() const
sampleCounts, // framebufferNoAttachmentsSampleCounts sampleCounts, // framebufferNoAttachmentsSampleCounts
4, // maxColorAttachments 4, // maxColorAttachments
sampleCounts, // sampledImageColorSampleCounts sampleCounts, // sampledImageColorSampleCounts
VK_SAMPLE_COUNT_1_BIT, // sampledImageIntegerSampleCounts sampleCounts, // sampledImageIntegerSampleCounts
sampleCounts, // sampledImageDepthSampleCounts sampleCounts, // sampledImageDepthSampleCounts
sampleCounts, // sampledImageStencilSampleCounts sampleCounts, // sampledImageStencilSampleCounts
VK_SAMPLE_COUNT_1_BIT, // storageImageSampleCounts (unsupported) VK_SAMPLE_COUNT_1_BIT, // storageImageSampleCounts (unsupported)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment