Subzero: Improve lowering of rematerializable call args.

Normally, if a call argument is a rematerializable Variable, it is rematerialized into a GPR (via the "lea" instruction) and then written into the appropriate arg space. This is appropriate for arguments passed on the stack, but for register arguments, it forces an unnecessary copy through another register. This CL allows that intermediate register copy to be removed. The resulting code looks cleaner, but it is unlikely to have much effect on performance - there really aren't register pressure issues because lots of scratch registers are available right before the call (which kills all scratch registers). BUG= none R=jpp@chromium.org Review URL: https://codereview.chromium.org/2080443002 .

Subzero: Improve lowering of rematerializable call args.
e450656d · Jim Stichnoth · 26c43064 · e450656d
Commit e450656d authored Jun 20, 2016 by Jim Stichnoth
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

IceTargetLoweringX86BaseImpl.h src/IceTargetLoweringX86BaseImpl.h +2 -1

No files found.
--- a/src/IceTargetLoweringX86BaseImpl.h
+++ b/src/IceTargetLoweringX86BaseImpl.h
@@ -2618,7 +2618,8 @@ void TargetX86Base<TraitsType>::lowerCall(const InstCall *Instr) {
  // Materialize moves for arguments passed in GPRs.
  for (SizeT i = 0, NumGprArgs = GprArgs.size(); i < NumGprArgs; ++i) {
    const Type SignatureTy = GprArgs[i].first;
-    Operand *Arg = legalize(GprArgs[i].second);
+    Operand *Arg =
+        legalize(GprArgs[i].second, Legal_Default | Legal_Rematerializable);
    GprArgs[i].second =
        legalizeToReg(Arg, Traits::getRegisterForGprArgNum(Arg->getType(), i));
    assert(SignatureTy == IceType_i64 || SignatureTy == IceType_i32);