Commit e587d949 by Jim Stichnoth

Subzero: Use more "= default;" for ctors and dtors.

Look for "() override {}" and "() final {}" patterns. Don't touch IceTargetLoweringX8632.* to spare a refactoring in progress. BUG= none R=jpp@chromium.org Review URL: https://codereview.chromium.org/1201023002
parent cac05851
...@@ -69,7 +69,7 @@ public: ...@@ -69,7 +69,7 @@ public:
CLCompileServer(Compiler &Comp, int argc, char **argv) CLCompileServer(Compiler &Comp, int argc, char **argv)
: CompileServer(Comp), argc(argc), argv(argv) {} : CompileServer(Comp), argc(argc), argv(argv) {}
~CLCompileServer() final {} ~CLCompileServer() final = default;
void run() final; void run() final;
......
...@@ -341,7 +341,7 @@ protected: ...@@ -341,7 +341,7 @@ protected:
}; };
private: private:
~TargetARM32() override {} ~TargetARM32() override = default;
}; };
class TargetDataARM32 final : public TargetDataLowering { class TargetDataARM32 final : public TargetDataLowering {
...@@ -362,7 +362,7 @@ protected: ...@@ -362,7 +362,7 @@ protected:
explicit TargetDataARM32(GlobalContext *Ctx); explicit TargetDataARM32(GlobalContext *Ctx);
private: private:
~TargetDataARM32() override {} ~TargetDataARM32() override = default;
template <typename T> static void emitConstantPool(GlobalContext *Ctx); template <typename T> static void emitConstantPool(GlobalContext *Ctx);
}; };
......
...@@ -124,7 +124,7 @@ protected: ...@@ -124,7 +124,7 @@ protected:
static IceString RegNames[]; static IceString RegNames[];
private: private:
~TargetMIPS32() override {} ~TargetMIPS32() override = default;
}; };
class TargetDataMIPS32 final : public TargetDataLowering { class TargetDataMIPS32 final : public TargetDataLowering {
...@@ -145,7 +145,7 @@ protected: ...@@ -145,7 +145,7 @@ protected:
explicit TargetDataMIPS32(GlobalContext *Ctx); explicit TargetDataMIPS32(GlobalContext *Ctx);
private: private:
~TargetDataMIPS32() override {} ~TargetDataMIPS32() override = default;
template <typename T> static void emitConstantPool(GlobalContext *Ctx); template <typename T> static void emitConstantPool(GlobalContext *Ctx);
}; };
......
...@@ -168,7 +168,7 @@ public: ...@@ -168,7 +168,7 @@ public:
ErrorStatus(ErrorStatus), ErrorStatus(ErrorStatus),
VariableDeclarations(new Ice::VariableDeclarationList()) {} VariableDeclarations(new Ice::VariableDeclarationList()) {}
~TopLevelParser() override {} ~TopLevelParser() override = default;
Ice::Translator &getTranslator() const { return Translator; } Ice::Translator &getTranslator() const { return Translator; }
...@@ -728,7 +728,7 @@ public: ...@@ -728,7 +728,7 @@ public:
: BlockParserBaseClass(BlockID, EnclosingParser), : BlockParserBaseClass(BlockID, EnclosingParser),
Timer(Ice::TimerStack::TT_parseTypes, getTranslator().getContext()) {} Timer(Ice::TimerStack::TT_parseTypes, getTranslator().getContext()) {}
~TypesParser() override {} ~TypesParser() override = default;
private: private:
Ice::TimerMarker Timer; Ice::TimerMarker Timer;
...@@ -909,7 +909,7 @@ public: ...@@ -909,7 +909,7 @@ public:
Ice::VariableDeclaration::create(getTranslator().getContext())), Ice::VariableDeclaration::create(getTranslator().getContext())),
CurGlobalVar(DummyGlobalVar) {} CurGlobalVar(DummyGlobalVar) {}
~GlobalsParser() final {} ~GlobalsParser() final = default;
const char *getBlockName() const override { return "globals"; } const char *getBlockName() const override { return "globals"; }
...@@ -1063,7 +1063,7 @@ public: ...@@ -1063,7 +1063,7 @@ public:
ValuesymtabParser(unsigned BlockID, BlockParserBaseClass *EnclosingParser) ValuesymtabParser(unsigned BlockID, BlockParserBaseClass *EnclosingParser)
: BlockParserBaseClass(BlockID, EnclosingParser) {} : BlockParserBaseClass(BlockID, EnclosingParser) {}
~ValuesymtabParser() override {} ~ValuesymtabParser() override = default;
const char *getBlockName() const override { return "valuesymtab"; } const char *getBlockName() const override { return "valuesymtab"; }
...@@ -1187,7 +1187,7 @@ public: ...@@ -1187,7 +1187,7 @@ public:
return ParserResult; return ParserResult;
} }
~FunctionParser() final {} ~FunctionParser() final = default;
const char *getBlockName() const override { return "function"; } const char *getBlockName() const override { return "function"; }
...@@ -2606,7 +2606,7 @@ public: ...@@ -2606,7 +2606,7 @@ public:
Timer(Ice::TimerStack::TT_parseConstants, getTranslator().getContext()), Timer(Ice::TimerStack::TT_parseConstants, getTranslator().getContext()),
FuncParser(FuncParser) {} FuncParser(FuncParser) {}
~ConstantsParser() override {} ~ConstantsParser() override = default;
const char *getBlockName() const override { return "constants"; } const char *getBlockName() const override { return "constants"; }
...@@ -2821,7 +2821,7 @@ public: ...@@ -2821,7 +2821,7 @@ public:
Timer(Ice::TimerStack::TT_parseModule, Timer(Ice::TimerStack::TT_parseModule,
Context->getTranslator().getContext()) {} Context->getTranslator().getContext()) {}
~ModuleParser() override {} ~ModuleParser() override = default;
const char *getBlockName() const override { return "module"; } const char *getBlockName() const override { return "module"; }
...@@ -2861,7 +2861,7 @@ public: ...@@ -2861,7 +2861,7 @@ public:
Timer(Ice::TimerStack::TT_parseModuleValuesymtabs, Timer(Ice::TimerStack::TT_parseModuleValuesymtabs,
getTranslator().getContext()) {} getTranslator().getContext()) {}
~ModuleValuesymtabParser() override {} ~ModuleValuesymtabParser() override = default;
private: private:
Ice::TimerMarker Timer; Ice::TimerMarker Timer;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment