Don't perform very early depth test when overridden by shader.

When the pixel shader writes the depth value, we can't use the interpolated implicit depth to perform a depth buffer test before the pixel shader executes. Change-Id: Icf80de50f4aa79f73b43e341c18478e7fd928b8d Reviewed-on: https://swiftshader-review.googlesource.com/15608Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Don't perform very early depth test when overridden by shader.
e70208e4 · Nicolas Capens · Nicolas Capens · e396a499 · e70208e4 · e70208e4
Commit e70208e4 authored Jan 02, 2018 by Nicolas Capens Committed by Nicolas Capens Jan 03, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

PixelProcessor.hpp src/Renderer/PixelProcessor.hpp +2 -2

QuadRasterizer.cpp src/Renderer/QuadRasterizer.cpp +1 -1

No files found.
--- a/src/Renderer/PixelProcessor.hpp
+++ b/src/Renderer/PixelProcessor.hpp
@@ -34,8 +34,8 @@ namespace sw

 			int shaderID;

-			bool depthOverride                        : 1;
-			bool shaderContainsKill                   : 1;
+			bool depthOverride                        : 1;   // FIXME: Eliminate by querying shader.
+			bool shaderContainsKill                   : 1;   // FIXME: Eliminate by querying shader.

 			DepthCompareMode depthCompareMode         : BITS(DEPTH_LAST);
 			AlphaCompareMode alphaCompareMode         : BITS(ALPHA_LAST);

--- a/src/Renderer/QuadRasterizer.cpp
+++ b/src/Renderer/QuadRasterizer.cpp
@@ -159,7 +159,7 @@ namespace sw
 				}
 			}

-			if(veryEarlyDepthTest && state.multiSample == 1)
+			if(veryEarlyDepthTest && state.multiSample == 1 && !state.depthOverride)
 			{
 				if(!state.stencilActive && state.depthTestActive && (state.depthCompareMode == DEPTH_LESSEQUAL || state.depthCompareMode == DEPTH_LESS))   // FIXME: Both modes ok?
 				{