Skip to content

S
swiftshader
Commit ebefaf7c by Ben Clayton
Options

Regres: Drop support for tests results only on new change

The test list from the latest patchset is now run on the parent. Missing tests are a bug. Change-Id: I149e235968acad4988d0fcff78d8a8796aaf118c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26559Tested-by: 's avatarBen Clayton <bclayton@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent dbb94f1c
Showing with 8 additions and 4 deletions
tests/regres/main.go
...@@ -881,14 +881,18 @@ func compare(old, new *CommitTestResults) string { ...@@ -881,14 +881,18 @@ func compare(old, new *CommitTestResults) string {
for test, new := range new.Tests { for test, new := range new.Tests {
old, found := old.Tests[test] old, found := old.Tests[test]
if !found {
log.Printf("Test result for '%s' not found on old change\n", test)
continue
}
switch { switch {
case found && old.Status.Passing() && new.Status.Failing(): case old.Status.Passing() && new.Status.Failing():
broken = append(broken, test) broken = append(broken, test)
case found && old.Status.Failing() && new.Status.Passing(): case old.Status.Failing() && new.Status.Passing():
fixed = append(fixed, test) fixed = append(fixed, test)
case found && old.Status != new.Status: case old.Status != new.Status:
changed = append(changed, test) changed = append(changed, test)
case found && old.Status.Failing() && new.Status.Failing(): case old.Status.Failing() && new.Status.Failing():
failing = append(failing, test) // Still broken failing = append(failing, test) // Still broken
} }
totalTests++ totalTests++
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment