Skip to content

S
swiftshader
Commit f0d22ad9 by Nicolas Capens Committed by Nicolas Capens
Options

Remove Reactor argument tests for small integers

Booleans and integer types smaller than 32-bit are not readily supported as arguments by Subzero. Was broken by https://swiftshader-review.googlesource.com/27251 Change-Id: I0803037100b107ca9f7b627c2effd0493b8ab1a8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27390Tested-by: 's avatarNicolas Capens <nicolascapens@google.com> Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by: 's avatarBen Clayton <bclayton@google.com>
parent 01c03fd5
Showing with 25 additions and 9 deletions
src/Reactor/ReactorUnitTests.cpp
......@@ -1118,7 +1118,8 @@ TEST(ReactorUnitTests, PreserveXMMRegisters)
}
template <typename T>
class CToReactorCastTest : public ::testing::Test {
class CToReactorCastTest : public ::testing::Test
{
public:
using CType = typename std::tuple_element<0, T>::type;
using ReactorType = typename std::tuple_element<1, T>::type;
......@@ -1126,11 +1127,11 @@ public:
using CToReactorCastTestTypes = ::testing::Types
< // Subset of types that can be used as arguments.
std::pair<bool, Bool>,
std::pair<uint8_t, Byte>,
std::pair<int8_t, SByte>,
std::pair<int16_t, Short>,
std::pair<uint16_t, UShort>,
// std::pair<bool, Bool>, FIXME(capn): Not supported as argument type by Subzero.
// std::pair<uint8_t, Byte>, FIXME(capn): Not supported as argument type by Subzero.
// std::pair<int8_t, SByte>, FIXME(capn): Not supported as argument type by Subzero.
// std::pair<int16_t, Short>, FIXME(capn): Not supported as argument type by Subzero.
// std::pair<uint16_t, UShort>, FIXME(capn): Not supported as argument type by Subzero.
std::pair<int, Int>,
std::pair<unsigned int, UInt>,
std::pair<float, Float>
......@@ -1138,7 +1139,8 @@ using CToReactorCastTestTypes = ::testing::Types
TYPED_TEST_CASE(CToReactorCastTest, CToReactorCastTestTypes);
TYPED_TEST(CToReactorCastTest, Casts) {
TYPED_TEST(CToReactorCastTest, Casts)
{
using CType = typename TestFixture::CType;
using ReactorType = typename TestFixture::ReactorType;
......@@ -1168,7 +1170,8 @@ TYPED_TEST(CToReactorCastTest, Casts) {
}
template <typename T>
class GEPTest : public ::testing::Test {
class GEPTest : public ::testing::Test
{
public:
using CType = typename std::tuple_element<0, T>::type;
using ReactorType = typename std::tuple_element<1, T>::type;
......@@ -1208,7 +1211,8 @@ using GEPTestTypes = ::testing::Types
TYPED_TEST_CASE(GEPTest, GEPTestTypes);
TYPED_TEST(GEPTest, PtrOffsets) {
TYPED_TEST(GEPTest, PtrOffsets)
{
using CType = typename TestFixture::CType;
using ReactorType = typename TestFixture::ReactorType;
......
src/Reactor/ReactorUnitTests.vcxproj.user 0 → 100644
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<LocalDebuggerCommandArguments>--gtest_break_on_failure --gtest_filter=*</LocalDebuggerCommandArguments>
<DebuggerFlavor>WindowsLocalDebugger</DebuggerFlavor>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<LocalDebuggerCommandArguments>--gtest_break_on_failure --gtest_filter=*</LocalDebuggerCommandArguments>
<DebuggerFlavor>WindowsLocalDebugger</DebuggerFlavor>
</PropertyGroup>
</Project>
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment