CMake: Add DCHECK_ALWAYS_ON flag

Enables macros like ASSERT, UNIMPLEMENTED even in release builds. Bug: b/126329018 Change-Id: I7d810862b16d85b0a4ffc6b39a655cc73d4c669a Reviewed-on: https://swiftshader-review.googlesource.com/c/25557 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Ben Clayton <bclayton@google.com>

CMake: Add DCHECK_ALWAYS_ON flag
f117291f · Ben Clayton · Ben Clayton · 60a3d6f7 · f117291f · f117291f
Commit f117291f authored Feb 26, 2019 by Ben Clayton Committed by Ben Clayton Feb 27, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

tasks.json .vscode/tasks.json +2 -1

CMakeLists.txt CMakeLists.txt +5 -0

No files found.
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -67,7 +67,8 @@
            "args": [
                "..",
                "-DCMAKE_BUILD_TYPE=${input:buildType}",
-                "-DWARNINGS_AS_ERRORS=1"
+                "-DWARNINGS_AS_ERRORS=1",
+                "-DDCHECK_ALWAYS_ON=1"
            ],
            "options": {
                "cwd": "${workspaceRoot}/build"

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -77,6 +77,7 @@ option (ASAN "Build with address sanitizer" 0)
 option (TSAN "Build with thread sanitizer" 0)
 option (UBSAN "Build with undefined behavior sanitizer" 0)
 option (WARNINGS_AS_ERRORS "Treat all warnings as errors" 0)
+option (DCHECK_ALWAYS_ON "Check validation macros even in release builds" 0)

 if(ARCH STREQUAL "arm")
    set(DEFAULT_REACTOR_BACKEND "Subzero")
@@ -271,6 +272,10 @@ else()
        set_cpp_flag("-Werror") # Treat all warnings as errors
    endif()

+    if(DCHECK_ALWAYS_ON)
+        set_cpp_flag("-DDCHECK_ALWAYS_ON")
+    endif()
+
    # Disable pedanitc warnings
    if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
        set_cpp_flag("-Wno-ignored-attributes")  # ignoring attributes on template argument 'X'