Reactor: Don't auto-initialize Pointer<T> variables with null.

Micro-optimization as discussed here: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34528/7/src/Pipeline/SpirvShader.hpp#1257 Change-Id: I0e71f2b5c882b2e65271a2e8f114239a924462f8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34549Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Reactor: Don't auto-initialize Pointer<T> variables with null.
f63c4e51 · Ben Clayton · 0697da05 · f63c4e51 · f63c4e51
Commit f63c4e51 authored Aug 01, 2019 by Ben Clayton
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 7 deletions

SpirvShader.hpp src/Pipeline/SpirvShader.hpp +3 -3

Reactor.hpp src/Reactor/Reactor.hpp +1 -4

No files found.
--- a/src/Pipeline/SpirvShader.hpp
+++ b/src/Pipeline/SpirvShader.hpp
@@ -1253,9 +1253,9 @@ namespace sw
 		struct SamplerCache
 		{
-			Pointer<Byte> imageDescriptor;
+			Pointer<Byte> imageDescriptor = nullptr;
-			Pointer<Byte> sampler;
+			Pointer<Byte> sampler = nullptr;
-			Pointer<Byte> function;
+			Pointer<Byte> function = nullptr;
 		};
 		vk::PipelineLayout const * const pipelineLayout;

--- a/src/Reactor/Reactor.hpp
+++ b/src/Reactor/Reactor.hpp
@@ -2818,10 +2818,7 @@ namespace rr
 	}
 	template<class T>
-	Pointer<T>::Pointer() : alignment(1)
+	Pointer<T>::Pointer() : alignment(1) {}
-	{
-		LValue<Pointer<T>>::storeValue(Nucleus::createNullPointer(T::getType()));
-	}
 	template<class T>
 	Pointer<T>::Pointer(RValue<Pointer<T>> rhs) : alignment(1)