glGenerateMipmap validation

Can't generate mipmaps if the format is not color renderable or not filterable. Change-Id: I919a4c29c17a69c25e018dd4682940eecd4df30e Reviewed-on: https://swiftshader-review.googlesource.com/14068Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

glGenerateMipmap validation
f89cd0b8 · Alexis Hetu · Alexis Hétu · bbb8fc17 · f89cd0b8
Commit f89cd0b8 authored Nov 20, 2017 by Alexis Hetu Committed by Alexis Hétu Nov 22, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

libGLESv2.cpp src/OpenGL/libGLESv2/libGLESv2.cpp +6 -0

No files found.
--- a/src/OpenGL/libGLESv2/libGLESv2.cpp
+++ b/src/OpenGL/libGLESv2/libGLESv2.cpp
@@ -2306,6 +2306,12 @@ void GenerateMipmap(GLenum target)
 			return error(GL_INVALID_OPERATION);
 		}

+		if(!IsColorRenderable(texture->getFormat(target, 0), clientVersion, true) ||
+		   sw::Surface::isNonNormalizedInteger(texture->getInternalFormat(target, 0)))
+		{
+			return error(GL_INVALID_OPERATION);
+		}
+
 		texture->generateMipmaps();
 	}
 }