Commit fb670f56 by Antonio Maiorano

marl: manually apply partial patch to fix x86 crashes

parent bc98fbee
......@@ -25,12 +25,19 @@ void marl_fiber_set_target(struct marl_fiber_context* ctx,
uint32_t stack_size,
void (*target)(void*),
void* arg) {
// The stack pointer needs to be 16-byte aligned when making a 'call'.
// The 'call' instruction automatically pushes the return instruction to the
// stack (4-bytes), before making the jump.
// The marl_fiber_swap() assembly function does not use 'call', instead it
// uses 'jmp', so we need to offset the ESP pointer by 4 bytes so that the
// stack is still 16-byte aligned when the return target is stack-popped by
// the callee.
uintptr_t* stack_top = (uintptr_t*)((uint8_t*)(stack) + stack_size);
ctx->EIP = (uintptr_t)&marl_fiber_trampoline;
ctx->ESP = (uintptr_t)&stack_top[-3];
stack_top[-1] = (uintptr_t)arg;
stack_top[-2] = (uintptr_t)target;
stack_top[-3] = 0; // No return target.
ctx->ESP = (uintptr_t)&stack_top[-5];
stack_top[-3] = (uintptr_t)arg;
stack_top[-4] = (uintptr_t)target;
stack_top[-5] = 0; // No return target.
}
#endif // defined(__i386__)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment