Commit fc7c6bd4 by Chris Forbes

Consider all faces in TextureCubeMap::hasNonBaseLevels()

Not tested by dEQP (and unlikely to be, as we don't want to force drivers to break existing content by adding new negative coverage in general) but this was wrong. Bug: b/141916742 Test: dEQP-EGL.functional.image.api.create_image_* Change-Id: I774d197a9c5c47447c97d212b41e4c33ad963474 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36949Tested-by: 's avatarChris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent aabce795
...@@ -1024,9 +1024,12 @@ bool TextureCubeMap::hasNonBaseLevels() const ...@@ -1024,9 +1024,12 @@ bool TextureCubeMap::hasNonBaseLevels() const
{ {
for(int level = 1; level < IMPLEMENTATION_MAX_TEXTURE_LEVELS; level++) for(int level = 1; level < IMPLEMENTATION_MAX_TEXTURE_LEVELS; level++)
{ {
if (image[0][level]) for(int face = 0; face < 6; face++)
{ {
return true; if (image[face][level])
{
return true;
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment