Added missing binary related functions to Program

The spec for GetProgramiv didn't mention anything about PROGRAM_BINARY_LENGTH, but looking at the OpenGL ES 3.0 spec, section 2.11.4 - "Program Binaries", we have: "The number of bytes in the program binary can be queried by calling GetProgramiv with pname PROGRAM_BINARY_LENGTH" Change-Id: Idf652fec34fa1f3cce6cce0e7302ab8d47a6cf74 Reviewed-on: https://swiftshader-review.googlesource.com/3611Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <capn@google.com>

Added missing binary related functions to Program
fef22a6d · Alexis Hetu · Alexis Hétu · 60015701 · fef22a6d · fef22a6d
Commit fef22a6d authored Jun 30, 2015 by Alexis Hetu Committed by Alexis Hétu Jul 16, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 17 additions and 1 deletion

Program.cpp src/OpenGL/libGLESv2/Program.cpp +6 -0

Program.h src/OpenGL/libGLESv2/Program.h +2 -0

libGLESv2.cpp src/OpenGL/libGLESv2/libGLESv2.cpp +9 -1

No files found.
--- a/src/OpenGL/libGLESv2/Program.cpp
+++ b/src/OpenGL/libGLESv2/Program.cpp
@@ -2350,6 +2350,12 @@ namespace es2
 		return validated;
 	}

+	GLint Program::getBinaryLength() const
+	{
+		UNIMPLEMENTED();
+		return 0;
+	}
+
 	void Program::release()
 	{
 		referenceCount--;

--- a/src/OpenGL/libGLESv2/Program.h
+++ b/src/OpenGL/libGLESv2/Program.h
@@ -210,7 +210,9 @@ namespace es2

 		unsigned int getSerial() const;

+		bool getBinaryRetrievableHint() const { return retrievableBinary; }
 		void setBinaryRetrievable(bool retrievable) { retrievableBinary = retrievable; }
+		GLint getBinaryLength() const;

 	private:
 		void unlink();

--- a/src/OpenGL/libGLESv2/libGLESv2.cpp
+++ b/src/OpenGL/libGLESv2/libGLESv2.cpp
@@ -3336,7 +3336,15 @@ void GetProgramiv(GLuint program, GLenum pname, GLint* params)
 		case GL_PROGRAM_BINARY_RETRIEVABLE_HINT:
 			if(clientVersion >= 3)
 			{
-				UNIMPLEMENTED();
+				*params = programObject->getBinaryRetrievableHint();
+				return;
+			}
+			else return error(GL_INVALID_ENUM);
+		case GL_PROGRAM_BINARY_LENGTH:
+			if(clientVersion >= 3)
+			{
+				*params = programObject->getBinaryLength();
+				return;
 			}
 			else return error(GL_INVALID_ENUM);
 		default: