Limit Subzero routine stack size to 512 KiB

src/Reactor/SubzeroReactor.cpp

@@ -64,7 +64,9 @@ namespace sz {
 Ice::Cfg *createFunction(Ice::GlobalContext *context, Ice::Type returnType, const std::vector<Ice::Type> &paramTypes)
 {
 	uint32_t sequenceNumber = 0;
-	auto function = Ice::Cfg::create(context, sequenceNumber).release();
+	auto *function = Ice::Cfg::create(context, sequenceNumber).release();
+
+	function->setStackSizeLimit(512 * 1024);  // 512 KiB
 
 	Ice::CfgLocalAllocatorScope allocScope{ function };
 
@@ -1039,6 +1041,11 @@ static std::shared_ptr<Routine> acquireRoutine(Ice::Cfg *const (&functions)[Coun
 		}
 
 		currFunc->emitIAS();
+
+		if(currFunc->hasError())
+		{
+			return nullptr;
+		}
 	}
 
 	// Emit items

third_party/subzero/src/IceCfg.h

@@ -274,6 +274,9 @@ public:
   /// in the correct information once everything is known.
   void fixPhiNodes();
 
+  void setStackSizeLimit(uint32_t Limit) { StackSizeLimit = Limit; }
+  uint32_t getStackSizeLimit() const { return StackSizeLimit; }
+
 private:
   friend class CfgAllocatorTraits; // for Allocator access.
 
@@ -344,6 +347,7 @@ private:
   /// should be called to avoid spurious validation failures.
   const CfgNode *CurrentNode = nullptr;
   CfgVector<Loop> LoopInfo;
+  uint32_t StackSizeLimit = 1 * 1024 * 1024; // 1 MiB
 
 public:
   static void TlsInit() { CfgAllocatorTraits::init(); }

third_party/subzero/src/IceTargetLoweringX86BaseImpl.h

@@ -1202,6 +1202,11 @@ void TargetX86Base<TraitsType>::addProlog(CfgNode *Node) {
   SpillAreaSizeBytes = StackSize - StackOffset; // Adjust for alignment, if any
 
   if (SpillAreaSizeBytes) {
+    auto *Func = Node->getCfg();
+    if (SpillAreaSizeBytes > Func->getStackSizeLimit()) {
+      Func->setError("Stack size limit exceeded");
+    }
+
     emitStackProbe(SpillAreaSizeBytes);
 
     // Generate "sub stackptr, SpillAreaSizeBytes"