Commits · 1f618582c09bfd470c19da9fa79c73ded7b5fedd · Chen Yisong / swiftshader

02 May, 2019 18 commits

Add support for sampling VK_FORMAT_E5B9G9R9_UFLOAT_PACK32 · 1f618582

authored May 02, 2019

Bug: b/131246807
Test: dEQP-VK.*e5b9g9r9*
Change-Id: Ieb62847c5d86b57a81e718aa325e92e10c961c71
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30434Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

1f618582

Refactor float sampling path to be more regular · 8d7f233a

authored May 02, 2019

Change-Id: I8e68ecda72c9ac077c81e7a03eb53ec3c43e7812
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30433Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

8d7f233a

Add Gralloc usage flags · 788ea9f7

authored May 01, 2019

Bug: b/122837237
Change-Id: Ic2643d288dd8d217d68cda44ec291c0ea810d4d8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30369Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Hernan Liatis <hliatis@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

788ea9f7

Remove old isSRGBReadable/Writable queries · 82ae7cbc

authored May 02, 2019

These are no longer used.

Change-Id: I0fde85e2b200663eac2bb32c34f90e78d76ad287
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30469Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

82ae7cbc

Add support for sampling VK_FORMAT_A1R5G5B5_UNORM_PACK16 · addcdccb

authored May 02, 2019

Bug: b/131246807
Test: dEQP-VK.*a1r5g5b5*
Change-Id: Iea73786b10dca6f4116a0093218e182a089c5bcf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30468Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

addcdccb

CMakeLists: add DEBUGGER_WAIT_DIALOG compiler definition to Debug builds of… · b0a68ed5

authored Apr 26, 2019

CMakeLists: add DEBUGGER_WAIT_DIALOG compiler definition to Debug builds of libEGL and libvk_swiftshader

This matches what's in the manually managed vcxproj for the two modules.
We add these for non-MSVC as well so we might eventually add support
to those platforms. Note that these are guarded with #ifdef _WIN32
already, so there's no danger of this breaking non-MSVC builds.

Change-Id: Ie855eb4aa1006607fdf8799ccde72305c53f3508
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30028
Presubmit-Ready: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

b0a68ed5

Implement sampler LOD bias · 58edd47c

authored May 02, 2019

Factor the duplicate code out of 2D/3D/Cube LOD calculation and add the
mipLodBias field from the sampler descriptor.

Bug: b/129523279
Test: dEQP-VK.pipeline.sampler.*
Change-Id: I7e25fad13fbe3307dddb2dcb853ed638344ee4aa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30429
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

58edd47c

Refactor duplicate mipmap LOD calculation · b1670ed4

authored May 02, 2019

Bug: b/129523279
Change-Id: If4dfa5900ac73643cc8a8052867434d62fa1aa1e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30430
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

b1670ed4

Removed unused texture data · 7179935f

authored May 02, 2019

Bug: b/129523279
Change-Id: Ifdb1409cf7339ac16b6fe890bc014a2e43801c76
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30431
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

7179935f

Regres: Update test lists @ · 4b206fa3

authored May 02, 2019

Change-Id: I3b75909a56442b2f7da626c40251ed175dd15936
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30448Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

4b206fa3

Validate descriptor ID's · fa7d1366

authored May 01, 2019

Bug: b/129523279
Test: dEQP-VK.glsl.texture_functions.*
Test: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
Change-Id: I26959eb7665af9f35dba81f83b0e0f13a4798865
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30408
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

fa7d1366

Use sampler data from sampler descriptor · 1e7120e4

authored Apr 30, 2019

Bug: b/129523279
Test: dEQP-VK.glsl.texture_functions.*
Test: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
Change-Id: I4c02a36b35a25772e233346266ff6177a9186b9e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30249
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

1e7120e4

Pass a separate sampler pointer to the sampling routine · 97da7826

authored Apr 30, 2019

Previously only the texture pointer was passed to the sampling routine,
containing some sampler data which is (still) wrongly assumed to come
from a combined image-view and sampler descriptor. This change will
allow splitting them up correctly.

Also refactor getImageSampler to not start the Reactor function
generation, moving it entirely into emitSamplerFunction so that the
latter only has to be passed the pointers to the descriptor state that
will affect the code that's generated.

Name all the parameters according to their actual type.

Clamp sampler LOD on construction so we don't have to deal with it any
more later.

Bug: b/129523279
Test: dEQP-VK.glsl.texture_functions.*
Test: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
Change-Id: Id3a9f12f379cf65741198b732fe387ec6e24dd86
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30350
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

97da7826

Add support for sampling VK_FORMAT_B4G4R4A4_UNORM_PACK32 · 20aab4e9

authored May 01, 2019

Bug: b/131246807
Test: dEQP-VK.*b4g4r4a4_unorm*
Change-Id: Ifb319c50cf0a9f9e83c0c8074f5631f4726cc380
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30428Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

20aab4e9

Add support for sampling VK_FORMAT_A2B10G10R10_UNORM_PACK32 · d573e7e7

authored May 01, 2019

Bug: b/131246807
Test: dEQP-VK.*a2b10g10r10_unorm*
Change-Id: If51d38ddc8cbb334970e2719cb0fd96a9b240b09
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30388Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>

d573e7e7

Implement Android shared image query so device creation can succeed · 83a3eb49

authored Apr 29, 2019

Bug: b/122837060
Change-Id: I8524a46d79e1327d494acc5ee494bad87bc9676b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30190
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Hernan Liatis <hliatis@google.com>

83a3eb49

Add stubs for Native Buffer implementation · 8a91a355

authored Apr 29, 2019

Bug: b/122837237
Change-Id: Ic9d306e11ff5dd64f6ba0f0f6cb3a1e9a882411a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30189
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Hernan Liatis <hliatis@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

8a91a355

Turn on Android platform · 04c0eacd

authored Apr 29, 2019

Bug: b/122837488
Change-Id: I1d4b33943ea68db3c068b604876745ba6fb5097c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30188
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Hernan Liatis <hliatis@google.com>

04c0eacd

01 May, 2019 19 commits

Remove Sampler::State::srgb · ac3a4a49

authored May 01, 2019

sRGB decode is controlled by format, not extra state. There is also no
565 sRGB format in Vulkan.

Also remove the 5 and 6bit sRGB LUTs since they are no longer used.

Change-Id: Iea8770a50e4ef77004dc66d4a9867df62e7c2aaf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30368
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

ac3a4a49

Add mandatory 10bpc formats to format queries · 2acaccd3

authored May 01, 2019

Test: dEQP-VK.*a2b10g10r10_u*
Change-Id: I56498465c3cd43d23e691509c997e5c29f4fdaf9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30348Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

2acaccd3

Minor tidying in PixelProgram · 390d846c

authored Apr 26, 2019

- Fold together the shader -> oDepth handling. If these conditions were
not the same, the shader is invalid.

Change-Id: I9bec710886c9961f4141006d2d48f3eb76a3dfee
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29988
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

390d846c

SpirvShader: Implement OpGroupNonUniformElect · 32d47971

authored Apr 19, 2019

The only elect function we'll need to implement for Pastel 1.0.

Used by memory barrier tests, but not tested on its own.

Bug: b/131667233
Change-Id: I5309fa6b49c49091226fbaaca4e46363f6dff534
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30208
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

32d47971

Fix killMask initialization · 2e043583

authored May 01, 2019

The shader is run multiple times reusing the same routine state.
We need to set the mask correctly before each execution.

Test: dEQP-VK.glsl.discard.*
Change-Id: Ic34385715cc4a16d931a3ff4fae4eeaf48d52223
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30328Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

2e043583

SpirvShader: Don't abort for unused, unbound UniformConstants · 8c56e8d3

authored Apr 25, 2019

Bug: b/126330097
Tests: dEQP-VK.glsl.discard.*
Change-Id: I17632f68705aa8f0c8c607b5ec469272a58047db
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29908Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

8c56e8d3

SpirvShader: Rework debug assertions · 92797c27

authored Apr 25, 2019

Use the new UNSUPPORTED() macro where possible.

Switch to using UNREACHABLE() over UNIMPLEMENTED() for switch cases that do not exist according to the spec, or for cases that should be handled by validation in an earlier stage.

Bug: b/131243109
Change-Id: Id9970b64cf248468c508e65366bc576cb03e8e58
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29929Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

92797c27

Check macro arguments match format specifier. · 46e28cb3

authored Apr 25, 2019

Prevents typos that can cause undefined behavior.

Bug: b/127433389
Change-Id: I6308831d9ae8ff3d6147c5a766de81fdc239fab5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29931Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

46e28cb3

Implement Bias image operand · 4bade2e3

authored Apr 30, 2019

Also fix Lod + Offset combination, and rename the parameter that holds
either lod or bias to lodOrBias.

Bug: b/129523279
Test: dEQP-VK.glsl.texture_functions.*
Change-Id: I397959421651e990d041f4297c4bcf55e1c00f03
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30229Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

4bade2e3

Implement fp16 texture formats · d354695d

authored Apr 30, 2019

TODO: figure out what is happening with linear filtering. Possibly pre-existing breakage -- if we enable filtering support for R32_SFLOAT that fails in the same way.

Test: dEQP-VK.texture.*
Test: dEQP-VK.image.*
Test: dEQP-VK.pipeline.*
Change-Id: Ia461418d772eb5aceb101b84eaa239b0c0bce2c0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30288Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

d354695d

SpirvShader: Implement OpCopyMemory · b5a4546c

authored Apr 30, 2019

Tests: dEQP-VK.spirv_assembly.instruction.compute.memory_access.*
Change-Id: I5281798468651c67ec038bdd8688f99c67654cb1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30215Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

b5a4546c

VkPipeline: Add spirvopt MergeReturnPass · 139acaac

authored Apr 30, 2019

Fixes cases where functions were not being inlined.

Tests: dEQP-VK.glsl.functions.control_flow.*
Change-Id: Ia752517040f7529ec3b47adc75ec03646d183f6d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30214Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

139acaac

SpirvShader: Implement constant variable initializers. · 05f27a34

authored Apr 30, 2019

Non-constant initializers not yet implemented.

Tests: dEQP-VK.spirv_assembly.instruction.graphics.variable_init.*
Tests: dEQP-VK.spirv_assembly.instruction.compute.variable_init.*
Tests: dEQP-VK.spirv_assembly.instruction.compute.opunreachable.*
Tests: dEQP-VK.spirv_assembly.instruction.compute.shader_default_output.int.initialized

Bug: b/131681817
Change-Id: I8b283042d3be15028c2efe10988d6847c6256811
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30213Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

05f27a34

Regres: Update test lists @ · 79f6f41b

authored May 01, 2019

Change-Id: I7c24723b48298881ea3b89a92c37e67ffa7cbedd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30308Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

79f6f41b

Update Visual Studio LLVM project · 8c7da809

authored Apr 29, 2019

Re-generated using build/cmake.sh after the LLVM source file set
minimization. Manually removed and re-added the LLVM project from
build\Visual Studio 15 2017 Win64\llvm.vcxproj and as a Reactor
dependency (since CMake produces new GUIDs to identify the projects
every time).

This required adding back lib/Support/APSInt.cpp

Bug: b/129772660
Change-Id: I0fd51b02e25f1e698d2d9d468870ae69e2651183
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30150Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

8c7da809

Remove CHECK_NEEDED comments · 9ac24a99

authored Apr 29, 2019

Bug: b/129772660
Change-Id: I7c318b9245a682f5aa064f6e3c66d81b141c62b9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30149Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

9ac24a99

Minimize LLVM source file set · eb27df0f

authored Apr 02, 2019

This is the result of running build/strip_cmakelists.sh with each
LLVM source file in CMakeLists.txt marked with a CHECK_NEEDED
comment.

Bug: b/129772660
Change-Id: Ie0de926112e8674a16769b75bad0b17de961650e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28368Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

eb27df0f

Mark LLVM source files for potential deletion from build · 72e82e26

authored Apr 02, 2019

The CHECK_NEEDED comments will be used by the build/strip_cmakelists.sh
script to see if the build still succeeds with each of these files
removed individually.

Bug: b/129772660
Change-Id: I54afbf06f40f413caad6a619191c56b27162eb26
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30148Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

72e82e26

Add a script to reduce source files to required set · 7abc762d

authored Apr 02, 2019

Running build/strip_cmakelists.sh will attempt to build the CMake
project files with each line that contains a
comment iteratively removed. This allows to minimize the number of
required source files. In particular LLVM is considerably larger than
necessary and will be minimized in the following change.

Bug: b/129772660
Change-Id: I5c062a2643b79ba444b82737f23bc0c104044f07
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28254Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

7abc762d

30 Apr, 2019 3 commits

Remove dead parts of ShaderCore · 2e238583

authored Apr 30, 2019

Change-Id: I966632cdd1cfd7077d0595d8987d15351e43b6a6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30248Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

2e238583

Set correct variant for OpImageFetch · 6f1b765a

authored Apr 30, 2019

Fixes interaction with ImageInstruction rework in previous patch

Bug: b/129523279
Test: dEQP-VK.image.*
Change-Id: I3c0ff7d4497f95f67dc9fc08ad8793f81f7c5f2c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30228Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

6f1b765a

Implement OpImageSampleProjImplicitLod and OpImageSampleProjExplicitLod · 5b09dd10

authored Apr 30, 2019

Also add stubs for Dref variants.

Bug: b/129523279
Test: dEQP-VK.glsl.texture_functions.*
Test: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
Change-Id: I810c8e32758c9124f7649c62d51b34751ee9bfae
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30193
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

5b09dd10