Bug: b/131171141
Test: dEQP-VK.renderpass*
Change-Id: I22a443edeee705b24ccc3a838fbab5f333f5dd87
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29730Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

- R8_{UNORM,UINT,SINT}
- R8G8_{UNORM,UINT,SINT}

Test: dEQP-VK.renderpass.suballocation.formats.*
Bug: b/131171141
Change-Id: Id05d5e825eaafe72cefbe7c6dd70f2fac144e7e5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30048Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

This still uses the legacy approach with 6 pointers per mipmap level
for each cube face. Will be refactored to use a single pointer to access
faces as consecutive layers.

Bug: b/129523279
Tests: dEQP-VK.texture.filtering.cube.formats.r8g8b8a8_unorm.*
Change-Id: I1f59f121d2989e0ba79eb3441529b812a8d9111a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29969
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

D16_UNORM is the first format supported in this path with a texel size
of less than 4 bytes. Adjust the loading to round up the size so we always
emit at least one load.

Test: dEQP-VK.renderpass*
Bug: b/131171141
Change-Id: I985b85017ace84cb8b18c36989fea99ba8e0f44f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29729
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Previously we tried to avoid applying a shader which didn't do anything
useful. Unfortunately we missed various edge cases. Just remove this
logic completely.

Bug: b/118386749
Test: dEQP-VK.renderpass*
Change-Id: I48f2f9f08ad491381db22af9f6f3430f7b4d4db1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29728Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

When an image is created as a 3D image, but contains the
VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT flag, it becomes
equivalent to a 2D array with "depth" layers and should
be treated as such when accessing a single slice of a 3D
image.

Bug b/119620767

Change-Id: Ibdc6985acdf5e5f30efcb7bf5adc2563bf64c4f7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29189Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

Plumb this into regres.

Bug: b/131243109
Change-Id: Ie82cab71aca0e6b1648852dad8f4a0acd0856e70
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29928Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

More specifically, crash occurs when viewport.Y is negative, and
scissoring isn't explicitly set by user. Problem was a combination
of computing invalid scissor bounds, and after clamping to these
bounds, proceeding to index buffers when yMin >= yMax. Fixed
both computation of scissor bounds, and making sure to early out
when yMin >= yMax to avoid OOB buffer indexing.

Bug: chromium:904276
Change-Id: I14580d7c4f0d9888c19e037b47113624a247ede1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29971Tested-by: Antonio Maiorano <amaiorano@google.com>
Presubmit-Ready: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

ENABLE_RR_DEBUG_INFO was not being passed to the ReactorLLVM target.
This introduced a subtle calling mismatch as the RValue<T> copy constructor is conditionally added only when ENABLE_RR_DEBUG_INFO is defined.
This would cause parameters to go out of sync for inlined functions (not entirely sure I understand the underlying cause here), leading to hilarity.

This change also moves "-fno-exceptions" back to the global cpp_flags. This is a true global setting and should not have been moved to SWIFTSHADER_COMPILE_OPTIONS.

Change-Id: Ib20777f1ee4b443358ada667902f9a6a1ac3513a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29932Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

The cache keys were colliding, causing mayhem.
Add 32-bit unique keys to ImageViews and Samplers, combine them into a unique 64 bit key.

Bug: b/131246679
Change-Id: I74c86a80ee5fec1c97eda720bd0797bff4a1a7e0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29934
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Some SampledImageDescriptor members are assumed to be 16-byte aligned,
such as the sw::Mipmap::pitchP member accessed by sampleFloat2D(). To
guarantee this while descriptor sets can contain multiple types of
descriptor, all descriptors are made a multiple of 16 bytes in size.

Also, each descriptor set starts with a pointer to its layout, followed
by the actual descriptor content. To ensure the latter is 16-byte
aligned, the layout pointer was placed in a header structure which
itself is 16-byte aligned and thus includes the necessary padding.

The placement of the descriptor set itself is guaranteed to be 16-byte
aligned by vk::REQUIRED_MEMORY_ALIGNMENT = 16 being used for descriptor
pool allocation.

Bug: b/129523279
Bug: b/123244275
Change-Id: I72fb92d9ff5a8d100d05f5b9e38170ade557d434
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29970
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

Newer versions of clang are warning about all of these

Change-Id: I73a54ab653a741f9b8a7fb5e11ccd7d83069b966
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29972Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Brian Osman <brianosman@google.com>

Bug: b/126873455
Test: *opquantize*
Change-Id: I941ce6e2f39b81686eeb91b92694a14fa3b9f5f7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29569
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Change-Id: Ie75927a91a168ea0ec06ee9c97e6a248a5309c19
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29933Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Bug: b/119620767
Test: dEQP-VK.pipeline.image_view.view_type.1d.format.r8g8b8a8_unorm.subresource_range.lod_base_mip_level_remaining_levels
Change-Id: I977598ee0513928e6a6ce6ba5d0b698653c74fdc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29968
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

Change-Id: Ib4974a5f0dea325e198905cb94bae138ccac4c6e
Test: dEQP-VK.texture.swizzle.component_mapping.*
Bug: b/129523279
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29950Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

- Collect input attachment formats from the current subpass
- Include InputAttachmentIndex in descriptor decorations
- Make window-space integer coords available to fragment shader
- Rework EmitImageLoad to use VkFormat rather than spirv format
- Use window-space-coord-relative addressing for GetTexelPointer
  on spv::DimSubpassData images
- Use input attachment format rather than OpTypeImage baked-in
  format for spv::DimSubpassData images.

Bug: b/131171141
Test: dEQP-VK.renderpass*.input.*
Change-Id: I15412e66516ea907d4b2ffd913a9eb1a3f8a9bb9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29689Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

This was claiming depth, integer, etc were all filterable which is
nonsense. Rearrange to just two blocks: filterable, and not.

Bug: b/117974925
Change-Id: I5228454a3f1ac05e9d46e19af4dc98418885fa90
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29850Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Test: dEQP-VK.texture.swizzle.component_mapping.*
Bug: b/129523279
Change-Id: Ib4f7cd6c90fe7bde7d1abd2ecf77e3abbe121438
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29949Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Test: dEQP-VK.texture.swizzle.component_mapping.*
Bug: b/129523279
Change-Id: Ib081a299d77e9e165fa3dbb7764c5ead8e507406
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29948Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/119620767
Change-Id: Ia00deb9b225f38b7faf8bf0fb41d02b0f8b36ebc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29849Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Android builds fail for this warning.

Bug: b/130335507
Bug: b/130461662
Change-Id: I2c5be9199f9a393d477345c194cdf940cc7404eb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29870Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Addresses this review comment:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/29810/5/tests/VulkanUnitTests/VkInstanceFuncs.hpp#20

Change-Id: If8ea18b2090f00067e346bf55b8db1ac4c22d751
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29869Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

We were building both and only using one.

Speeds up builds.

Change-Id: I37af0973c50c38610e1d7322e29966cf36ae0e23
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29056Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Apparently there's "Clang" and "AppleClang".

CMAKE_CXX_COMPILER_ID MATCHES "Clang"
matches against both, where as STREQUAL will not consider "AppleClang" as a match.

Bug: b/130343040
Bug: b/130335507
Change-Id: I3d09a726924a7bbf8dc061349fc9fa504f7d08e2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29868Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: I1c858cf3f3d3733453d8aec19730581c7235e42d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29871Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

1D images are currently sampled as if they're 2D images, by setting the
second coordinate to 0.

Bug: b/129523279
Test: dEQP-VK.binding_model.shader_access.primary_cmd_buf.combined_image_sampler_mutable.fragment.single_descriptor.1d
Change-Id: I9aa20cb8b4d43cfdce28c1ec697a72fb6c49c6b5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29775Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Emit a call to a different trampoline function for generating the
sampler code, which unifies the implementation with
OpImageSampleExplicitLod's by using a common EmitImageSample which
takes a sampler 'method' enum. This is then passed at shader execution
time to emitSamplerFunction.

The lod parameter is parsed from the instruction stream in
EmitImageSample. Other (optional) image operands are left unimplemented
for now.

Bug: b/129523279
Test: dEQP-VK.binding_model.shader_access.primary_cmd_buf.combined_image_sampler_mutable.fragment.single_descriptor.2d
Change-Id: I265b81d953fe5a0496d029704a0f5eeff4229823
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29774Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

Use a common method for updating mutable and immutable sampler
descriptors.

Bug: b/129523279
Test: dEQP-VK.texture.filtering.2d.formats.r8g8b8a8_unorm.*
Change-Id: I1ef82c8fe2cbb2e92f3dadce794346be525648b8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29848
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

This does nothing, and breaks the Android build since the toolchain
there uses -Wignored-qualifiers. This is the only case of it in
SwiftShader.

Change-Id: Ida06e695bd3f303200864a4fd2a797cb4c78dc15
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29888Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Android recently split vulkan_headers (vulkan.h etc) from
hwvulkan_headers (HAL module plumbing, etc). Adjust to match.

Change-Id: I912cfa900363307abb271f74d9c8ebc683cada42
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29772
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Fix all code that had trailing semicolons.

Some downstream projects also consider these as errors, so this change catches the breakages at the source.

Bug: b/130343040
Bug: b/130335507
Change-Id: I19ef3b5c682524542cde68f917ca9310a19da286
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29810Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

set_cpp_flag affects everything, including 3rd party code.

We need to perform this separation as 3rd party code has unfixed warnings that we want to check for in our code.

This also has the added benefit that we can use build switches (DCHECK_ALWAYS_ON, REACTOR_EMIT_DEBUG_INFO) without requring a full rebuild of LLVM.

Bug: b/130343040
Bug: b/130335507
Change-Id: I577653e8eb3c4e588fc582f324b5ab6095662e54
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29809Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: Id110c8775a1ea905e4025225c3a72a5a4364de11
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29771
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

It appears to be undefined for me.
Let Kokoro decide if it is required.

Change-Id: I0052703552dd0727e6d3dc12f7947ce06faee5f6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29054Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/129523279
Change-Id: Id77a2168c11a66dddebf893d1527647b30584832
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29773Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

- Implement support for mipmapping:
  Involved fixing retrieving correct texel pointers for each mip level.
- Implement addressing mode.
- Implement filter mode.
- Removed textureSize(). We already have an implementation of
  OpImageQuerySize which doesn't require the sampling code.

For now, these parameters are converted to the legacy sampler enum
values to avoid a big refactoring which may break functionality before
we pass the tests. Future changes will eliminate them in favor of using
the Vulkan sampler parameters directly.

Bug: b/129523279
Test: dEQP-VK.texture.filtering.2d.formats.r8g8b8a8_unorm.*
Test: dEQP-VK.pipeline.sampler.view_type.2d.format.r8g8b8a8_unorm.*
Change-Id: I313e598ae61c0016a5a929bf5c1a53b66b3ff0d1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29770Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Vulkan 1.1 section 15.3.5 table 24 specifies "Conversion to RGBA"
to use 'one' as the last component when it's not present in the format,
where "one = 1.0f for floating-point formats and depth aspects, and
one = 1 for integer formats and stencil aspects", and 0 for the other
missing components.

Bug b/129523279

Change-Id: I9e4b0b9a8d1d696e51fc76b6554045835966c4b0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29274
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

The fixed-function OpenGL ES 1.1 and Direct3D 8 texture sampling
operations used 4.12 fixed-point values. SPIR-V only returns float4
or int4 results.

Also eliminate handling of 'null' textures. Vulkan 1.1 demands valid
descriptors

Bug b/129523279

Change-Id: I692bcaced55082b41a9c8a18551c23b03cb18430
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29272
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

There's only one type of pointer now.

Bug: b/131224163
Change-Id: Ie285affbdd05fdfc878f8144b3c6569547634f6d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29570Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>