- 09 Apr, 2020 1 commit
-
-
Alexis Hetu authored
A test in dEQP was failing using SwANGLE in debug. The test was using a 1200x1200 grid -> 1,44M squares -> 2,88M triangles This was exceeding our hardcoded limit of 1 << 21 (2,097,152). Removing this code makes the test pass. Bug: b/152958809 Change-Id: I43fc3c0c9d78378911ab0238a908367ba310c09e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43668 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 08 Apr, 2020 8 commits
-
-
Ben Clayton authored
Do this by breaking up the monolithic `runDaily()` function, and combining errors from the new `postDailyResults()` and `postCoverageResults()` functions. Bug: b/152192800 Change-Id: I031b37fa32d6d05ae1c38dff27a180c809aa4fe1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43649Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
Added CMakeLists.txt to the following folders that produce the following targets: src/OpenGL/common -> libGLESCommon (new) src/OpenGL/compiler -> GLCompiler src/OpenGL/libEGL -> libEGL src/OpenGL/libGLESv2 ->libGLESv2 src/OpenGL/libGLES_CM -> libGLES_CM Change-Id: I8217918b13b6963d18d1e6f89b4fa9e806bb36db Bug: b/145758253 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43588 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
This change add a CMakeLists in each of the following folders, and creates the following targets: src/Common -> gl_common src/Main -> gl_main src/Renderer -> gl_renderer src/Shader -> gl_shader Bug: b/145758253 Change-Id: Ia1f68d0689f80955586235e125e0197da25d692d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43550 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
This change makes it so that source/Common and source/Main are only referenced by the SwiftShader target. This will allow for better target-based sub CMakeLists. * Remove SharedLibrary.hpp/cpp from source list of libGLESv2 and libGLES_CM, as both of these depend on SwiftShader, which already builds these files. * Make libEGL depend on SwiftShader, so we can remove SharedLibrary.hpp/cpp and Main/libX11.hpp/cpp from its source list. Bug: b/145758253 Change-Id: If3d8e12cd09fb40d699080c2eeaa8243abe50512 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43528Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
This benchmarks `sw::LRUCache`, which currently resides in the `src/Device` folder (but will be moved to `src/System`) with 43489. Bug: b/153338950 Change-Id: I169b6ecb4a35349726a01b1da52472eaef3dfd74 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43492Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
This isn't used. There's another Cast() declared at vk scope, below VkCommandBuffer that actually is used. Bug: b/153462569 Change-Id: Id348676c9bb00aa934a972a2833ac6a1d3af54c1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43575Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Holds sw::Profiler that is entirely dead code. There's little here that looks worthy of keeping. Let's remove it. Bug: b/153462569 Change-Id: I4330781e8ba362461f164f0a52f764d4fe8f4dc4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43574Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
This is a primitive check to ensure that .bp, .gn and .bazel files don't have source references to missing files. This can catch a common build breakage. Fixes: b/153439736 Change-Id: I95621f8775a0e536015d4da9897785935f130884 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43572 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 07 Apr, 2020 7 commits
-
-
Ben Clayton authored
The uncovered span calculations were ignoring span groups and inverted spans. This is now correctly handled by Tree.allSpans(). Bug: b/152192800 Change-Id: I2bd8afa3c956b03b598a3d5297cb775fd19da35d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43573 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
This had regressed mostly due to a single thread processing a huge number of `Span.Add()`s. Optimize for the common case, avoid `Span.Add()` in places where the data is already sorted, don't scan the entire file system for every test run. Bug: b/152192800 Change-Id: Id183468263e65bfbcf387ec1c978d8b9de547cee Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43570Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
This caused `TestTreeEncodeDecode` to fail, and would make the reparsing of a coverage file incorrect. Bug: b/152192800 Change-Id: Ic9f4c49c58350509f74755fec20f22b6c1213877 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43569Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
`include/marl/sal.h` was replaced with `include/marl/tsa.h`. Also add other missing files. Bug: b/140546382 Change-Id: I7f766b3c362de2ce6e4e317762de98db50467d8f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43571Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Includes new Thread Safety Analysis helpers Changes: 539094011 CMake: Export MARL_THREAD_SAFETY_ANALYSIS_SUPPORTED c7f70ba7a CMake: Bump min version + include(CheckCXXSourceCompiles) 658a204fc Replace SAL annotations with clang's TSA annotations 9630bec2f Fix CMake warning: "Policy CMP0023 is not set" 9f369ad5d Update yarn:: to marl:: in an example Commands: ./third_party/update-marl.sh --squash Bug: b/140546382 Change-Id: Idb4253c11cece99ea4b22f965b974b63e26b51a7 -
Ben Clayton authored
539094011 CMake: Export MARL_THREAD_SAFETY_ANALYSIS_SUPPORTED c7f70ba7a CMake: Bump min version + include(CheckCXXSourceCompiles) 658a204fc Replace SAL annotations with clang's TSA annotations 9630bec2f Fix CMake warning: "Policy CMP0023 is not set" 9f369ad5d Update yarn:: to marl:: in an example git-subtree-dir: third_party/marl git-subtree-split: 53909401165022553ed9d1f0c572178559dc25ec
-
Ben Clayton authored
List all files, including those that have no coverage. Emit spans that were compiled, but not covered. Emit a % coverage per file. Bug: b/152192800 Fixes: b/153182184 Change-Id: I31c831273a8d3ee89c7ce0737b6e05398ff4f51b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43491 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 06 Apr, 2020 4 commits
-
-
Alexis Hetu authored
True integer formats should not use blend modes. This cl explicitly disables any blend operation on render targets using integer formats. Bug: b/153203552 Change-Id: Ia756953c61caef8e32e55aa31126044973ae1870 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43548 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Antonio Maiorano authored
Hack for minor precision issues with current implementation. Fixes 8 quality warnings from deqp-gles3 when run against SwiftShaderGL/Subzero. Bug: b/151461290 Change-Id: I4a3148add2c0987dcccca96e7c877ea4fb16ca89 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43470 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
Cleaning up unused code Bug: b/153177839 Change-Id: I42479778f0f6ec9a955ba7f863766429b68c73a3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43468 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
These were added for the .gn build, but were never enabled for the CMake build. Test these as part of the Kokoro presubmits. Bug: b/153193374 Change-Id: I36e7428bfe1a4867bea39b2fbb302aed6c3dff7b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43488 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 04 Apr, 2020 1 commit
-
-
Ben Clayton authored
Bug: b/153168751 Bug: b/153206490 Change-Id: I2822f60aa380ae3885bc674d9f7b1f283c087e95 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43490 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 03 Apr, 2020 14 commits
-
-
Antonio Maiorano authored
Bug: none Change-Id: I9f58cc3bf6b457fc8b916a98242138865f89c577 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43469Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
I broke this when I removed the relative path to the third_party astc include file in this change: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43269 Bug: none Change-Id: I45de8a6159c69c893df4449f6c6e10b09a9e6fe4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43448Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Ben Clayton authored
When `ENABLE_VK_DEBUGGER` is defined, VkDevice needs to be declared in order to build. Bug: b/148401179 Change-Id: If35f3a1425ec0d739750d632305a625c7e12b721 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43432Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
`VirtualFile`s are typically used for files with no physical backing. Use `PhysicalFile` if there's no content provided in the debug info. Bug: b/148401179 Change-Id: I1e1ed75ce9a9fb0965420267aba7f6d8de958012 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43430Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
This is common for virtual and physical files. Bug: b/148401179 Change-Id: I266097382098c1daf776ae64d878f08febee5d0e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43429Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
https://github.com/KhronosGroup/SPIRV-Headers/issues/137 is still ongoing. Fixes: b/15093697 Change-Id: I2498f35a8049fb2a1a86aa0efe6fbd6e59ad6493 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43428Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Antonio Maiorano authored
Bug: b/145758253 Bug: b/152606052 Change-Id: I826225ed393ed324301555ebaea14947997632cf Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43289Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
Also remove dependency of third_party/astc-encoder on src/System/Debug.hpp. Bug: b/145758253 Change-Id: I329928d9221c99a416fcdb1b0dd44d2578a22cb8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43269Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Antonio Maiorano authored
Remove unused and useless variables. Also fix the build when SWIFTSHADER_ENABLE_VULKAN_DEBUGGER is enabled. Bug: b/145758253 Change-Id: Ie49dd88d6716b24fe31baa8f8d162e7dacfa5a3c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43268Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Antonio Maiorano authored
Bug: b/145758253 Change-Id: I36f1bbf599389c27e084fea9af3d732225567076 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43230Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
This adds a third_party/boost folder with a CMakeLists.txt. If this folder is added via add_subdirectory, it downloads boost to the binary directory and exposes the Boost::boost target. Bug: b/145758253 Change-Id: I7d4e383630cb84da928cf0622a641e9e0efc2ad8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43191Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
This change also fixes compilation on Linux when REACTOR_EMIT_DEBUG_INFO is enabled, which has been broken since "-fno-exceptions" was added to SWIFTSHADER_COMPILE_OPTIONS. Also, at some point, LIBBACKTRACE_CONFIG_DIR stopped being used, which further broke compiling libbacktrace. Bug: b/145758253 Change-Id: I50f0e2c2c1dabc357dfc255a471eaf1e9fed1c2e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43189Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
Bug: b/145758253 Change-Id: Ife32c322cf87c9b1b98b4b50f591b75db6ea51e2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43148Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Ben Clayton authored
Bug: None - Fix Kokoro presubmits. Change-Id: I16074e733edd257647840d1bf51ebdc14dd4fb89 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43431Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 02 Apr, 2020 5 commits
-
-
Nicolas Capens authored
This code has no remaining known active uses. It has been archived in the 'legacy-d3d9' branch. Bug: b/139189696 Change-Id: I64bf27ff6c02be560963d7eab36c9c328bb280c5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43232Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
CMake should be used instead. Note that the CMake build does not support the D3D9 and D3D8 targets. They can still be built with Visual Studio 2019 from the 'legacy-d3d9' branch. Bug: b/139189696 Change-Id: I7b5006fa98e479d6d1a3bb75d379a5818a560c20 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43231 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
cf. https://swiftshader-review.googlesource.com/c/SwiftShader/+/43388 Bug: build fix Change-Id: I8d2acc0bbb19fa71748aafeebd6c0d500673ed93 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43408Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Spotted by Chris Forbes: * `std::remove_if` wasn't introduced in C++20, it's been there since 98. I just can't read docs. * Also fix the lack of `list.erase()`. Bug: None. drive-by-code-reviewing-fixes. Change-Id: I456d540ba973640747d6e4cb23faec65a4a9c83d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43348 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Nicolas Capens authored
It was only still being used to store framebuffer blend constants. Use sw::float4 instead. Bug: b/146224130 Change-Id: Ie5660e237f4b675564d5a492f9d0a38505d07953 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43388Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-