Commits · 4ceb77de89b63c71ec26df17b4e40aca27e53fa4 · Chen Yisong / swiftshader

24 Apr, 2019 14 commits

CMakeLists: Migrate from set_cpp_flag to per-project settings. · 4ceb77de

authored Apr 24, 2019

set_cpp_flag affects everything, including 3rd party code.

We need to perform this separation as 3rd party code has unfixed warnings that we want to check for in our code.

This also has the added benefit that we can use build switches (DCHECK_ALWAYS_ON, REACTOR_EMIT_DEBUG_INFO) without requring a full rebuild of LLVM.

Bug: b/130343040
Bug: b/130335507
Change-Id: I577653e8eb3c4e588fc582f324b5ab6095662e54
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29809Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

4ceb77de

Include reactor debug functions in Android build · 47d879a7

authored Apr 23, 2019

Change-Id: Id110c8775a1ea905e4025225c3a72a5a4364de11
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29771
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

47d879a7

CMakeList: Remove the CLANG_VERSION_STRING check · b328e0d3

authored Apr 15, 2019

It appears to be undefined for me.
Let Kokoro decide if it is required.

Change-Id: I0052703552dd0727e6d3dc12f7947ce06faee5f6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29054Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

b328e0d3

Refactor common sampler code · b5d5f478

authored Apr 24, 2019

Bug: b/129523279
Change-Id: Id77a2168c11a66dddebf893d1527647b30584832
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29773Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

b5d5f478

Implement basic sampler parameters · 9e73510a

authored Apr 18, 2019

- Implement support for mipmapping:
  Involved fixing retrieving correct texel pointers for each mip level.
- Implement addressing mode.
- Implement filter mode.
- Removed textureSize(). We already have an implementation of
  OpImageQuerySize which doesn't require the sampling code.

For now, these parameters are converted to the legacy sampler enum
values to avoid a big refactoring which may break functionality before
we pass the tests. Future changes will eliminate them in favor of using
the Vulkan sampler parameters directly.

Bug: b/129523279
Test: dEQP-VK.texture.filtering.2d.formats.r8g8b8a8_unorm.*
Test: dEQP-VK.pipeline.sampler.view_type.2d.format.r8g8b8a8_unorm.*
Change-Id: I313e598ae61c0016a5a929bf5c1a53b66b3ff0d1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29770Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

9e73510a

Default to [X,0,0,one] for undefined texture components · ef6152eb

authored Apr 16, 2019

Vulkan 1.1 section 15.3.5 table 24 specifies "Conversion to RGBA"
to use 'one' as the last component when it's not present in the format,
where "one = 1.0f for floating-point formats and depth aspects, and
one = 1 for integer formats and stencil aspects", and 0 for the other
missing components.

Bug b/129523279

Change-Id: I9e4b0b9a8d1d696e51fc76b6554045835966c4b0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29274
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

ef6152eb

Eliminate fixed-point texture sampling · 2d54840b

authored Apr 16, 2019

The fixed-function OpenGL ES 1.1 and Direct3D 8 texture sampling
operations used 4.12 fixed-point values. SPIR-V only returns float4
or int4 results.

Also eliminate handling of 'null' textures. Vulkan 1.1 demands valid
descriptors

Bug b/129523279

Change-Id: I692bcaced55082b41a9c8a18551c23b03cb18430
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29272
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

2d54840b

SpirvShader: Combine DivergentPointer and NonDivergentPointer · 1d514f34

authored Apr 19, 2019

There's only one type of pointer now.

Bug: b/131224163
Change-Id: Ie285affbdd05fdfc878f8144b3c6569547634f6d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29570Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

1d514f34

Reactor: Add Gather and Scatter instructions. · 0fc611f1

authored Apr 18, 2019

Use these for a fast-path for Load() and Store().

This is an attempt to fix the severe performance hit we incurred with robustness.

Bug: b/131224163
Change-Id: I3e244bed5ed723cf29538ff022781c813caaa5eb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29454Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

0fc611f1

SpirvShader: Refactor loads and stores. Consider limits. · 9e4bc1ba

authored Apr 16, 2019

This change moves all calls to rr::Load() and rr::Store() to two
new functions: SIMD::Load() and SIMD::Store(). This attempts to
consolodate the SIMD memory ops into reusable functions, while
also adding bounds checking on the accesses.

The additional branches hurts the JIT codegen performance.
This will be resolved with a future change.

Tests: dEQP-VK.robustness.*
Bug: b/131224163
Change-Id: I3a392a1f4f5366fa5134c081e0a2479575f92d80
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29334Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

9e4bc1ba

Reactor: Hook up atomic load/store intrinsics. · 4d1f8d05

authored Apr 17, 2019

These may be required with the new SIMD::Load and SIMD::Store implementations.

Bug b/127472316
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.load
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.store

Change-Id: I89db49d7c27c268d37d1bb768adfefd99c11c7c0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29449
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

4d1f8d05

LLVMReactorDebugInfo: Remove REACTOR_LLVM_VERSION check · 3c830834

authored Apr 24, 2019

This code was added just before LLVM 3 was removed, and can be considered a merge conflict.

Bug: b/130460252
Change-Id: If7d6f46c78a94cb8f3cc07ec4ba7c91a58e5926d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29813
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

3c830834

Regres: Update test lists @ · ea1b0983

authored Apr 24, 2019

Change-Id: Ic67efe0d3977417dcc941e103cd37d4ac09998cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29788Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

ea1b0983

Set up input attachment descriptors the same as storage images · a1614939

authored Apr 22, 2019

These work the same way; differences are in coordinate handling and
where we find the image format.

Bug: b/131171141
Change-Id: I9dccfd88e686102d6200bdba8a8ad64b7debeca3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29688Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

a1614939

23 Apr, 2019 10 commits

Synchronize before performing mid-subpass attachment clears · ed46cde6

authored Apr 22, 2019

Bug: b/119620767
Test: dEQP-VK.renderpass*
Change-Id: I749c26e9924d69735f45ca981957016718fe5b0a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29708Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

ed46cde6

Only do centroid sampling if multisampling · 451cad2c

authored Apr 19, 2019

Previously if sample count were 1, we would skip the setup for the
centroid 1/w, and then blindly use it, leading to NaN in all interpolants marked `centroid`.

Bug: b/118386749
Test: dEQP-VK.glsl.linkage.varying.*
Change-Id: I4f5d0b052f2defaad86706b85790ef14cd42f53f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29650Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

451cad2c

Remove more stale renderer plumbing · 37f2bd82

authored Apr 19, 2019

alphaReference is not used. It previously provided a configurable
threshold for alphaToCoverage, before that was explicitly managed by
pipeline state.

The sample mask is not dynamic state, so it can never change between
draws without a complete context change.

sRGB write control is not context state, it is determined by the image
view format.

Bug: b/118386749
Change-Id: Id631732fad52cf6b75c1635bcd7ef464dda10e54
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29649Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

37f2bd82

Wire up alphaToCoverage support · eae5b965

authored Apr 19, 2019

All the real work was already done; this just needed connecting.

Bug: b/118386749
Test: dEQP-VK.pipeline.multisample.alpha_to_coverage.*
Change-Id: Ib1e2b7a64a76d8d7df9ed5c93e4cc738efdd83b3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29648Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

eae5b965

Unify template-based and classic descriptor writes · bc694e28

authored Apr 19, 2019

The template-based descriptor write mechanism had got left behind as
more descriptor types were added. Reimplement the classic mechanism in
terms of a template entry, and implement all the current logic there.

Bug: b/123244275
Test: dEQP-VK.binding_model.*
Test: dEQP-VK.spirv_assembly.*
Test: dEQP-VK.glsl.*
Change-Id: Ide5a6bf70978774170f79d42652c746c2b5b8abd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29608Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

bc694e28

Add support for indexing into arrays of image descriptors · 0b092cd9

authored Apr 19, 2019

- OpLoad of pointer to descriptor is passthrough; reflect that in Kind.
- Actually pass through all the descriptor types in EmitLoad
- Fix Walk*AccessChain to not create useless divergence; constant offset
  was added in the wrong place.
- Adjust WalkAccessChain to adjust pointers into descriptor arrays using
  the descriptor stride
- Adjust storage image descriptor content to not assume layerPitch ==
slicePitch, since that isn't true.

Bug: b/131082089
Test: dEQP-VK.binding_model.*
Test: dEQP-VK.spirv_assembly.*
Test: dEQP-VK.glsl.*
Change-Id: I6cc4ae7b0fdeb54ede111f532c7e3fd1f108803c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29549Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

0b092cd9

Clean up storage image descriptor access · 621a7bd0

authored Apr 19, 2019

We already have the pointer available; no need to recompute it from the decorations.
This is groundwork for being able to index into arrays of storage image
descriptors correctly.

Bug: b/131082089
Change-Id: I574968b6ab8d205d5e4e3fcb4df5d08d2b88dcfa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29568Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

621a7bd0

Regres: Update test lists @ · 652edcc3

authored Apr 23, 2019

Change-Id: I36296a8948651faeaeeea8ae4f46237701a64137
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29748
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

652edcc3

Add support for OpAtomicISub, OpAtomicIIncrement, OpAtomicIDecrement · 707ed997

authored Apr 18, 2019

These are the remaining operations which were not tested through the
dEQP-VK.image.* path.

Test: dEQP-VK.spirv_assembly.*
Bug: b/127472316
Change-Id: Icedc2fc7b972714bc67705e2458e1207972b95cc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29457Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

707ed997

Add support for OpExtension · 9869d601

authored Apr 18, 2019

Accept SPV_KHR_storage_buffer_storage_class, which is part of SPIRV 1.3.

Bug: b/130937460
Test: dEQP-VK.spirv_assembly.*
Change-Id: Ifbef9f3093ce7cca90edd75ebd86831f16b630cf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29508Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

9869d601

22 Apr, 2019 1 commit

Regres: Update test lists @ · 4f15ce2e

authored Apr 22, 2019

Change-Id: I40b6d61fd0de9d9e5d2b63974459c9199ea71b48
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29668
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

4f15ce2e

21 Apr, 2019 2 commits

Reactor: Remove trailing semicolons. · bcc71a32

authored Apr 21, 2019

Produce warnings for Chrome, resulting in errors.

Change-Id: Icda954e1d6c8da79ecf5eddbd542a38a8d97847a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29670
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

bcc71a32

Remove LLVM 3 from SwiftShader and all references. · 5875be51

authored Apr 11, 2019

There's LLVM code that can now be cleaned up, but that'll come as another pass.

Bug: b/130343040
Change-Id: Ie16e296fc1c4d226a81b221d18447cbc09cc2c16
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28909Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

5875be51

20 Apr, 2019 1 commit

LLVMReactor: #error if usng LLVM 3 · 20507fa9

authored Apr 20, 2019

An easy to revert step towards https://swiftshader-review.googlesource.com/c/SwiftShader/+/28909.

Bug: b/130343040
Change-Id: I0180e9698bedd2f11749faca1deef141e7000dc4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29669
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

20507fa9

19 Apr, 2019 7 commits

Fix comment describing compare/exchange behavior · c9ca99ee

authored Apr 19, 2019

Change-Id: Iacc8bd65e9f8ba268dbe7dae6aa244a25c6f770a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29548Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

c9ca99ee

Switch SIMD::Pointer::base from a Float* to Byte* · 97035bde

authored Apr 16, 2019

While having the base units as sizeof(float) is handy (as that's the smallest unit we currently support), it makes limit checking tricky as we're continually converting units of byte <-> float.

This sets us up nicely for when we want to support smaller types.

Change-Id: I3e334b6df4899f433b281118be23fdf8df6d9829
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29328
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

97035bde

SpirvRoutine: Use SIMD::Pointers for pointers map. · 5f7e9117

authored Apr 16, 2019

The split of intermediate + base pointer in two maps was ugly.
This is also required for tracking bounds on pointers, required for robustness tests.

Change-Id: I782aeee8caab43ce58ba948dcca97afa2e07482c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29273
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

5f7e9117

Regres: Update test lists @ · 7dd3889f

authored Apr 19, 2019

Change-Id: I811ea5cb03f072003d886289c3b87d7d8498d4dc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29528Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

7dd3889f

Add support for OpAtomicCompareExchange · a16238df

authored Apr 18, 2019

Includes associated Reactor plumbing.

Bug: b/130768731
Bug: b/127472316
Test: dEQP-VK.image.*
Change-Id: I700eb29f976410b59778e4ed162066b84a55a974
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29456Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

a16238df

Add support atomic instructions as used with storage images · 17813930

authored Apr 18, 2019

- OpAtomicIAdd
- OpAtomicSMin
- OpAtomicSMax
- OpAtomicUMin
- OpAtomicUMax
- OpAtomicAnd
- OpAtomicOr
- OpAtomicXor
- OpAtomicExchange

Includes required plumbing down through Reactor. Subzero support is just
stubbed for now.

Bug: b/130768731
Bug: b/127472316
Test: dEQP-VK.image.*
Change-Id: Iecf9e9ed602c4fde674f54491658048c96fd02c6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29453Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

17813930

Add support for OpImageTexelPointer · b51f2c17

authored Apr 18, 2019

Bug: b/130768731
Test: dEQP-VK.image.*
Change-Id: Ifdac16163b729a552df5369fdf089cae3dee8ecf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29452Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

b51f2c17

18 Apr, 2019 5 commits

Dynamic dispatch for image samplers · 96fbe081

authored Apr 16, 2019

Bug: b/130746922
Change-Id: I35dfcb93c8e902d0be566fad50ae991d5490e853
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29348Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

96fbe081

Factor out GetTexelOffset from EmitImageRead/EmitImageWrite · 89c37a4d

authored Apr 17, 2019

Also fix the addressing to correctly use the slice pitch to advance to the correct layer in an arrayed 1D texture, rather than using the row pitch.

Bug: b/130768731
Test: dEQP-VK.image.*
Change-Id: I46b8c4eb353d7901d5953df46138ff9e01f87ead
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29411Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

89c37a4d

Add support for OpImageRead · 2f7f2ecb

authored Apr 17, 2019

Bug: b/130768731
Test: dEQP-VK.image.*
Change-Id: Ib3e9b5cd4b28f9ed3020dcd4e724cf961c3ddac3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29410Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

2f7f2ecb

Add support for OpImageWrite · 179f014f

authored Apr 17, 2019

Bug: b/130768731
Test: dEQP-VK.image.*
Change-Id: I63334478b014d36ed789604154797717159d4f37
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29448Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

179f014f

Implement OpImageQuerySize · b0d00eac

authored Apr 17, 2019

Tests: dEQP-VK.image.image_size.*
Bug: b/129523279
Change-Id: I6ec474bb5fcdab8853ac4afaa2967bbc4023c970
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29268Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

b0d00eac