Beware: the dEQP tests here are very weak - they do not seem to properly test the NaN handling of this instruction.

Bug: b/126873455
Tests: dEQP-VK.spirv_assembly.instruction.compute.opnclamp.all
Change-Id: I8d1f80f5536996ca46c30ee4895d9f6e2c29a03e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28711Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Beware: the dEQP tests here are very weak - they do not seem to properly test the NaN handling of this instruction.

Bug: b/126873455
Tests: dEQP-VK.spirv_assembly.instruction.compute.opnmax.all
Change-Id: Ibd704c9dc9c3475df10b02c0c0f80b9c3e472ff4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28710Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Beware: the dEQP tests here are very weak - they do not seem to properly test the NaN handling of this instruction.

Bug: b/126873455
Tests: dEQP-VK.spirv_assembly.instruction.compute.opnmin.all
Change-Id: I5283af4a1e697b080f53193bc21ddd446b232d1e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28709Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Was removed from the spec in version 0.99.

Bug: b/126873455
Change-Id: I93c60b7d1e8332e70f7116636384f4f85ea542cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28708Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

RcpSqrt_pp is not accurate enough to be used on non-relaxed precision types.

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.inversesqrt.*
Change-Id: I3e34d28dbd863c9cb14cf6c79afe08a1992b5478
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28697Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

While not strictly necessary (we could always calculate with the highest precision), it is a tiny amount of work to dramatically increase performance of instructions like InverseSqrt for relaxed precision types.

Bug: b/126873455
Change-Id: I42d5871a8e0886001e85fd4e16f8e6cb309236cf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28696Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.sqrt.*
Change-Id: Ia178618bb2777d9b58beef19d4e18767cc9a8f73
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28695Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.log2.*
Change-Id: I1a6a4e1fbf41ccd7aacf2fa7fbe8b8e7c6d28f3b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28443Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.exp2.*
Change-Id: I8a8f03a9dd1e30866b6f330c987d93bf4d95d265
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28442Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.log.*
Change-Id: I14cc590230dbbf4cfd24a0903bc2fbfb3c5a5192
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28441Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.exp.*
Change-Id: I35a28475b56d820b6306782188d72a151845fe58
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28440Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.pow.*
Change-Id: I74797e69adc78e4c06ec4a8b2923b78166afbc18
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28439Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.atan2.*
Change-Id: I85596109069d3cee8ebd5f65770cb06ca7b93e53
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28438Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.atanh.*
Change-Id: Ie58753a4a0bdef18ec317129f2c4a7f0c0c314b4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28694Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.acosh.*
Change-Id: Id02fae0c7020ee83cb612f9370cdbb5c4dc31af1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28693Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.asinh.*
Change-Id: I83b425bea2d693c5bcab3b1685252be0ba9fb023
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28692Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.tanh.*
Change-Id: If63f53b5d9d78dd4a2cd6c31c42cb16f03a48d98
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28691Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.cosh.*
Change-Id: I25b8d84bb8be76b816afade7c62e70fda2c926a0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28690Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Help mitigate merge conflicts as two people will be working on this at the same time.

Change-Id: I92534eb1c92ec9ce66178d6d669a473350a0c158
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28689Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.sinh.*
Change-Id: I59239dd0623260090ac662501bdefb2da273fd97
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28688Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.atan.*
Change-Id: Ic7dc89ca2b3253482e972ced46515fc83da33770
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28437Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.acos.*
Change-Id: I7f65b398b6dc9ba5daf2df0a98c41b50b9775cd2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28672Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.asin.*
Change-Id: Ifb1e6b5f54b27abfb4324f5d2246717400da639f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28671Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.tan.*
Change-Id: I229b46b285075bd25272145a562135df08438160
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28670
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.cos.*
Change-Id: I4b5fe36487f0832ad21f3e78df9ba133284cffbd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28669Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.sin.*
Change-Id: Iec96b2a235534fbc5b76c699a6b62679b75582ca
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28668Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.degrees.*
Change-Id: I4997c83f73a87957239e38fb14aef803b74ba911
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28650Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.radians.*
Change-Id: Iae78dac21165967d305a54157f60d95d13de5984
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28649Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.common.ldexp.*
Change-Id: Ie8ab0db7a7f712c5f876f521773217be5f350e4f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28648Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.common.fma.*
Change-Id: I00e890a6a051b45bc552944ec5364f070ee3a768
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28629Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.common.frexp.*
Change-Id: Ic725c53191c3a6ec6494859d6eb8e6a8eb77c90e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28628Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

- GLSLstd450PackSnorm4x8
- GLSLstd450PackUnorm4x8
- GLSLstd450PackSnorm2x16
- GLSLstd450PackUnorm2x16
- GLSLstd450PackHalf2x16
- GLSLstd450UnpackSnorm4x8
- GLSLstd450UnpackUnorm4x8
- GLSLstd450UnpackSnorm2x16
- GLSLstd450UnpackUnorm2x16
- GLSLstd450UnpackHalf2x16

Test: dEQP-VK.glsl.builtin.function.pack_unpack.*
Bug: b/126873455
Change-Id: I0c765bc215d43f894cad91c7ee06b5e3af3f75db
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28433Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

dEQP has no test coverage for this. Filed VK-GL-CTS #1728 to fix that.

Bug: b/126873455
Change-Id: I69524d0f4d5d15356eedd105645637af1a4f0f0f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28608Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.common.modf.*

Change-Id: Icefc1f7241aa1b3ef253b9f5775c38a424afec77
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28569
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Moved the generic Transform Feedback buffer out of the local Transform
Feedback Object (TFO), and into global state.

Bug chromium:818098
Tests: dEQP-GLES3.functional.state_query.indexed.transform_feedback_switching_buffer
Change-id: Ife86cc82bd57c33b9daec4870610b5eaea5c2f52
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28436
Presubmit-Ready: Sean Risser <srisser@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Sean Risser <srisser@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Added support for using the ImageView's format
to perform clear operations.

Bug b/119620767

Tests: dEQP-VK.image.mutable.*_draw_copy

Change-Id: I3ea6d3264435bbd8390c7a8907e0c7a54c4c6783
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28508Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

Constructor overloads in Reactor is causing the build on Android to fail.

Change-Id: I446b345d420b8789ece77a245b2cd3eab8499e35
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28444Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Change-Id: I7cce7aa50c61c6e2949796105dc980e260745eae
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28402Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Re-enabled the Renderer object's occlusion queries and linked them
to the queries in the query pool. Removed the old Query structure.

Passes all tests in:
Tests: dEQP-VK.query_pool.*

Note: The dEQP-VK.query_pool.*_discard tests currently fail as discard
      appears to disable the occlusion queries. Will fix in next cl.

Bug b/129706526

Change-Id: I937dcf64d2990758d31a1ed6a13af5cf9f0a627b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28288Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Cube images currently have a 1 pixel border around them for seamless
cubemaps. To add a border around a compressed image would require
adding an entire block's width/height around the image at each mip
level, which would take a lot of extra space and wouldn't be so
useful right now, since we'll perform both image decompression and
cubemap border update before sampling, so might as well do both at
the same time and only store a border in the decompressed image,
so that compressed cube images don't need to keep a border.

Bug b/119620767

Tests: dEQP-VK.pipeline.sampler.view_type.cube.format.*

Change-Id: I17974c0148fded37bca7c17a78d08d5e683a2afb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28548Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>