Bug: b/141380498
Change-Id: I25c6bf769c558fb4bc3a3a64f66289cf5dbfb879
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36595Tested-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Mostly copypasta from: src/Reactor/ExecutableMemory.cpp

Will be upstreamed to marl if the autorollers are happy.

Bug: b/140546382
Change-Id: I6cf0dc8638e37f17d097ea645c9a84cef1368a3d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37131Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

These build files are not upstreamed to the marl repo as they use SwiftShader specifics.
This means the file sets need to be updated whenever marl is updated.

Bug: b/140546382
Change-Id: I18181d95d2c8162525afc4fe7d49106bc2186562
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37130Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

* changes:
  Update Marl to 49e4e31
  Squashed 'third_party/marl/' changes from 12872a0df..49e4e3141

Bug: b/141863676
Change-Id: Ie6ea68edcc0505bf2931c0fe91e4be418c4a21e0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37108Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Includes fix for build failure in marl/blockingcall.h on old versions of GCC.

Changes:
  49e4e3141 Add blocking_call test for functions with non-void return.
  0acd85c63 blocking_call: Workaround for GCC bug with parameter packs in lambdas.
  ce47eca32 Work around TSAN false-positive in old versions of GCC
  85854b73a Implement allocation page guards
  d8b38213f Add missing header include guards
  776f7a485 Add Allocator interface and use them throughout marl.

Commands:
  git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash

Bug: b/140546382
Change-Id: I2b52f28b373bd724912ba13a208f1719e80a3638

49e4e3141 Add blocking_call test for functions with non-void return.
0acd85c63 blocking_call: Workaround for GCC bug with parameter packs in lambdas.
ce47eca32 Work around TSAN false-positive in old versions of GCC
85854b73a Implement allocation page guards
d8b38213f Add missing header include guards
776f7a485 Add Allocator interface and use them throughout marl.

git-subtree-dir: third_party/marl
git-subtree-split: 49e4e314157e8560f6ad620f5ec28a877612f03b

Bug: b/135744933
Change-Id: I6b37091c6390e5c3c67a608b85ecd3d9aef07580
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37028
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

CMake (without or without Visual Studio 2019) should be used instead
for the Vulkan build.

Bug: b/139189696
Change-Id: Ib87e34e2a210944446b8ea7bd57504acc4bc98d7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37068
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

LLVM 8 removes several x86 SSE intrinsics for saturated arithmetic, but
provides target-independent replacements. Note there are now three code
paths for these vector operations:
- With LLVM 8+, use the new target-independent intrinsics.
- With LLVM 7 on x86, use the SSE intrinsics.
- On other architectures, lower to a generic sequence of vector
  operations (lowerPSAT).

Bug: b/139412871
Change-Id: I849f8b5c004849c628507d6377779df170a11d93
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36788
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Hold a reference to the scheduler for each vulkan device.

This attempts to work around Windows-specific teardown issues, possibly caused by dependency atexit() logic.

Bug: b/141380274
Change-Id: I5a34c18f8e3738f02221f1784419bc21a6430067
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36990
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

"set -e" was aborting the script after grep doesn't find the Bug line,
and "set -x" makes things overly verbose. So perform the validation
before these options are set.

Also return 1 instead of 0 on failure.

Bug: b/141892461
Change-Id: Ica0364ff49383b47cf37b3a02d6b03e55d8d88ad
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37008
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

Proper implementation of a VkSemaphore using an std::mutex
and a marl::ConditionVariable. This should make the implementation
compatible with both fibers and threads at the same time.

A future CL will add platform-specific implementations to cover
external semaphores as well. Which explains why the implementation
details are hidden from VkSemaphore.hpp.

Bug: b/140421726
Change-Id: I1db55493a41db0eb60ce9181fe864253db09f4f8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35933Tested-by: David Turner <digit@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

GLsizei is historically defined as a 32-bit signed integer, which is
not allowed to be negative. But doing arithmetic with them can lead to
overflows producing undefined values, including negative ones.

Use size_t instead for these image data size calculations. It's defined
as an unsigned integer large enough to fit valid memory buffer sizes.
In practice that's 32-bit on 32-bit platforms, and 64-bit on 64-bit
ones, which is large enough to avoid overflow in the OutOfMemory test.

Bug: b/140421004
Change-Id: Id05dd64d470f579455fdc9925b0ab303ecaf37fb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36968Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

The Git change's commit message should have a line that starts with Bug:
or Issue:, followed by a bug ID. This is important for tracking purposes,
association with follow-up changes, and having a centralized place to
discuss issues.

Note that this change doesn't actuall check that the bug ID is valid.
Also, at this point Kokoro doesn't block submits.

Bug: b/141892461
Change-Id: Idf57534d24842e18dca90ec01e5bb134db612286
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36868
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

Not tested by dEQP (and unlikely to be, as we don't want to force
drivers to break existing content by adding new negative coverage in
general) but this was wrong.

Bug: b/141916742
Test: dEQP-EGL.functional.image.api.create_image_*
Change-Id: I774d197a9c5c47447c97d212b41e4c33ad963474
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36949Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

We need the face target here, not the whole texture target.
This fixes the one case that was actually broken, and avoids hitting
an assert in debug swiftshader for all tests in this group.

Bug: b/141916742
Test: dEQP-EGL.functional.image.api.create_image_gles2_cubemap*
Change-Id: I25ef8f6d6e2909adfc646e68f1711589777017ba
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36948Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Implemented operator< with std::tie to force strict weak ordering.

Bug b/141863676

Change-Id: If14328922f0c8c62fd92d74f1bcca0c9a2e77f4c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36929
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

Two issues here:
- Logic was inverted
- getTopLevel() isn't quite right. The condition in the spec is
  whether there are any nonzero levels defined; it does not require them to
  be contiguous with the base level.

Test: dEQP-EGL.functional.image.api.create_image_gles2_tex2d_rgba_level0_only
Bug: b/141916742
Change-Id: I336d628c9508bfe61d1471431cc6170454a24d1b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36888Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: I35e09ab64d57b64d163f5f698a2cf68300ae8dd9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36908
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

By setting LD_LIBRARY_PATH to the directory containing
libvk_swiftshader.so, this change enables running vk-unittests
from any working directory.

Bug: b/128618202
Change-Id: Ib10e4742b90a41d1ef9867b59ce2ccb7394e2b02
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36811
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

LLVM 7.0 already demands 3.4.3, and 3.6 improved Ninja support.

Bug: b/139189696
Change-Id: Ic94b6828e686646198d08bdd9bd886caa56a51df
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31770Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

We were checking whether we need to apply the write mask by erroneously
looking at whether the writeMask was non-zero. This meant that when the
write mask was zero, we would compute the stencil value, and store
it, rather than store 0. Instead, what we mean is to apply the write
mask if masking does something: when it's not FF (or 2^n-1, with
n = number of stencil bits).

Bug: b/141484021
Change-Id: I6134289ac8bb13a3502884e4e408f71961814adf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36848Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

Change-Id: I8aff59daf5c75458c404faba4f6a77f6c65e25c3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36770
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

The GLSL-version-specific behavior is already dealt with in earlier
checks; here we can assume we are dealing with GLSL ES 3.00.

The GLSL ES 3.00 spec section 5.7 explicitly calls out == and != as
being supported operations on arrays.

This is an unusual construct in real shaders, but it is used in the
various "complex expression" tests (in an unreachable path).

Bug: b/141916742
Test: dEQP-GLES3.functional.shaders.arrays.complex_expression.*
Change-Id: I8a4ece122d604ffb917b94c03c8a086230e9108a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36828Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

dEQP is very unhappy (and asserts if built in debug) with this since it
has the wrong channel count.

Test: dEQP-GLES3.functional.read_pixels.alignment.*
Change-Id: I35a46ba166d3964091d5e3b3066e3a593952c22a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36810Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

This masks a crash related to nested, unconditional continue statements.
Those constructs are known to be buggy, but we have elected to not fix
them at this point in time because the SWANGLE project will deprecate
all of Swiftshader's GLES backend.

It's unlikely that the remaining bug will effect many end-users as it
relies on bizarre control flow.

For logging purposes here is the shader code that reproduces an infinite
loop:

    void foo() { }

    void main() {
	for (int i = 0; i < 4; i++) {
	    continue;
	    for (int k = 0; k < 4; k++)
		continue;
	    foo();
	}
    }

I'm not adding this as a unit test since we aren't fixing our compiler.

Bug chromium:997283

Change-Id: Id31d70c4cd70a16fd20b7ebed18a82d5f8a705ba
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36708Tested-by: Sean Risser <srisser@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Change-Id: I97e65fcfdbab5e8ebf823ef528be3a048274a9ef
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36809Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

Bug: b/141758871
Change-Id: I8e21cb19b1cecbd996ed78cbe9fbde46beac0adc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36769
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

ANGLE reserves 2 uniforms and 2 varyings for GLES.
Increasing maxPerStageDescriptorUniformBuffers by 2 and
maxVertexOutputComponents by 8 (2 * 4 components) allows
the following tests to pass (17 failures fixed in total):
dEQP-GLES3.functional.implementation_limits.*
dEQP-GLES3.functional.state_query.*

Bug b/141632907

Change-Id: Ie39b735286d6682f5782fca30e0f7a079f4142ec
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36668
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

This extension only actually adds an enum. The interesting behavior will
come with image and buffer memory barriers describing an ownership
transition between the real queue family and
VK_EXT_QUEUE_FAMILY_FOREIGN. Depending on the platform, this may be
nothing; may require cache maintenance operations; or may require
a copy to/from an external buffer.

Bug: b/141697747
Change-Id: Ia5b6d3027f21bb7c61143972fcb4d4cd8bc06f11
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36728Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

True by default, allows forcing non-optimized builds of SwiftShader in
debug builds.

Bug: b/140251624
Change-Id: I51bb93b53ead5936b47894ebabbd73b36c05cae0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36470Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Change-Id: Ie2c008b40b83fa2d04f3008a5fcb9b554513639b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36116Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: I74e4615e07478b8d0f54432762a7e630004c3aa1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36628
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

* changes:
  Update Marl to 12872a0df
  Squashed 'third_party/marl/' changes from 5f31df137..12872a0df

As documented at https://developer.apple.com/documentation/quartzcore/cametallayer/1478168-framebufferonly:
"If the value is true (the default), the CAMetalLayer class allocates
its MTLTexture objects in ways that are optimized for display purposes.
However, you may not sample, read from, or write to those textures. To
support sampling and pixel read/write operations on the layer’s textures
(at a cost to performance), set this value to false."

Since we call replaceRegion in MacOSSurfaceMVK::present() to write pixels
from system memory, we need to set this flag to false explicitly.

Bug: b/137673628
Change-Id: I83e28a2940261d9eedf30d7c96427c23d85ac639
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36608Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

SwiftShader has been confirmed by Khronos as a conformant Vulkan 1.1 product:
https://www.khronos.org/conformance/adopters/conformant-products#submission_400

Bug: b/129792032
Change-Id: I6893a411fbb2b3ba94ec07674bd78ca81b319680
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36589
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

This helps applications identify the driver.

Bug: b/129792032
Test: dEQP-VK.api.driver_properties.properties
Change-Id: I300fcc5dda6886b422fb64902b3eadf070b5eea8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/22690
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

This reverts commit 1f89f58f.

Original cl:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/36548

Reason for revert: Causes timeout flakes on Regres

Bug: b/141380274

Change-Id: I184e96c586e449b7dcd5b445078064cbafb7df72
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36592Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

12872a0df Comments: Improve & make style consistent
5bb61cf6a Scheduler: Ensure all scheduled tasks are finished when the scheduler is destructed.
b5e3e1e00 src\scheduler_test.cpp: Reduce max number of in-flight tasks.
d13286050 src\osfiber_windows.h: Assert that the Win32 fiber calls succeeded.
08da5139c .gitignore - Add Visual Studio generated files.
8007ea5de Temporarily disable DestructWithPendingFibers test.
5390897be Fix alignment of Pool items.
89425dcbc CMakeLists: Bump MSVC warnings to level 4
6df4597c3 Kokoro: Shuffle presubmit file layouts.
e3b3c7df4 Add include/marl/memory.h for aligned memory allocations.
60598ef45 Fix TSAN issue with BlockingCall test.
be3628456 CMakeLists: Add TSAN build flag

Commands:
git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash

Bug: b/141380274
Change-Id: Ic33110f917737d0d84d882f63a4e1c0a87a16c33