- 15 Mar, 2019 13 commits
-
-
Ben Clayton authored
Test: dEQP-VK.subgroups.builtin_var.compute.* Bug: b/126871859 Change-Id: If1585778ca5a85e2b8a66f4ddf6a58050620a112 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27089Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Alexis Hetu authored
Extra useless deallocations weren't cleaned up properly. Removed them. Bug b/123244275 Change-Id: I418a4c09a870748551a92c1abb3986e94b32ba92 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27289Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
Enable sRGB conversion when filtering sRGB images Tests: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.* Bug b/119620767 Change-Id: If56a3f74fbf3ee576d9baab44722a13a1ad0d436 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27288Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
The following changes are done in this cl: - Added multilayer support in Blitter::blit() - Fixed Image::texelOffsetBytesInStorage() for cubes, since there's a 1 pixel border around it, so pixel offset (0,0,0) should be an extra line (1 pixel offset in Y) + 1 pixel (1 pixel offset in X) from the beginning of the buffer - Added a number of out of bounds memory access asserts, which helped debug this issue. Fixed failures in: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.* Note: The only failures left in that category are related to filtering sRGB images, which most likely happens in the wrong colorspace. Tests: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.* Bug b/119620767 Change-Id: I6f18271cb23070eb8f2de3b1d5b35b7021c0ca8b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27229Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
Added the ability to set the VkMemoryDedicatedRequirements structure in vkGetBufferMemoryRequirements2. Note that this cl adds no support for dedicated allocations. Passes all tests in the Tests section below. Change-Id: Ib5bc2775e66e810d1ca2d52672eb2cca71e85f5e Tests: dEQP-VK.api.buffer.dedicated_alloc.* Tests: dEQP-VK.api.buffer_view.create.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27290 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Change-Id: I20e249c56167fc9c37adc02b798cb60781cc757b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27251 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Use this to disable reads and writes on compute shader lanes that are not part of the subgroup. Bug: b/126871859 Bug: b/128527271 Change-Id: Idd7ad240a8f09e6e47db34b6ed5b0ec7ba959d39 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27009 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Ben Clayton authored
This was previously taking the IntLiteral<T> path, resulting in an integer type instead of a bool type. Bug: b/128636885 Change-Id: I1a36a7ba0e7009431dc44645f90454d389be721b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27250 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Also add WARN() and ASSERT_MSG(). Bug: b/127433389 Change-Id: I2549e9a79b3168cfc419d6564f0c111f95246452 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26148Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/128527271 Change-Id: I367ed0d578e36a56baf4b8c4c2256ee4de1297cc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27097 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Yes, I really do find myself using 12 in a single call. Change-Id: Ibbf21d9a400b0f79b2b7385588d6441ea710b3ac Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27091Tested-by:
Ben Clayton <bclayton@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I313c00b299230827cc2bd4c174e840dcd923fae9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27249Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Dan Sinclair authored
Currently when the build executes it copies things like .so files and the vulkan .icd file to the CMAKE_CURRENT_SOURCE_DIR/out/<platform> directory. This is fine in a normal swiftshader build but if you embed swiftshader into another project this ends up being something like: third_party/swiftshader/out/<platform> which is not what is desired. This CL changes the files to get written to the CMAKE_BINARY_DIR. This means it will go into the directory form which cmake was run. This means for a build setup as per the README, build/<platform>. This also allows generating different .icd and .so files for Release and Debug if you setup different build directories. Bug: b/123752208 Change-Id: If2e8c70ca2d35351c02f7bbe56ff77a04d538373 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27188 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 14 Mar, 2019 13 commits
-
-
Ben Clayton authored
First step towards flow control. Bug: b/128527271 Change-Id: I7e031ccc22148e37dc058150edc93d28de54f4c4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27096Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
posix_memalign() returns EINVAL if the alignment argument is not a multiple of sizeof(void*). Use regular malloc() for those cases. malloc() is specified to allocate memory which is "suitably aligned for any built-in type". Bug b/128618202 Change-Id: Ibee07be89f2a5bd6be770c35710b20b0c752dfd1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27228 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
See b/128614198 for context. Tests: dEQP-VK.glsl.operator.binary_operator.div.*ivec* Tests: dEQP-VK.glsl.operator.binary_operator.mod.*ivec* Bug: b/128614198 Change-Id: I3c517a18ce003466b1ba382f1896b356e543f5d5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27248 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Minor bit of refactoring to reduce the number of SpirvShader child typenames. Bug: b/126126820 Change-Id: I0a3ae5f10b34eac2ae648ccf5f4b15c67bca0a13 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27094 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Chris Forbes authored
Bug: b/127962486 Test: dEQP-VK.glsl.operator.binary_operator.mod.* Change-Id: I6aee79c99b50f936512e9d9b4b51a07006445694 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27208Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Change-Id: Icd6c52252988cd9765bf28fe2d91f44867df88c6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27110Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Change-Id: I34eb45ef6c69536353449c980745a00afc65de46 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27010Tested-by:
Ben Clayton <bclayton@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
The Vulkan spec says: "division by zero produces an unspecified result but must not lead to Vulkan interruption or termination". Tests: dEQP-VK.glsl.operator.binary_operator.mod.* Tests: dEQP-VK.glsl.operator.binary_operator.div.* Bug: b/127962486 Change-Id: I62e7c29a6e944512db7a8a96b0bb87488aa7be73 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27171Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Simplifies things throughout the cpp. Bug: b/128539387 Change-Id: I7abbe4731d82877204976d654859cba88d1a3047 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26531Tested-by:
Ben Clayton <headlessclayton@gmail.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Ben Clayton authored
Removes a load of noise throughout the cpp file. Bug: b/128539387 Change-Id: Ic9fa9361c4b7dc6258833e2ce58db50b5e81b11d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26530Tested-by:
Ben Clayton <headlessclayton@gmail.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
SwiftShader Regression Bot authored
Change-Id: Ic0153dc04839fe44093091564dc181d394b32d12 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27099Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Chris Forbes authored
Bug: b/127804400 Test: dEQP-VK.glsl.operator.geometric.* Change-Id: I63d852c2978be4c1966886cf24c489cc7c286964 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27128Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Some functions in LLVMReactor.cpp and SubzeroReactor.cpp were identical and have been moved into a common Reactor.cpp. Bug swiftshader:21 Change-Id: Ib079757f9e35f83b1103e2791227f02775e034d3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27068Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 13 Mar, 2019 10 commits
-
-
Alexis Hetu authored
Removed sw::Rect from Renderer. Bug b/126883332 Change-Id: I01ff418745c19739b4692c7cec56ae54fe91a8fc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27109Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
Framebuffer related code is being implemented properly in VkSurfaceKHR.cpp and related files, so old OpenGL framebuffer code can be removed to avoid confusion. Bug b/124265819 Change-Id: I08a87c17e8b029c6f82d252e1ff1ef810ab200ae Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27108Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
Remove leftover variables not cleaned up in: https://swiftshader-review.googlesource.com/c/SwiftShader/+/7250 Change-Id: Ia2e66c15e5cadeed32f564c60d5105c17319e9d4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27028 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Dan Sinclair authored
When embedding SwitftShader into a third party application, the top level cmake files may already include googletest and SPIRV-Tools. This CL updates the SwiftShader tests to only try to pull in googletest if the `gtest` target is not found and only pull in SPIRV-Tools if the `SPIRV-Tools` target is not found. Change-Id: I3c3ebb528725017dbbb80aa05b01ee2de8d4a2d1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26788Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Dan Sinclair <dsinclair@google.com>
-
Alexis Hetu authored
Removed sw::Surface dependency from: - Blitter - Context - PixelProcessor - PixelRoutine - Renderer - VkFramebuffer No behavior changes should be happen with this cl. Bug b/126883332 Change-Id: I4146f043ba8e5008eb3d44465c26a0f34a2e1acc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26969Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Ben Clayton authored
Change-Id: I1881916302d6652144138106d0744e9bbd2b45c8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27008 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I5d87130b1c52cd7c3e2a21d1a1f0fcbe6d2b40ed Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27049Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Chris Forbes authored
D16_UNORM depth operations are performed in fixed point to avoid quirks of ushort <-> float roundtrip Some slight oddities to work around missing primitives: - We only have CmpEQ, CmpGT. This matches SSE hardware reality. Everything else is made out of negations and operand swaps. - We only have *signed* CmpGT. Make an unsigned CmpGT by biasing both 16-bit operands by -0x8000. - In non-quad-layout we don't have a good way to separate .xy and .zw halfs; reading via masked short4 reads, writing via individual component writes. Bug: b/128363727 Test: dEQP-VK.pipeline.depth.format.* Change-Id: I9c8b249470a9c91589c91135988dc4d1a58bbc5f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27030Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Chris Forbes authored
Bug: b/128363727 Change-Id: Ia595876610b077c4be366174264de7a55f14dc4c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27029Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Chris Forbes authored
Also add implementations of multiplication and right shift for Long type. Bug b/126873455 Change-Id: I9952c2b9a3feca6a7741cd02e2295340935e4447 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/25988Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
- 12 Mar, 2019 4 commits
-
-
Hernan Liatis authored
Bug: b/124265819 Change-Id: I7c84c3be8fb13a4ef798f90b8c610ebeafa82b5c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26970Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Hernan Liatis <hliatis@google.com>
-
Hernan Liatis authored
When we create a new swapchain, we can pass in a parent swapchain from the same surface. The old swapchain is no longer associated with the surface and "retires" by deleting all non-acquired images. Bug: b/124265819 Change-Id: I31315045c926b929483d1b6cb1fc3d9f7aa87b94 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26668Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Hernan Liatis <hliatis@google.com>
-
Chris Forbes authored
Bug: b/128363727 Change-Id: Id75e138deda980f57b7bd07192b1353b2b414fd8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26988Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Hernan Liatis authored
In summary, this change associates a 1:1 correspondance between a VkImage and XImage. This will fix resize issues as well as prepare to implement createInfo->oldSwapchain. Bug: b/124265819 Change-Id: I42e8e1e7b5c9a5b64820156603dca10e2ab828ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26368Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Hernan Liatis <hliatis@google.com>
-