- 20 Nov, 2019 7 commits
-
-
Alexis Hetu authored
3D subregions were not properly supported in Image::copyTo() Bug: b/144353295 Change-Id: I445881b37be310401b38cffcb6003a1e4461bed8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38471 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Alexis Hetu authored
Blitting should be done either using the depth aspect or the stencil aspect, not both at once. Bug: b/144353295 Change-Id: I5b7a81d3c2b915f6ebb5854edc814f335eb2cac5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38470 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
This is considered non-core functionality. Fixes: b/144686205 Change-Id: I41b811d70db9c07d26a3e6cb2f8c36a2a9e34296 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38450Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
-
Ben Clayton authored
Both LLVM and Subzero now support it, so there's no need to expose this as a capability. Yay! Bug: b/142132927 Change-Id: I5cf5eece809f7305d38e8d0f995be45d44a8b1cd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38449Tested-by:
-
Ben Clayton authored
rr::ConstantData() returns a Pointer<Byte> to an immutable copy of the provided data. Added two new variants of rr::Call() for calling member function pointers. Added tests. Bug: b/143479561 Change-Id: I5846fb313fbd81821bf4e9bb655414a5e0eaf133 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38408Tested-by:
-
Ben Clayton authored
This should have been done as part of 51f08312, but it got missed. Bug: b/143479561 Change-Id: I16d802e753989576ade007c031f11bc5ab351d32 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38390Tested-by:
-
Ben Clayton authored
The documentation states: "For T types that have a CToReactorT<> specialization, CToReactorPtrT<T>::type resolves to Pointer< CToReactorT<T> >, otherwise CToReactorPtrT<T>::type resolves to Pointer<Byte>." However, the CToReactorPtrT<T>::cast() function did not behave correctly for some Pointer<Byte> cases. Now fixed. Bug: b/143479561 Change-Id: I64387653e9edf21eb7fa91e3bcb7b76171c7bca4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38389Tested-by:
-
- 19 Nov, 2019 1 commit
-
-
Ben Clayton authored
Some templated traits need more than just the forward declaration in order to be complied: Reactor.hpp uses the CToReactor<> templates, and some of these specializations use the ConstantPointer() function declared in Reactor.hpp. Without splitting this into a declaration and implementation that sandwich Reactor.hpp, you'll get compilation errors, so include Traits.hpp at the start of Reactor.hpp, and Traits.inl at the end. Bug: b/143479561 Change-Id: I15c2165325633cf01c0ae7a285d1798c128499a7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38388Reviewed-by:
-
- 18 Nov, 2019 5 commits
-
-
Chris Forbes authored
We don't actually use this, so it just clutters up search results Bug: b/144696871 Change-Id: Ic8a10bb49cad4f6078dd0c4b548591e3ef828dd9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38288 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
SamplerFunction can then be passed to RR_LOG and RR_WATCH. Bug: b/140287657 Change-Id: If37d99469b7df98b539430abdcd184eec81bc08f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/33471Tested-by:
-
Ben Clayton authored
So that the print value's 'fmt' is a dynamic function instead of a constexpr. Let's us do smarter stuff based on the type and value, and will allow us to move functionality from overloads on rr::PrintValue to PrintValue::Ty template specializations. Also fix a bunch of missing integer expansion casts which were missing from ca8e3d7c. Bug: b/140287657 Change-Id: I7e18c35ae23d8a2dd6b726562ae1348a1b7075dd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32049Reviewed-by:
-
Ben Clayton authored
Add cast() static method to the CToReactor trait specializations. Use this in CallHelper to automatically convert C to Reactor types. This was implicitly handled by (most) reactor types having a contructor that took the C type, but this does not work for more complex conversions, such as 'const char*' -> rr::Pointer<Byte>. This particular conversion is now automatically handled when using Call() to invoke a function with a 'const char*' parameter. This also allows developers to define custom cast functions by specializing rr::CToReactor for their own types. This change also swaps the naming of CToReactor and CToReactorT. CToReactor now has contains 'type' and 'cast', and the 'T' suffix is more in keeping with the C++ traits naming convention for aliasing the ::type. Bug: b/143479561 Change-Id: I81faae365b5cbe0e45055160cc0f5470cd4fb2de Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38028Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: I14b005ac32129aea00b38910c5662a791c7fc4eb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38270 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 15 Nov, 2019 9 commits
-
-
Ben Clayton authored
Bug: b/140546382 Change-Id: I71253f73dcd3c2083873cb1f0084b42190e9df8e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38209Tested-by:
-
Ben Clayton authored
Removes the last use of sw::Event in Vulkan. Bug: b/140546382 Change-Id: I5de63c52e35756dc6d7e4c6cbb77669ea3925d79 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38208Tested-by:
-
Ben Clayton authored
Bug: b/144388391 Change-Id: I5a9c63899fcb1a39c80be25813d1d89ca22b26a8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38138 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
First step to using marl::Event::any() Bug: b/144388391 Change-Id: I5c6cb24c2d7a1cdb2bc2935d180f5074a8b68ab7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38137 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
* changes: Update Marl to 6dd9ff1e Squashed 'third_party/marl/' changes from 49e4e3141..14e4d862a
-
SwiftShader Regression Bot authored
Change-Id: Ibed8fe26750fa08c7448d0d31834149e65d4a9a6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38269Reviewed-by:
-
Ben Clayton authored
Includes new Event methods which can be used for Vulkan fences. Changes: 14e4d862a Scheduler: Fix issues with fiber lists a timeouts. 57f41915d SwiftShader build fixes. 791187298 Add Event::any(). ecd5ab322 Implement yields with timeouts, wait_for() / wait_until() 6ba730d94 Update README.md 8348be4f0 Implement page-based functions for Fuchsia 5e512cd0c Fix condition logic of assert in TasksOnlyScheduledOnWorkerThreads. 37ae48f40 Add marl::Event. a90725760 Update README.md (#49) Commands: git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash Bug: b/140546382 Change-Id: Ifb21caa23fec31e17d9459f52c7cd0bbcc1e499c -
Chris Forbes authored
Includes a test fix for dEQP-VK.api.image_clearing.dedicated_allocation.clear_depth_stencil_attachment.multiple_layers.d32_sfloat_s8_uint_separate_layouts_stencil_200x180 incorrectly assuming VK_KHR_create_renderpass2 is supported. Bug: b/144307043 Change-Id: I2e05901ade4c6c0251cba5db3d426e317df8a91d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38228Tested-by:
-
Ben Clayton authored
14e4d862a Scheduler: Fix issues with fiber lists a timeouts. 57f41915d SwiftShader build fixes. 791187298 Add Event::any(). ecd5ab322 Implement yields with timeouts, wait_for() / wait_until() 6ba730d94 Update README.md 8348be4f0 Implement page-based functions for Fuchsia 5e512cd0c Fix condition logic of assert in TasksOnlyScheduledOnWorkerThreads. 37ae48f40 Add marl::Event. a90725760 Update README.md (#49) git-subtree-dir: third_party/marl git-subtree-split: 14e4d862a959b831fd994a436e7c104c6fd19006
-
- 14 Nov, 2019 4 commits
-
-
Antonio Maiorano authored
Bug: b/143351714 Change-Id: I8adab60da392ebf143260f244024979ecc5c32eb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37609 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: I7776e0732876b1e057895cad325ce54f3404a2f4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38134 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
The previous 'connected diamonds' polygon that was used to rasterize Bresenham lines suffered from duplicate rasterization of endpoints, which violates the diamond exit-rule and is disallowed by the Vulkan (and OpenGL) spec. This change rasterizes Bresenham lines as a parallelogram, as described by Vulkan's non-strictLines algorithm. This satisfied Vulkan's requirements laid out in section 26.10.2 Bresenham Line Segment Rasterization: "Implementations may use other line segment rasterization algorithms, subject to the following rules: - The coordinates of a fragment produced by the algorithm must not deviate by more than one unit in either x or y framebuffer coordinates from a corresponding fragment produced by the diamond- exit rule. - The total number of fragments produced by the algorithm must not differ from that produced by the diamond-exit rule by no more than one. - For an x-major line, two fragments that lie in the same framebuffer- coordinate column must not be produced (for a y-major line, two fragments that lie in the same framebuffer-coordinate row must not be produced). - If two line segments share a common endpoint, and both segments are either x-major (both left-to-right or both right-to-left) or y-mayor (both bottom-to-top or both top-to-bottom), then rasterizing both segments must not produce duplicate fragments. Fragments also must not be omitted so as to interrupt continuity of the connected segments." OpenGL ES line rasterization has not been modified as part of this change, to not require rebasing of golden images, but the parallelogram algorithm was made available for easy comparison. Bug: b/80135519 Change-Id: I09e8b90a393d3a08387d79669d9dbe5f83a0811d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38049 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Alexis Hetu authored
baseVertex is a signed integer that's allowed have a negative value. In order to support it, the offset was moved from being applied on the index buffer memory pointer directly to being applied to the indices from the index buffer inside the Vertex routine. Fixes all issues in the following subcategory using SwANGLE: dEQP-GLES31.functional.draw_indirect.* Bug: b/144353667 Change-Id: Ia70c258eab25c274553c4955dc2336a42d43f005 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38148 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
- 13 Nov, 2019 3 commits
-
-
Chris Forbes authored
Bug: b/144426261 Change-Id: Ic515f274bf1c02afbbe3f536c1c8cd654b0cc56e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38168 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: Ic8dc7322bf89c086eef9d6ad5425966cbaa28de8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38131 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
David 'Digit' Turner authored
This extension allows one to import/export device memory buffers through shared memory region file descriptors. This also adds checks to ensure that binding a buffer or image to an external device memory works only if VkCreate{Buffer,Image} was called with a VkExternalMemory{Buffer,Image}CreateInfo struct with compatible handle types. Test: dEQP-VK.api.external.memory.opaque_fd* Bug: b/140419396 Change-Id: I5d249685896ae0764bc9d5c635cc3799323db453 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35152 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:David Turner <digit@google.com>
-
- 12 Nov, 2019 6 commits
-
-
Ben Clayton authored
Use go 1.13's new error functionality to create nested errors, and use the new errors.As() to unwrap them. Fixes bad classification of tests that have recently started returning non-zero exit codes. Change-Id: I4f356696d2a7ce1576be1c350fc14e156f63c659 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38130Reviewed-by:
-
Tobin Ehlis authored
Update the maxPerStageDescriptorStorageBuffers from 4 to 16. ANGLE requires at least 12 for GLES3.1 support, and 16 is a common number among actual hardware so bumping to 16. Bug: swiftshader:136 Change-Id: I2790a8cab197c773aa14d9c1b0fdcc5ca8356b25 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38068 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Tobin Ehlis <tobine@google.com>
-
Nicolas Capens authored
This reverts commit 5d0faf9b. Reason for revert: Marl issue was fixed; https://github.com/google/marl/issues/38 Bug: b/140575360 Change-Id: I04ca4ced82cbe0e16179cc940adc027c9a17c29f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38048Reviewed-by:
-
Ben Clayton authored
It seems that once a change is no longer in the top N most recent changes, the server will start responding `server does not allow request for unadvertised object` when attempting to fetch the specific change by SHA. To work around this, we need to fetch the branch by name, then checkout the specific change locally. As the Khronos seems to be particularly slow to respond today, I've limited the branch depth to 99, for now. This hopefully will not be a problem as we should typically only be updating to newer changes. Also bumped the git command timeout to 15 mintutes as this repo can be _really_ slow. Change-Id: Ie08165a6ca92e79d56bb4d2d5376410f2850a471 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38129Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I9c4f1e6716ff12d05de18479703b004370b93bbd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38128 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Alexis Hetu authored
For 565 and 5551 formats, the blend equations were getting applied on top of colors represented by the top 5 or 6 MSB only, leading to precision errors. Fixed this by: - removing the scaling applied on the source color before blending is applied and the related inverse transform in the writeColor function - adding the proper remapping of the color to the full color range in the readPixel function That way, we're always working with full 16 bit range colors and the blend equations work properly. Fixes all tests in: dEQP-GLES3.functional.fragment_ops.interaction.basic_shader.* Bug: angleproject:4016 b/24332884 Change-Id: I53531b88a8629aaa61929e99efaac38cdb46c834 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38088Tested-by:
-
- 11 Nov, 2019 5 commits
-
-
Tim Van Patten authored
This change allows for outputting the SwiftShader version to Android's logcat. The version information is as follows: major.minor.patch.commit_hash In logcat, when SwiftShader is loaded by ANGLE, this looks like: 11-07 12:17:10.152 9110 9110 I SwiftShader: SwiftShader Version: 5.0.0.9c7bf8093a75 11-07 12:17:10.162 9110 9110 I ANGLE : Version (2.1.0.a2b1a958e2d8), Renderer (Vulkan 1.1.0(SwiftShader Device (0x0000C0DE))) This allows developers to verify that they are running the expecting build of SwiftShader when debugging problems or running conformance tests. The version information is logged to logcat when the build flag "ENABLE_BUILD_VERSION_OUTPUT" is enabled within src/Android.bp. Bug: b/142828252 Change-Id: Iff773b16a2f3532aa843629ec50519b519bbadac Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37990 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
Chris Forbes authored
Test: dEQP-VK.renderpass.suballocation.unused_clear_attachments.*depth* Bug: b/144280552 Change-Id: I37072270105caf206ed3ab6cb2895d32ef22f653 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38108Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I9923ef71a77ee27fa8cb276e3aa924ca23ce08fd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37968Reviewed-by:
-
Chris Forbes authored
The module may legitimately contain descriptor set references (intended for another entrypoint) which are not compatible with our limits. There is a matching assert to verify the set index at the point the descriptor is actually referenced. Bug: b/140648941 Change-Id: Ie3b8c6a2e53e553d1dccb2995e6719539eab89de Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36114Tested-by:
-
Alexis Hetu authored
Moved some functionality from libVulkan.cpp to VkImage.cpp in order to be able to remove the global androidSwapchainMap which may have been causing sync issues. I tried to make as much code as possible compile on desktop so that we have a better chance of detecting if a desktop related change breaks Android specific code. Bug: b/143902189 Change-Id: Ie9e17a77c2a1705b3194ebd67adeb1a3c0e6213f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37828 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
-
