1. 20 Feb, 2019 1 commit
  2. 19 Feb, 2019 5 commits
  3. 15 Feb, 2019 23 commits
  4. 14 Feb, 2019 1 commit
  5. 13 Feb, 2019 1 commit
  6. 12 Feb, 2019 2 commits
  7. 11 Feb, 2019 6 commits
  8. 08 Feb, 2019 1 commit
    • Early exit in es2::Context::drawElements on count=0. · 96861534
      Cody Schuffelen authored
      This fixes an issue where es2::Context::drawElements would still try to
      read draw data even when there are 0 elements to draw, causing a buffer
      overflow on draw data.
      
      This was found by running Android ES3 dEQP under ASAN. The failing tests
      are EQP-GLES3.functional.primitive_restart.[begin_restart,
      begin_restart_duplicate_restarts, begin_restart_end_restart,
      begin_restart_end_restart_duplicate_restarts,
      end_restart_duplicate_restarts, duplicate_restarts].*
      
      The crashing dEQP tests cover glDrawElementsInstanced,
      glDrawRangeElements, and glDrawElements. These all converge onto
      es2::Context::drawElements.
      
      Bug: b/123716871
      Change-Id: I4bca0616eb9f92bf18a3331459f3dcd06b8ac9a9
      Signed-off-by: 's avatarCody Schuffelen <schuffelen@google.com>
      Test: cts-tradefed run commandAndExit cts -m CtsDeqpTestCases --module-arg 'CtsDeqpTestCases:include-filter:dEQP-GLES3.functional.primitive_restart.*'
      Reviewed-on: https://swiftshader-review.googlesource.com/c/24548
      Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
      Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>