- 31 May, 2019 2 commits
-
-
Alexis Hetu authored
BuiltInPointCoord is defined as: "The following formulas are used to evaluate s and t: s = 1/2 + (xp - xf) / size t = 1/2 + (yp - yf) / size where size is the point’s size; (xp,yp) is the location at which the point sprite coordinates are evaluated - this may be the framebuffer coordinates of the fragment center, or the location of a sample; and (xf,yf) is the exact, unrounded framebuffer coordinate of the vertex for the point." So it was implemented by writing (xf,yf) in SetupRoutine, where this information is present and using the fragment's x and y coordinates as (xp,yp), which passes the test. Tests: dEQP-VK.glsl.builtin_var.simple.pointcoord Change-Id: I9146349bcce0f7c31dd0464c0f210a7306d5d033 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31992 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
This cl fixes all issues related to building Vulkan using the x86 compiler in Visual Studio: - Added dummy function to prevent compiler crash in VkGetProcAddress.cpp - Added missing WIN32 check in SwiftShader's Vulkan unit tests - Removed alignment code which broke Win32 DLL. Removing all of it should work on all other platforms as well. Minor nit fix: - Renamed VkWrapper to VkNonDispatchableHandle, which is a more accurate name. Bug b/129979580 Change-Id: Ib2bf305433e9aae71ff6f9d796fb86bc7ea733b0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31609Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 30 May, 2019 2 commits
-
-
Alexis Hetu authored
This warning was hit almost 2000 times and was causing a lot of noise in the output. Change-Id: I53f80de3eeebc9f70d780d3d7bc1e374582ffb10 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32289Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
The assumption that Cast(VkDescriptorSetLayout) is nothing but a noop cast no longer hold on 32 bit, since the handle and the pointer don't have the same size. Used the Cast() function to solve the issue. Bug chromium:968313 Change-Id: I0349d1f4f00ca983bbc4ca9c39be77d3a0b3d5bc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32229Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 29 May, 2019 11 commits
-
-
Chris Forbes authored
Change-Id: I95825844509af7a30600fe48752b3f5cef10d017 Bug: b/129979580 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32208 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Chris Forbes authored
- VK_EXPORT was not defined, causing all kinds of trouble - Android WSI code was based on an earlier version which didnt require aspect mask to be passed to some functions - More missing files for ARM target Change-Id: Ia5f88c5692d48f2d7898c86c26347bed6e4b4f22 Repro: external/swiftshader$ mma Bug: b/129979580 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32188 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Chris Forbes authored
Change-Id: Ie80381527e9c8672d1a6e57aea78582ccee33021 Repro: external/swiftshader$ mma Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32109Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Hernan Liatis authored
Have Vk synchronization objects fire in vkAcquireImageANDROID as per described in https://source.android.com/devices/graphics/implement-vulkan Tests: dEQP-VK.wsi.android.swapchain.modify.resize Bug: b/133520634 Change-Id: I9b045df3b5ed0fff8efde9c0207e4a1da9c94b8f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31968Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Hernan Liatis <hliatis@google.com>
-
Hernan Liatis authored
When swapchain images were being destroyed on Android, the backing memory was not being destroyed, causing a crash. Tests: dEQP-VK.wsi.android.swapchain.create.min_image_count Bug: 133346002 Change-Id: Ib2383a6c41ac2917f6e6630eca96e5c180996507 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31870Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Hernan Liatis <hliatis@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Sean Risser authored
For OpenGL on Mac, Swiftshader renders directly to the IOSurface given to us by the OS. This surface is not necessarily vertically padded so its height is a multiple of 2. Since we render 4 pixels at a time in a quad, the bottom 2 pixels may not be written to legal memory if the height of the target surface is an odd number. This change prevents Swiftshader from rendering quads on Mac if doing so would overflow the buffer. Bug: chromium:944796 Bug: angleproject:2764 Change-Id: I08bec895980b42f99b8a4434969edcaf7d331284 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32030 Presubmit-Ready: Sean Risser <srisser@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Sean Risser <srisser@google.com>
-
Nicolas Capens authored
SpirvShader::InterfaceComponent is used as part of the state that comprises the lookup key for cached Reactor routines. It uses 1-bit bitfields for Boolean values, and the bits following it for padding may be left uninitialized by the compiler. Computing the hash of all the state is done by XORing together the memory, so it shouldn't have any- thing uninitialized. While we memset all of SetupProcessor::State to 0, the InterfaceComponent state copied in still contained the uninitialized bits. Computing a hash from it was detected by MemorySanitizer. Bug chromium:967824 Change-Id: If1676831fc838bf2a6ca869d13e6f6d2052fa6d8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32128 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Sean Risser <srisser@google.com>
-
Saman Sami authored
swiftshader_reactor_base doesn't need to depend on swiftshader_opengl_common. This causes failures when building for Vulkan. Instead make swiftshader_libGLESv2_static depend on it directly. Bug: chromium:967704 Change-Id: I4c62c975c72ad42ee0a5cd59e58bd840ad8ab71e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32068Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Saman Sami <samans@chromium.org>
-
Saman Sami authored
The alignment of VkWrapper is currently set to match the alignment of uint64_t which isn't always correct. On some platforms (e.g. Linux x86) the alignment of uint64_t inside and outside of a struct differ (8 vs 4). Using an alignment of 8 will cause swiftshader to miscalculate the size of structs containing VkWrappers and the offset of different fields into the struct. This is why the alignment of VkWrapper should match that of uint64_t inside a struct, not outside of it. Bug: chromium:967831 Change-Id: Ibf8240d13406413481cf87e9d45df4478c35be2f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32108 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Saman Sami <samans@chromium.org>
-
Sean Risser authored
supports_llvm needs to include is_mac. Bug chromium:966543 Change-Id: Ieedf1bba3948de8c75d8bd07473fa2cb0a1e4299 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32032Reviewed-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Sean Risser <srisser@google.com> Tested-by:
Sean Risser <srisser@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I4fb809cd80b0eef249df24de45f4e1c92912e0c1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32052 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 28 May, 2019 23 commits
-
-
Ben Clayton authored
The printf specifiers expect an int, passing a smaller width integer could lead to weirdness being printed. Change-Id: I1e75e3fdade270a4bfa55c48efe82ca9f331b2fe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31272 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Ben Clayton authored
Yet another horrible phi/loop edge case (pun intended). Added test. Bug: b/133440380 Bug: b/133481698 Change-Id: I327842fa2d4314bce938454da81f67f890cf9e12 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31845 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
The 'existsPath' condition is not required, and worse still breaks some future fixes. Bug: b/133440380 Bug: b/133481698 Change-Id: I9c5d20bf7782443b0e0e3eb0aacebae251687164 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32048 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
TSAN claims there are data races in the compileLayer. Specifically, it takes objection to compileLayer.addModule() being called at the same time as compileLayer.removeModule(). Bug: b/133127573 Change-Id: I19196d0c952bc308c2e47a848c93b092d5eea1ea Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31832 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Odd that these don't exist already. Change-Id: I018dc4eb5144cb4c359c790aadabc35516bdd745 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31430Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
DebugInfo::NotifyObjectEmitted and NotifyFreeingObject have become statics as the free-object callback happens after the DebugInfo instance is destroyed. This isn't an issue as the JITEventListener is a singleton in LLVM. Bug: b/133399620 Change-Id: I93fa73d0e416ba3c09c6550cc0d3abd56354e862 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31837Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Chris Forbes authored
!IsStorageInterleavedByLane is not quite the same as IsExplicitLayout-- workgroup memory is the exception. Bug: b/133509497 Change-Id: I4dd055109c0e0f70fa415a75ee383e251cbd509c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31929Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
This missing op causes horrible template errors when attempting to use UInt4 swizzles. Change-Id: I02f9381c1d4da45b1fc32e53ad9c7fd248e21673 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31273 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Nicolas Capens authored
The Vulkan 1.1 spec on vkCreateImage states that "Creation of images with tiling VK_IMAGE_TILING_LINEAR may not be supported unless other parameters meet all of the constraints: * imageType is VK_IMAGE_TYPE_2D * format is not a depth/stencil format * mipLevels is 1 * arrayLayers is 1 * samples is VK_SAMPLE_COUNT_1_BIT * usage only includes VK_IMAGE_USAGE_TRANSFER_SRC_BIT and/or VK_IMAGE_USAGE_TRANSFER_DST_BIT" Also restrict YCbCr image creation in accordance with: "Creation of images with a format requiring Y’CBCR conversion may not be supported unless other parameters meet all of the constraints: * imageType is VK_IMAGE_TYPE_2D * mipLevels is 1 * arrayLayers is 1 * samples is VK_SAMPLE_COUNT_1_BIT" Bug: b/119620767 Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I909fda2a154e69fbd4afb862cf4cc14c244005bf Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31788Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
As specified in https://www.khronos.org/registry/DataFormat/specs/1.2/dataformat.1.2.html Bug: b/132437008 Change-Id: I730a9eb74796c625d3e635a66b18661c73f7c01f Tests: dEQP-VK.*ycbcr* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31618 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Nicolas Capens authored
Image views can select a single plane from a multi-planar format, so make sure we use the original plane aspect instead of assuming the color aspect. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I81c4c8b05e894c5f48d5718e912d5f6ee747a7e5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31617 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Nicolas Capens authored
This will make it easier to write YCbCr plane data as mipmap levels. Also removes the unused fWidth, fHeight, and fDepth from sw::Mipmap, and ensured the other members are aligned to their vector size. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: Ib2b0cbebf9e4fd640fcc104281097ff3c4c73b5d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31616 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Nicolas Capens authored
Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: Ic09d04c63f38247d0f0d6acbd6969f62aa4405ce Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31615 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Implement the vk::SamplerYcbcrConversion object and pass it to the vk::Sampler and vk::ImageView constructors if present as an VK_STRUCTURE_TYPE_SAMPLER_YCBCR_CONVERSION_INFO extension struct value. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I16b03dc37920dd1eee7de80a370f8f7386dc4cea Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31614 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Implementation will follow. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I5fd4826257c6886e109d007ac926ee61895bf62d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31613 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
This is particularly useful for passing extension info structures to the object's constructor. Bug: b/132437008 Bug: b/116336664 Change-Id: I10592f5ddeb8efa52f34ebd4dfd14150b6964eab Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31612 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I91443301702b495ab62eab0cd32f533c8d7a1505 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31621 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Aspect info is part of the format, so shouldn't be queried from an Image utility function. Bug: b/132437008 Change-Id: I87d632231a810cece3d1ea579e9df63b6b80a714 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31611 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Bug: b/129523279 Tests: dEQP-VK.glsl.texture_gather.* Change-Id: Ie87e600bd787fa832beaf834289f64ef3b590bd8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31869 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Bug: b/129523279 Change-Id: I8ce66d601107e28b335d469f86bc1db7a018c8b6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31950 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Our lookup key for generated sampling functions was only using the sampler and image view descriptors into account. The same descriptors can be used in various different sampling instructions, so we need to also make that part of the lookup key. Bug: b/129523279 Change-Id: I325aa5571191e4ffc69214c2d13d431d21316fed Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31949 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Z was only being interpolated when the Position builtin is used (which isn't valid for fragment shaders) and/or when there's a depth buffer present. Instead interpolate it when FragCoord is being used. Bug: b/133325267 Tests: dEQP-VK.draw.inverted_depth_ranges.* Change-Id: I0567084b6f7bb054bd864545fa34acc52c8ac3d6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31848 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
SwiftShader Regression Bot authored
Change-Id: Ia954596bcd7e6c206240fbf6cef7dd30731c3a99 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31847 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 27 May, 2019 2 commits
-
-
Alexis Hetu authored
Texture dimensions larger than SHRT_MAX (32767) were not supported by SwiftShader. Used integers instead of shorts to store texture sizes to increase the maximum texture size to INT_MAX (2147483647). Tests: dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.* Tests: dEQP-VK.memory.pipeline_barrier.transfer_dst_uniform_texel_buffer.* Bug b/133429305 Change-Id: I7913f5f4c1f933889e74c57851a837ad7982f87a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31989Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
vk::destroy was crashing for vk::Fence after: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31988 Reverted that change and fixed it in VkObject.cpp to make sure the result of the cast is always equal to the allocated memory. Bug: b/117835459 Change-Id: I831625418fc83503329e833d48d9765b75d83b80 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31990Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-