- 12 Sep, 2019 3 commits
-
-
Nicolas Capens authored
All sampler operands are passed through an array of float values. Offset operands are integers, but we were retrieving them from the SPIR-V constant object interpreted as floating-point data, and then creating Float constants from them. This may alter their bit pattern, specifically values corresponding to sNaN may become qNaN. Instead create Reactor integer constants and bitcast them to Float. Bug: b/140302841 Change-Id: I06aceb7b2a97d5f5ce9009f5ba97238602cdc126 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35910 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Nicolas Capens authored
Reactor Float scalar and vector constants may not fully preserve the bit pattern of the values they were constructed from. Specifically, signaling NaN values (sNaN) may become quiet NaN values (qNaN). Thus they should not be used for storing SPIR-V constant objects to memory. Interpret the data as integer instead. Note Object::constantValue is already a uint32_t array. Bug: b/140302841 Change-Id: Ifd51eec9d2b7adab8fef5de74e2e30d080a28fd5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35909 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Nicolas Capens authored
Despite the name, PARAMETER_FLOAT4LITERAL is used for integer and Boolean constants in the ASM representation of GLSL compiled shaders. Reactor can turn sNaN values into qNan when constructing Float constants, and thus integers bitcast from a float which were initialized from a reinterpreted integer may not preserve its original bit pattern. Instead construct the Float register values from Reactor Ints which are bitcast to Float. Bug: b/140302841 Change-Id: I4d915851c430dee4a752e06be0011c10d89fb79d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35888 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 11 Sep, 2019 4 commits
-
-
Nicolas Capens authored
Active development on dEQP has moved to the public Khronos repository. The version in AOSP is behind. Bug: b/137875321 Change-Id: I0bafba8f0325dc0e27af6c3ebc748fd6d7342350 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34969 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Nicolas Capens authored
Function pointers returned through eglGetProcAddress should have a GL_APIENTRY calling convention to avoid mismatches with their declarations. Bug: b/140700303 Change-Id: I706ca788e54a897a66cfdf5ba959ec6e3dc718ee Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36228 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
This is now the default in marl. Bug: b/140546382 Change-Id: Ic28537760b38c9ee051c8e527791495a57117466 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36190Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Contains: 59068ee4c examples/fractal.cpp: Don't use rand() 7df53dd16 Add primes example ded37ceb8 Update README.md with build instructions b80c797df CMakeLists.txt: Don't default to building tests. d89fe34b6 CMakeLists.txt: Use explicit file lists 757566df0 Update README.md 8c98371e5 Presubmits: Enable warnings-as-errors. 0025389a1 CMakeLists: Add option to treat warnings as errors eeb070293 Fix all compiler warnings Commands: git subtree pull --prefix third_party/marl https://github.com/google/marl 59068ee4cf1f5ff5e691ff010c8d83b5f862c4fa --squash Bug: b/140546382 Change-Id: Ie37d6e1ce315aaeabeee5e006c5e1f6a7a5ca184
-
- 09 Sep, 2019 2 commits
-
-
Ben Clayton authored
59068ee4c examples/fractal.cpp: Don't use rand() 7df53dd16 Add primes example ded37ceb8 Update README.md with build instructions b80c797df CMakeLists.txt: Don't default to building tests. d89fe34b6 CMakeLists.txt: Use explicit file lists 757566df0 Update README.md 8c98371e5 Presubmits: Enable warnings-as-errors. 0025389a1 CMakeLists: Add option to treat warnings as errors eeb070293 Fix all compiler warnings git-subtree-dir: third_party/marl git-subtree-split: 59068ee4cf1f5ff5e691ff010c8d83b5f862c4fa
-
Jamie Madill authored
ANGLE uses this extension instead of the Xlib extension. Bug: angleproject:3876 Bug: b/140251624 Change-Id: I4bc420ddc340b8c35eca20d894718c8c3db68a3a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36148Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Jamie Madill <jmadill@chromium.org>
-
- 07 Sep, 2019 9 commits
-
-
Chris Forbes authored
In a few places we were always looking at component 0, which obviously doesn't go well. Bug: b/140648938 Test: dEQP-VK.*ldexp* Change-Id: I6a8698a56beab8ccc3b41a729d399b957cde9495 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36113Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Marl has its own repo and tests now, and so it is excessive to build and run these tests for downstream projects as well. Bug: b/140546382 Change-Id: Ic79db961a3bfae072a56ffeb7052165c127538d3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36112Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/140546382 Change-Id: I106cde639419fb49d5d161555f1baa687bb12e91 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36111Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
This reverts commit 1359b66e. Reason for revert: still breaking chrome autorollers. Change-Id: I35d389f542beb3cfe31b1fa3143dfad4ab7e4a7a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36110Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/140546382 Change-Id: I7e25e913a1867ebbdee84b0575ddf67acb0b7cc6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36109Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
This reverts commit df6cc08a. Reason for revert: Utterly breaks chrome autorollers Change-Id: I5bc05c538f30d689a078f47766c480be543d2a37 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36108Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/140546382 Change-Id: Ic104d5c3de500975316a96613b2101f37e11f11a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36031Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Fixes squiggles on marl includes. Bug: b/140546382 Change-Id: If08700e453cade53d65926fc79eae09e6b19f05a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36069Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Will be upstreamed. Bug: b/140546382 Change-Id: Ifbbc14d5c5cd1cb6940642a1e6cc690c224e9bfe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36068Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 06 Sep, 2019 3 commits
-
-
Ben Clayton authored
Having submodules inside subtrees breaks submodule update. Bug: b/140546382 Change-Id: I0e3e9591bfd1aa8813d1e8764f702d87c5ac5e84 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36030 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
* changes: Initial drop of Marl @ d3b8558c Squashed 'third_party/marl/' content from commit d3b8558ce
-
SwiftShader Regression Bot authored
Change-Id: Iac5636d2b9c947bfc14216be70ad8fe46a9a29c5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36088 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 05 Sep, 2019 6 commits
-
-
Jamie Madill authored
../../third_party/SwiftShader/src\Yarn/Pool.hpp(254): note: see reference to function template instantiation 'std::shared_ptr<yarn::BoundedPool<sw::DrawCall::BatchData,16,yarn::PoolPolicy::Preserve>::Storage> std::make_shared<yarn::BoundedPool<sw::DrawCall::BatchData,16,yarn::PoolPolicy::Preserve>::Storage,>(void)' being compiled C:\dev\depot_tools\win_toolchain\vs_files\418b3076791776573a815eb298c8aa590307af63\win_sdk\bin\..\..\VC\Tools\MSVC\14.16.27023\include\memory(1866): warning C4316: 'std::_Ref_count_obj<_Ty>': object allocated on the heap may not be aligned 16 with [ _Ty=yarn::BoundedPool<sw::DrawCall::BatchData,16,yarn::PoolPolicy::Preserve>::Storage ] ../../third_party/SwiftShader/src/Vulkan/VkQueue.cpp(122): warning C4316: 'sw::Renderer': object allocated on the heap may not be aligned 16 Bug: angleproject:3876 Bug: b/140251624 Bug: b/140575360 Change-Id: I3016b8ba4e6557c9b7f1c27a387f03ff307e17de Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36048Reviewed-by:Alexis Hétu <sugoi@google.com> Tested-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This fixes the GN header check with Yarn. Enables further ANGLE integration. Also fixes a number of MSVC build errors and changes the output name of the Vulkan ICD on Windows to "vk_swiftshader" so that it matches the .def file used in CMake. Bug: angleproject:3876 Bug: b/140251624 Change-Id: Ie23ba965a2ee7f8b678499db22d6614f0a6666fa Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36009Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Jamie Madill <jmadill@chromium.org>
-
Ben Clayton authored
Commands: git subtree add --prefix third_party/marl https://github.com/google/marl d3b8558ce8d2cf2cad1009a99aa3ff453b048639 --squash To update: git subtree pull --prefix third_party/SPIRV-Tools https://github.com/KhronosGroup/SPIRV-Tools <sha> --squash Bug: b/140546382 Change-Id: If3471eb3897b128613c874a9260e0ac390d27cf1
-
Ben Clayton authored
git-subtree-dir: third_party/marl git-subtree-split: d3b8558ce8d2cf2cad1009a99aa3ff453b048639
-
SwiftShader Regression Bot authored
Change-Id: I9deb5a9975674b8664eb11f6de312548087010df Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36008Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-
Chris Forbes authored
Vulkan CTS 1.1.5 is stricter about edge cases here, and sinhf/coshf aren't cutting it. Test: dEQP-VK.*cosh* Test: dEQP-VK.*sinh* Bug: b/140501860 Change-Id: I21895cbff9f54bccb7d40fb75e09eebe7db18fa1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35988Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
- 04 Sep, 2019 2 commits
-
-
David 'Digit' Turner authored
When building the vulkan library (libvk_swiftshader.so) for Fuchsia, do not place the stripped binary to $OUT_DIR/swiftshader/ instead of its default location (i.e. $OUT_DIR/lib/). That's because the Fuchsia packaging scripts rely on the location of the unstripped library ($OUT+DIR/lib.unstripped/) to find the release one (i.e. by replacing 'lib.unstripped' with 'lib'). This resulted in a build error (see bug for details). This CL works around the issue rather than fixing the scripts. Bug chromium:1000668 Change-Id: I4137c9edbdc04b3b35a8a43e3f37b9e64fe5b1d7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35968Tested-by:
David Turner <digit@google.com> Kokoro-Presubmit: David Turner <digit@google.com> Presubmit-Ready: David Turner <digit@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
SwiftShader Regression Bot authored
Change-Id: Icbf160f40c433b8d90f73862f9980da6cb55655a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35948Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-
- 03 Sep, 2019 6 commits
-
-
David 'Digit' Turner authored
Change-Id: I8f9324f40343d84c57bca76a33d1ce98311b8bf4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35931 Kokoro-Presubmit: David Turner <digit@google.com> Tested-by:
David Turner <digit@google.com> Presubmit-Ready: David Turner <digit@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
David 'Digit' Turner authored
pthread_setname_np() is not provided by the Fuchsia C library so do not try to call it in Thread::setName(). Change-Id: I7db37e6da52d665ff6535d735e9a2da5d9845143 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35930 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
David Turner <digit@google.com> Presubmit-Ready: David Turner <digit@google.com>
-
Ben Clayton authored
A solution to blocking, non-yielding function calls. Bug: b/139010488 Change-Id: I8f2a9458980f83fbecafb22a5531aa6e3dbbc040 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35573 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Chris Forbes authored
This finishes our KHR_swapchain v70 implementation. Test: dEQP-VK.wsi.* Change-Id: I512e0c086db687ca7ffb8cd5e5375fa7a9d432cd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35929Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Chris Forbes authored
Previous versions of dEQP never called this function. Test: dEQP-VK.wsi.*.swapchain.render.* Test: dEQP-VK.api.version_check.entry_points Change-Id: I3d64403984ff60fea9ef2921f7f53f0ca4b94240 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35928Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
SwiftShader Regression Bot authored
Change-Id: Ie970829b56e46ffd1a6cc6028148ecd46d0f098d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35908 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 02 Sep, 2019 2 commits
-
-
Alexis Hetu authored
A few changes were made to make this work: - activeLaneMask now contains cMask. Since it's only used in loads, stores and atomics, it should be fine to include it - Added a storesAndAtomicsMask, which also contains sMask (stencil) and zMask (depth) for early fragment tests. The mask affects all atomic operations and store operations into storage buffer and images. - support for spv::BuiltInHelperInvocation was added Bug b/140294254 Test: dEQP-VK.* Change-Id: I42b97a766ddfe331bb2767d80d4360104a221482 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34114 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Jamie Madill authored
This fixes a few missing dependencies for the Chromium uses of SwiftShader. It will allow us to turn on the 'gn check' in Chromium. Bug: angleproject:3876 Bug: b/140251624 Change-Id: I875a59701a4437cf94b503f6430d858a5285a961 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35811Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Jamie Madill <jmadill@chromium.org>
-
- 31 Aug, 2019 3 commits
-
-
Chris Forbes authored
Bug: b/139687059 Change-Id: Ie0084a5f320f2ac36d55ff0950812a77401f4741 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35848Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Chris Forbes authored
Tested with ANGLE running dEQP-GLES2.*rbo_rgb5_a1* Bug: b/139411772 Change-Id: I5681b008ae7bfb2df2705189f28667dac8d4c983 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35812Reviewed-by:
Nicolas Capens <nicolas.capens@gmail.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
SwiftShader Regression Bot authored
Change-Id: Id38fc9787e37108d723edcac73711dc801c46403 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35889 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-