Commits · d50aacb19b7b2d65635d910f0c27ee5693f2621e · Chen Yisong / swiftshader

07 Apr, 2020 3 commits

authored Apr 07, 2020

Includes new Thread Safety Analysis helpers

Changes:
    539094011 CMake: Export MARL_THREAD_SAFETY_ANALYSIS_SUPPORTED
    c7f70ba7a CMake: Bump min version + include(CheckCXXSourceCompiles)
    658a204fc Replace SAL annotations with clang's TSA annotations
    9630bec2f Fix CMake warning: "Policy CMP0023 is not set"
    9f369ad5d Update yarn:: to marl:: in an example

Commands:
    ./third_party/update-marl.sh --squash

Bug: b/140546382
Change-Id: Idb4253c11cece99ea4b22f965b974b63e26b51a7

d50aacb1

Squashed 'third_party/marl/' changes from 16e1dc37c..539094011 · 8787897e

authored Apr 07, 2020

539094011 CMake: Export MARL_THREAD_SAFETY_ANALYSIS_SUPPORTED
c7f70ba7a CMake: Bump min version + include(CheckCXXSourceCompiles)
658a204fc Replace SAL annotations with clang's TSA annotations
9630bec2f Fix CMake warning: "Policy CMP0023 is not set"
9f369ad5d Update yarn:: to marl:: in an example

git-subtree-dir: third_party/marl
git-subtree-split: 53909401165022553ed9d1f0c572178559dc25ec

8787897e

Coverage: Improve uncovered visualizations · b4a27407

authored Apr 06, 2020

List all files, including those that have no coverage.
Emit spans that were compiled, but not covered.
Emit a % coverage per file.

Bug: b/152192800
Fixes: b/153182184
Change-Id: I31c831273a8d3ee89c7ce0737b6e05398ff4f51b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43491
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

b4a27407

06 Apr, 2020 4 commits

Don't blend integer formats · bdb68078

authored Apr 06, 2020

True integer formats should not use blend modes.
This cl explicitly disables any blend operation
on render targets using integer formats.

Bug: b/153203552
Change-Id: Ia756953c61caef8e32e55aa31126044973ae1870
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43548
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

bdb68078

Clamp GLES sine/cosine to [-1,1] · 3942f5cb

authored Apr 03, 2020

Hack for minor precision issues with current implementation. Fixes
8 quality warnings from deqp-gles3 when run against
SwiftShaderGL/Subzero.

Bug: b/151461290
Change-Id: I4a3148add2c0987dcccca96e7c877ea4fb16ca89
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43470
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

3942f5cb

Delete Plane.cpp and Plane.hpp · acc90dc1

authored Apr 03, 2020

Cleaning up unused code

Bug: b/153177839
Change-Id: I42479778f0f6ec9a955ba7f863766429b68c73a3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43468
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

acc90dc1

CMake / Kokoro: Build and run system-unittests. · f0445bf7

authored Apr 04, 2020

These were added for the .gn build, but were never enabled for the CMake build.

Test these as part of the Kokoro presubmits.

Bug: b/153193374
Change-Id: I36e7428bfe1a4867bea39b2fbb302aed6c3dff7b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43488
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

f0445bf7

04 Apr, 2020 1 commit

Vulkan: Destruct the list of vk::Query in QueryPool · b8d47928

authored Apr 04, 2020

Bug: b/153168751
Bug: b/153206490
Change-Id: I2822f60aa380ae3885bc674d9f7b1f283c087e95
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43490
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

b8d47928

03 Apr, 2020 14 commits

Really fix Android build · ad6d1b30

authored Apr 03, 2020

Bug: none
Change-Id: I9f58cc3bf6b457fc8b916a98242138865f89c577
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43469Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

ad6d1b30

Fix Chromium and Android build · e06125cb

authored Apr 03, 2020

I broke this when I removed the relative path to the third_party astc
include file in this change:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/43269

Bug: none
Change-Id: I45de8a6159c69c893df4449f6c6e10b09a9e6fe4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43448Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

e06125cb

Debug: Add missing include. · 030aae05

authored Apr 03, 2020

When `ENABLE_VK_DEBUGGER` is defined, VkDevice needs to be declared in order to build.

Bug: b/148401179
Change-Id: If35f3a1425ec0d739750d632305a625c7e12b721
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43432Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

030aae05

Vulkan/Debug: Create a PhysicalFile if DebugSource has no content · 534d015d

authored Apr 03, 2020

`VirtualFile`s are typically used for files with no physical backing.
Use `PhysicalFile` if there's no content provided in the debug info.

Bug: b/148401179
Change-Id: I1e1ed75ce9a9fb0965420267aba7f6d8de958012
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43430Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

534d015d

Vulkan/Debug: Always provide the dap::Source::path · 13f0ff7d

authored Apr 03, 2020

This is common for virtual and physical files.

Bug: b/148401179
Change-Id: I266097382098c1daf776ae64d878f08febee5d0e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43429Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

13f0ff7d

CMake: Don't always regenerate OpenCLDebugInfo100.h · b470e41b

authored Apr 03, 2020

https://github.com/KhronosGroup/SPIRV-Headers/issues/137 is still ongoing.

Fixes: b/15093697
Change-Id: I2498f35a8049fb2a1a86aa0efe6fbd6e59ad6493
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43428Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

b470e41b

CMake: use gtest and gmock targets · 8f02f586

authored Mar 31, 2020

Bug: b/145758253
Bug: b/152606052
Change-Id: I826225ed393ed324301555ebaea14947997632cf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43289Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

8f02f586

CMake: split out atsc-encoder into its own CMakeLists · b02a708c

authored Mar 30, 2020

Also remove dependency of third_party/astc-encoder on
src/System/Debug.hpp.

Bug: b/145758253
Change-Id: I329928d9221c99a416fcdb1b0dd44d2578a22cb8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43269Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

b02a708c

CMake: clean up cppdap usage · 6636f143

authored Mar 30, 2020

Remove unused and useless variables. Also fix the build when
SWIFTSHADER_ENABLE_VULKAN_DEBUGGER is enabled.

Bug: b/145758253
Change-Id: Ie49dd88d6716b24fe31baa8f8d162e7dacfa5a3c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43268Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

6636f143

CMake: split out Reactor into its own CMakeLists · fa8f48d8

authored Mar 30, 2020

Bug: b/145758253
Change-Id: I36f1bbf599389c27e084fea9af3d732225567076
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43230Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

fa8f48d8

CMake: split out boost into its own CMakeLists · 7b2721b4

authored Mar 30, 2020

This adds a third_party/boost folder with a CMakeLists.txt. If this
folder is added via add_subdirectory, it downloads boost to the
binary directory and exposes the Boost::boost target.

Bug: b/145758253
Change-Id: I7d4e383630cb84da928cf0622a641e9e0efc2ad8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43191Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

7b2721b4

CMake: split out libbacktrace into its own CMakeLists · 6102276a

authored Mar 30, 2020

This change also fixes compilation on Linux when REACTOR_EMIT_DEBUG_INFO
is enabled, which has been broken since "-fno-exceptions" was added to
SWIFTSHADER_COMPILE_OPTIONS. Also, at some point,
LIBBACKTRACE_CONFIG_DIR stopped being used, which further broke
compiling libbacktrace.

Bug: b/145758253
Change-Id: I50f0e2c2c1dabc357dfc255a471eaf1e9fed1c2e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43189Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

6102276a

CMake: split out subzero and llvm-subzero into their own CMakeLists · 4bde1c3d

authored Mar 27, 2020

Bug: b/145758253
Change-Id: Ife32c322cf87c9b1b98b4b50f591b75db6ea51e2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43148Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

4bde1c3d

Kokoro: Add the ppa:ubuntu-toolchain-r/test apt-repository · 2ce5fda2

authored Apr 03, 2020

Bug: None - Fix Kokoro presubmits.
Change-Id: I16074e733edd257647840d1bf51ebdc14dd4fb89
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43431Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

2ce5fda2

02 Apr, 2020 7 commits

Remove the D3D9 and D3D8 source code · f99302c4

authored Mar 30, 2020

This code has no remaining known active uses. It has been archived in
the 'legacy-d3d9' branch.

Bug: b/139189696
Change-Id: I64bf27ff6c02be560963d7eab36c9c328bb280c5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43232Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

f99302c4

Remove the custom Visual Studio solution and projects · 498499b4

authored Mar 30, 2020

CMake should be used instead.

Note that the CMake build does not support the D3D9 and D3D8 targets.
They can still be built with Visual Studio 2019 from the 'legacy-d3d9'
branch.

Bug: b/139189696
Change-Id: I7b5006fa98e479d6d1a3bb75d379a5818a560c20
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43231
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

498499b4

Fix GN build · c05b6101

authored Apr 02, 2020

cf. https://swiftshader-review.googlesource.com/c/SwiftShader/+/43388

Bug: build fix
Change-Id: I8d2acc0bbb19fa71748aafeebd6c0d500673ed93
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43408Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

c05b6101

Reactor: Fix remove_if brokenness · 983761cc

authored Apr 01, 2020

Spotted by Chris Forbes:
* `std::remove_if` wasn't introduced in C++20, it's been there since 98. I just can't read docs.
* Also fix the lack of `list.erase()`.

Bug: None. drive-by-code-reviewing-fixes.
Change-Id: I456d540ba973640747d6e4cb23faec65a4a9c83d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43348
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

983761cc

Remove the sw::Color<> class · 68d9ad83

authored Apr 02, 2020

It was only still being used to store framebuffer blend constants.
Use sw::float4 instead.

Bug: b/146224130
Change-Id: Ie5660e237f4b675564d5a492f9d0a38505d07953
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43388Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

68d9ad83

Change for loops to use const refs, per performance-for-range-copy clang-tidy. · 9aff7ae7

authored Apr 02, 2020

This CL optimizes C++11 range-based for loops where the variable is copied in each iteration but it would suffice to obtain it by const reference. This is only applied to loop variables of types that are expensive to copy which means they are not trivially copyable or have a non-trivial copy constructor or destructor.

To ensure that it is safe to replace the copy with a const reference the following heuristic is employed:
The loop variable is const qualified.
The loop variable is not const, but only const methods or operators are invoked on it, or it is used as const reference or value argument in constructors or function calls.

See cl/304001946 for more information.

Bug: None.
Change-Id: Idbb5a0dbf19c6dccb16a0d525900aa99419a8527
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43368
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

9aff7ae7

Fix ImageView size computation · 0774188d

authored Apr 01, 2020

Erroneous ImageView size computation was causing out of bounds
memory accesses whenever an ImageView only represents a subsection
of an Image. The getSizeInBytes() function now only returns the
size in bytes within the Image object from the beginning to the
end of the bytes used by the ImageView.

Bug: b/150464740
Change-Id: I0985af9cdfbb85b10336a7691f76009496bb2ae5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43329
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

0774188d

01 Apr, 2020 7 commits

MetalSurface: set layer.device to a ref of the system default device. · cb586623

authored Mar 27, 2020

If layer.device is null, [layer nextDrawable] returns nil, so on surface
initialization we set layer.device to a dummy MTLDevice by getting a
reference of the system default device.

MTLCreateSystemDefaultDevice() requires linking against
Metal.framework but Chromium needs to ship on platforms that don't have
Metal. This means we can't directly link against the framework, instead
we "weakly" link against it so that if it is not present, the function
pointers are just null (instead of failing to launch).

Bug: dawn:269
Change-Id: I5984613f576849c6f219c253da7eb277fa75ef52
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43209
Kokoro-Presubmit: Corentin Wallez <cwallez@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Corentin Wallez <cwallez@google.com>

cb586623

Regres: Add invertCommon optimization. · c66dad95

authored Mar 31, 2020

invertCommon looks for tree nodes with the majority of the child nodes with the same spans.
This span is promoted up to the parent, and the children have the
span inverted.

This causes the span IDs to flip (inclusive / exlusive) each time they're seen while decending the tree. This adds a bit of complexity to the parsing of the data, but the file size reduction is significant.

Bug: b/152192800
Change-Id: I5ec294d42004d936004c27ef15bf94a7143372ba
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43311
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

c66dad95

Regres: Move optimization logic to separate file · 9c258303

authored Mar 31, 2020

There's more to come.

Bug: b/152192800
Change-Id: Icc0928fa0051269f9ca14e9177a9a8ef56d05a34
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43310
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

9c258303

Regres: Keep coverage span groups stable. · 524c5c7b

authored Mar 31, 2020

Update tests.

Bug: b/152192800
Change-Id: I4e57f0d2b049f0bce7459b29f7ffc3a2ca03534a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43309
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

524c5c7b

Regres: Split coverage.go into multiple files · f5da9d9c

authored Mar 31, 2020

This was getting unruly.

Bug: b/152192800
Change-Id: I41a393e0548367ea4d69c3982b89a6ffe198e9f7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43308
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

f5da9d9c

Regres: Further optimizations for coverage · dc5854e1

authored Mar 30, 2020

Compress common spans into groups and index these.
Reduces the full coverage json from ~500MB to just under 100MB.

Use zlib compression on the final file instead of a zip. The compression algorithm is the same, and produces roughly the same sized output, but a raw zlib file is much quicker to decompress with pako instead of jszip.

Bug: b/152192800
Change-Id: Id444ddf4027b6ace03570719f159ae14e481cd37
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43249
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

dc5854e1

Regres: Add cov.ReadJSON() · c6e7b2a4

authored Mar 30, 2020

And add test to check it behaves as expected.

While currently nothing golang actually parses these files, this allows me to experiment with compression schemes on the full data set without needing to rebuild the coverage data from scratch each time.

Bug: b/152192800
Change-Id: I8070abe2bbebaef3e5889991060f1d1342078eb2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43248
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

c6e7b2a4

30 Mar, 2020 4 commits

Fix implicit narrowing cast · 5cf1e9a3

authored Mar 30, 2020

Bug: b/152777669
Change-Id: I271ca0ecb5ff8461530fd6388378524970a2bc2b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43228
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

5cf1e9a3

Eliminate the legacy PowerVR SDK · 45755df2

authored Mar 30, 2020

We now have an up-to-date third_party/PowerVR_Examples submodule for
these sample applications.

Bug: b/141361933
Change-Id: I216b94d0c3263bf85a6b0a7fca52a2e5b7beefa2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43190
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

45755df2

Integrate PowerVR OpenGL ES samples · 3702e01d

authored Mar 30, 2020

Also add some additional Vulkan samples to the 'good' set.

Bug: b/141361933
Change-Id: I32fe2d691ca2fd176a8c470fdb34b25a55840cd6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42389
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

3702e01d

Fix completeness test of OpenGL ES immutable textures · d51c7fa6

authored Mar 30, 2020

Immutable textures created with glTexStorage*() are always mipmap and
sampler complete. The spec states that

"Array levels k where k < levelbase or k > q arebinsignificant to the
definition ofcompleteness."

Where q is no larger than levelmax, which is in turn limited to
levelimmut - 1 which was specified at glTexStorage.

Change-Id: Ieaa6be856fd35cf2827e753d7c777ebf784027ef
Tests: dEQP-GLES*
Fixes: b/152740217
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43188
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

d51c7fa6