- 28 May, 2019 22 commits
-
-
Ben Clayton authored
Yet another horrible phi/loop edge case (pun intended). Added test. Bug: b/133440380 Bug: b/133481698 Change-Id: I327842fa2d4314bce938454da81f67f890cf9e12 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31845 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
The 'existsPath' condition is not required, and worse still breaks some future fixes. Bug: b/133440380 Bug: b/133481698 Change-Id: I9c5d20bf7782443b0e0e3eb0aacebae251687164 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32048 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
TSAN claims there are data races in the compileLayer. Specifically, it takes objection to compileLayer.addModule() being called at the same time as compileLayer.removeModule(). Bug: b/133127573 Change-Id: I19196d0c952bc308c2e47a848c93b092d5eea1ea Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31832 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
Ben Clayton authored
Odd that these don't exist already. Change-Id: I018dc4eb5144cb4c359c790aadabc35516bdd745 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31430Tested-by:
-
Ben Clayton authored
DebugInfo::NotifyObjectEmitted and NotifyFreeingObject have become statics as the free-object callback happens after the DebugInfo instance is destroyed. This isn't an issue as the JITEventListener is a singleton in LLVM. Bug: b/133399620 Change-Id: I93fa73d0e416ba3c09c6550cc0d3abd56354e862 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31837Tested-by:
-
Chris Forbes authored
!IsStorageInterleavedByLane is not quite the same as IsExplicitLayout-- workgroup memory is the exception. Bug: b/133509497 Change-Id: I4dd055109c0e0f70fa415a75ee383e251cbd509c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31929Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
This missing op causes horrible template errors when attempting to use UInt4 swizzles. Change-Id: I02f9381c1d4da45b1fc32e53ad9c7fd248e21673 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31273 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
The Vulkan 1.1 spec on vkCreateImage states that "Creation of images with tiling VK_IMAGE_TILING_LINEAR may not be supported unless other parameters meet all of the constraints: * imageType is VK_IMAGE_TYPE_2D * format is not a depth/stencil format * mipLevels is 1 * arrayLayers is 1 * samples is VK_SAMPLE_COUNT_1_BIT * usage only includes VK_IMAGE_USAGE_TRANSFER_SRC_BIT and/or VK_IMAGE_USAGE_TRANSFER_DST_BIT" Also restrict YCbCr image creation in accordance with: "Creation of images with a format requiring Y’CBCR conversion may not be supported unless other parameters meet all of the constraints: * imageType is VK_IMAGE_TYPE_2D * mipLevels is 1 * arrayLayers is 1 * samples is VK_SAMPLE_COUNT_1_BIT" Bug: b/119620767 Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I909fda2a154e69fbd4afb862cf4cc14c244005bf Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31788Tested-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
As specified in https://www.khronos.org/registry/DataFormat/specs/1.2/dataformat.1.2.html Bug: b/132437008 Change-Id: I730a9eb74796c625d3e635a66b18661c73f7c01f Tests: dEQP-VK.*ycbcr* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31618 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Image views can select a single plane from a multi-planar format, so make sure we use the original plane aspect instead of assuming the color aspect. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I81c4c8b05e894c5f48d5718e912d5f6ee747a7e5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31617 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
This will make it easier to write YCbCr plane data as mipmap levels. Also removes the unused fWidth, fHeight, and fDepth from sw::Mipmap, and ensured the other members are aligned to their vector size. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: Ib2b0cbebf9e4fd640fcc104281097ff3c4c73b5d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31616 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: Ic09d04c63f38247d0f0d6acbd6969f62aa4405ce Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31615 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Implement the vk::SamplerYcbcrConversion object and pass it to the vk::Sampler and vk::ImageView constructors if present as an VK_STRUCTURE_TYPE_SAMPLER_YCBCR_CONVERSION_INFO extension struct value. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I16b03dc37920dd1eee7de80a370f8f7386dc4cea Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31614 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Implementation will follow. Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I5fd4826257c6886e109d007ac926ee61895bf62d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31613 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
This is particularly useful for passing extension info structures to the object's constructor. Bug: b/132437008 Bug: b/116336664 Change-Id: I10592f5ddeb8efa52f34ebd4dfd14150b6964eab Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31612 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Bug: b/132437008 Tests: dEQP-VK.*ycbcr* Change-Id: I91443301702b495ab62eab0cd32f533c8d7a1505 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31621 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Aspect info is part of the format, so shouldn't be queried from an Image utility function. Bug: b/132437008 Change-Id: I87d632231a810cece3d1ea579e9df63b6b80a714 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31611 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Bug: b/129523279 Tests: dEQP-VK.glsl.texture_gather.* Change-Id: Ie87e600bd787fa832beaf834289f64ef3b590bd8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31869 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Bug: b/129523279 Change-Id: I8ce66d601107e28b335d469f86bc1db7a018c8b6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31950 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Our lookup key for generated sampling functions was only using the sampler and image view descriptors into account. The same descriptors can be used in various different sampling instructions, so we need to also make that part of the lookup key. Bug: b/129523279 Change-Id: I325aa5571191e4ffc69214c2d13d431d21316fed Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31949 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
-
Nicolas Capens authored
Z was only being interpolated when the Position builtin is used (which isn't valid for fragment shaders) and/or when there's a depth buffer present. Instead interpolate it when FragCoord is being used. Bug: b/133325267 Tests: dEQP-VK.draw.inverted_depth_ranges.* Change-Id: I0567084b6f7bb054bd864545fa34acc52c8ac3d6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31848 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: Ia954596bcd7e6c206240fbf6cef7dd30731c3a99 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31847 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 27 May, 2019 3 commits
-
-
Alexis Hetu authored
Texture dimensions larger than SHRT_MAX (32767) were not supported by SwiftShader. Used integers instead of shorts to store texture sizes to increase the maximum texture size to INT_MAX (2147483647). Tests: dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.* Tests: dEQP-VK.memory.pipeline_barrier.transfer_dst_uniform_texel_buffer.* Bug b/133429305 Change-Id: I7913f5f4c1f933889e74c57851a837ad7982f87a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31989Reviewed-by:
-
Alexis Hetu authored
vk::destroy was crashing for vk::Fence after: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31988 Reverted that change and fixed it in VkObject.cpp to make sure the result of the cast is always equal to the allocated memory. Bug: b/117835459 Change-Id: I831625418fc83503329e833d48d9765b75d83b80 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31990Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
-
Antonio Maiorano authored
Fence has a second base class with virtual functions, but its first base does not. In "static VkResult Create(...), when assigning the handle via: *outObject = *object; since this is code run in the context of the first base class, the address returned is offset by sizeof the vtable pointer from the second base class (8 bytes on x64). Problem is that the Cast overload for Fence does a simple reinterpret_cast of this stored pointer back to Fence*, without the offset being taken into account. The fix is to simply first cast the stored pointer back to the first base class type, and then static_cast it to the derived Fence type. Bug: b/117835459 Change-Id: Ieb2856320e996a5ad5d9e69aad5e01cfaee1cd9e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31988Reviewed-by:
-
- 24 May, 2019 7 commits
-
-
Ben Clayton authored
As requested here: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31841/1#message-24da63454b89e5d545f3b686f2470c8d2392ee61 Change-Id: I76500807933b565fb13f30268c47c7caa4be7c69 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31843Tested-by:
-
Ben Clayton authored
We were assuming the condition was the same width as the lhs and rhs types - it can also be a scalar even if the result is not. Bug: b/133440380 Change-Id: Ib0e971af426b71030a097838295b07bb6e4261e0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31841Reviewed-by:
-
Sean Risser authored
The BUILD.gn files used to ignore the platform entirely. All that was necessary was to point them at the proper include directory for Mac. Bug chromium:966543 Change-Id: I755a432cc7d01ce094d7191fd48d0702d8a1ae3e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31889 Presubmit-Ready: Sean Risser <srisser@google.com> Reviewed-by:
Sean Risser <srisser@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I8017db3f860c111143835e8ccb73c712489ede0c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31842 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
"Buffer updates performed with vkCmdUpdateBuffer first copy the data into command buffer memory when the command is recorded (which requires additional storage and may incur an additional allocation), and then copy the data from the command buffer into dstBuffer when the command is executed on a device." Bug: b/133127573 Bug: b/118619338 Bug: b/118383648 Change-Id: I8ba9bcdd6bf9e5b4f7e181c6fc379595a1d32e2a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31839 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
Chris Forbes authored
I had made a bad assumption earlier that these would choose the correct operation based on signedness. That's not the case -- LLVM has separate Max/UMax and Min/UMin RMW operations. Test: dEQP-VK.glsl.atomic_operations.* Change-Id: I92a9e56011c4ef8ac658a826c480b16f65d0704d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31909 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
Test: dEQP-VK.glsl.440.linkage.varying.component.vert_in.ivec2.as_int_int_unused Change-Id: I6e8da5863cfcee722dd4cf202810ddc505f76a65 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31890Tested-by:
-
- 23 May, 2019 8 commits
-
-
Ben Clayton authored
Tests: dEQP-VK.draw.basic_draw.* Change-Id: I609e22601c4aae1bdebaca6d42d33754cfaa57bb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31840 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
Ben Clayton authored
Fixes a whole lot of leak-detector warnings. Bug: b/133399620 Change-Id: I4f35150712dd2035a84c16d06ca75a4eba2c3c69 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31836Tested-by:
-
Ben Clayton authored
SpirvRoutine holds reactor fields which must not outlive the scope of the reactor mutex. While the routine was not directly referenced outside of ComputeProgram::generate(), the destructor of the SpirvRoutine's rr::Variables was touching reactor, leading to data races. Bug: b/133127573 Change-Id: I854e079efdc0ef2d5b1ae67f014fe7148ad8f892 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31838 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
Ben Clayton authored
We were only passing them to the compiler. These should go to the linker as well. Bug: b/133127573 Change-Id: Ifc02a2c17a164f30c80311fd17d2a6311e3d5cba Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31817Reviewed-by:
-
Ben Clayton authored
Hide all the error-prone synchronization logic in the class, and expose a documented API. This should have no impact on behavior - it was authored to make it harder to break things in the future. That said, it appears to fix a whole bunch of flakes with the dEQP query tests. Bug: b/133127573 Change-Id: I5c30b79b9b1cd36dba1fa2d3c34af0f5bd62772a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31816 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Saman Sami authored
Change-Id: I767fe366bb3484b2f21db61c9fd964172c5b0537 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31908Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
-
Alexis Hetu authored
Resolve must occur in linear space. Bug b/119620965 Change-Id: I5c7c7c45a1448f44c702969e34e580dc299df70a Test: dEQP-VK.renderpass.suballocation.multisample_resolve.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31871Tested-by:
-
Ben Clayton authored
Bug: b/133127573 Change-Id: I0915cd5f90b75d2bb97152a6b1083755ad14c8b3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31815Reviewed-by:
-
