Commits · e5e33cdca192b8d9f0351df1727f919ebf4d93cb · Chen Yisong / swiftshader

15 Apr, 2019 3 commits

vkCmdResolveImage implementation · e5e33cdc

authored Apr 11, 2019

Implemented the resolve command using the regular blit function,
since it already supports resolve operations. Removed baseArrayLayer
related checks in Image::copyTo(), since resolving array images
exercises that path.

Bug b/118619338

Change-Id: I6a70ef5f396e51be7fde34ebe72fcf991396a45f
Tests: dEQP-VK.api.copy_and_blit.core.resolve_image.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28888
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

e5e33cdc

Kokoro: Build VS solutions produced from CMake · 64b761a8

authored Apr 13, 2019

This now builds both the LLVM and Subzero Reactor backends.
Fixed issue where failures were not actually failing the build in continuous.bat.
Changed the test's expected path of vk_swiftshader.dll to more closely match macOS and Linux.

Bug: b/130458775
Bug: b/123360006
Change-Id: Id2cfc0a7016c9813597567fd6ab900fe4047b8f8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29109
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

64b761a8

Build: Silence LLVM warnings for Windows. · edd7d415

authored Apr 14, 2019

Makes reading Windows Kokoro build logs possible on bad WiFi.

Bug: b/123933266
Bug: b/115344057
Change-Id: I4f336f8bd149e99f9926853fc09b79f7a063ea4b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29148Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

edd7d415

13 Apr, 2019 13 commits

Revert "SprivShader: Replace hand-rolled bitreverse with LLVM intrinsic" · db4f3dfd

authored Apr 13, 2019

This reverts commit a786c4a2.

Reason for revert: Breaks LLVM 3 reactor backend.

Change-Id: Ia7353182bbeab8f357bd9e4dababcc24e6cdd811
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29128Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

db4f3dfd

Revert "SprivShader: Replace hand-rolled bitcount with LLVM intrinsic" · e339d6c0

authored Apr 13, 2019

This reverts commit 0179e5eb.

Reason for revert: Breaks LLVM 3 reactor backend.

Change-Id: I0cdeac496c25b8b8994339e0b4b5a002d2e597f5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29129Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

e339d6c0

SprivShader: Replace hand-rolled bitcount with LLVM intrinsic · 0179e5eb

authored Apr 10, 2019

Moved the hand-rolled implementation to Subzero.
As we've started exposing bit intrinsics, we might as fix the TODOs.

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.integer.bitcount.*
Change-Id: Ic37dfd5d73187f2b3afa444abfd9e22439c871b1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28792
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

0179e5eb

SprivShader: Replace hand-rolled bitreverse with LLVM intrinsic · a786c4a2

authored Apr 10, 2019

Moved the hand-rolled implementation to Subzero.
As we've started exposing bit intrinsics, we might as fix the TODOs.

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.integer.bitfieldreverse.*
Change-Id: Ifadf25045b9ee4b435d9f6750c63334b7d4cad83
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28791
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

a786c4a2

Dynamic state implementation · 73832434

authored Apr 11, 2019

Implemented all dynamic state commands and applied
the proper state within the draw command.

Bug b/118619338

Change-Id: Ifeca42be1698f642e137e807aa59958447921fcc
Tests: dEQP-VK.dynamic_state.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28890Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

73832434

Kokoro: Enable macos CI tests · 17ecf2a6

authored Apr 12, 2019

Change-Id: I83a615291e32e3d08e63a84a71ee1de7641c5bef
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29068
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

17ecf2a6

Build: Silence all Clang + SubZero warnings. · 3fa3bcb7

authored Apr 13, 2019

Most of these come from LLVM 3.
I'd normally try hard to silence these warnings without modifying 3rd party code, but I indend to delete this dependency in the very near future.

Bug: b/130343040
Change-Id: Icf6003c58ad118989240d64cf480aa1e2e639fb7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29088
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

3fa3bcb7

Regres: Update test lists @ · a0c2bc4c

authored Apr 13, 2019

Change-Id: I751f9ffdf788c16bc7dc33bffc15df519c705b2f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28929Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

a0c2bc4c

Kokoro: Remove now unused files · 362e4944

authored Apr 12, 2019

Bug: b/130343040
Change-Id: I413e35e8df6d3609399b33f6696661754e205d24
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29032
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

362e4944

Kokoro: Disable Vulkan tests for Subzero. · acf12f1c

authored Apr 12, 2019

These currently do not work.

Bug: b/130343040
Change-Id: Ia97b611f44a5a048f324daa236e84e933a2c6b67
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29033
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

acf12f1c

Kokoro: Add stub (noop) test files for macOS. · 3efcca9d

authored Apr 12, 2019

Will be fleshed out in another set of changes.

Bug: b/130343040
Change-Id: I3df91cbeb60aba555020e21ffdf6feaa12865389
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29031
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

3efcca9d

Subzero: Fix warning ‘Ty’ may be used uninitialized · 7d9a748e

authored Apr 12, 2019

Bug: b/130343040
Change-Id: I4e69330929ddc81f840c01fe9ceb8a06d5869f53
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29049
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

7d9a748e

Build: Suppress multi-line comment warning (in Subzero). · b24990c7

authored Apr 12, 2019

Promote this up from the LLVM specific build settings.

Bug: b/130343040
Change-Id: I0d916b2635c79d3f292abf659973c570be05fdd8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29029
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

b24990c7

12 Apr, 2019 8 commits

SpirvShader: Implement GLSLstd450MatrixInverse · 445a44a9

authored Apr 10, 2019

Bug: b/126873455
Tests: dEQP-VK.glsl.matrix.inverse.*
Change-Id: Ie4cbe7a193ac18e383cc2c783df1eca21d0dcbf1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28808
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

445a44a9

Implement basic SPIR-V texture sampling · 7d867277

authored Apr 08, 2019

Replaces VkDescriptorImageInfo with a more concrete
SampledImageDescriptor, which contains an sw::Texture that SamplerCore
uses.

The parameters can be looked up statically only because the
shaderSampledImageArrayDynamicIndexing feature is currently not
supported.

Bug b/129523279

Test: dEQP-VK.texture.filtering.2d.formats.r8g8b8a8_unorm.nearest
Change-Id: I619b5b48b2b4552d9bfc70b087df2c31eabb49ea
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28434
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

7d867277

Adjust matrix addressing to account for RowMajor/ColMajor · 98e6b968

authored Apr 12, 2019

Bug: b/128690261
Test: dEQP-VK.glsl.*
Test: dEQP-VK.ubo.*
Test: dEQP-VK.ssbo.*
Change-Id: Ibafc5f64263cd627a3a2cd961af226cb5b110ea0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28968Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

98e6b968

Capture RowMajor/ColMajor decorations · 1ba5ba74

authored Apr 12, 2019

Bug: b/128690261
Change-Id: I847ac2d1727066076c0eae56cfdd94bf31c1f400
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28949Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

1ba5ba74

Fix handling of loads/stores of explicitly-laid-out objects · e6419ad3

authored Apr 11, 2019

[Note: New change-id as I'm experimenting with moving this on top of
Nicolas' decoration tweaks]

Bug: b/128690261
Test: dEQP-VK.glsl.*
Test: dEQP-VK.ubo.*
Test: dEQP-VK.ssbo.*
Change-Id: I535c07964cd74dd4fd9c92c179aa34c53b3ff907
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28910Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

e6419ad3

Pass descriptor sets to SPIR-V compilation · 09591b87

authored Apr 08, 2019

The at draw time currently bound descriptors are passed down to the
SPIR-V code generation so that we can read the sampler parameters and
image view parameters.

An important exception is compute shaders, which are currently
compiled before the invoke calls.

Also still TODO is taking the parameters into account during routine
lookup in the cache.

This change also eliminates the now unused 'enableMask' from
PixelProgram and VertexProgram.

Bug b/129523279

Change-Id: I1ea75ec5a7b83783a1efacb238143a419afa5bda
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28446Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

09591b87

Propagate descriptor decorations to access-chain and load results · 82eb22e2

authored Apr 10, 2019

Split descriptor decorations from other decorations since they're always
used separately and this makes propagating them more lightweight.

Bug b/129523279

Change-Id: I2f5acecc990bf15c7feb4ce81539bd2b5818bdf6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28445
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolas.capens@gmail.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

82eb22e2

Regres: Update test lists @ · 1f7039a6

authored Apr 12, 2019

Change-Id: Icf1d6ad270eeeb71ce2601f01dca0248043459cf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28928Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

1f7039a6

11 Apr, 2019 16 commits

Kokoro: Split the windows and linux configs · 13f23077

authored Apr 11, 2019

This is done so that we can build for both the subzero and llvm backends.

Old configs remain where they are during a transition period.

Bug: b/130343040
Change-Id: Icc9e1b92074ef90aacfd9e6d40b021d35f4d9ef3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28908Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

13f23077

Build: Default to treating warnings as errors · 4e8044d9

authored Apr 11, 2019

Bug: b/130335507
Change-Id: I4cd5ab717bab39f1b03a4c6e8140603aa36c2fff
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28869Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

4e8044d9

SpirvShader: Fix unhelpful warning about parentheses on GCC · f41ca6b5

authored Apr 10, 2019

Bug: b/123933266
Change-Id: Ia7b59b1c6edbc2180ed7ff39ecce4bfdca20804a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28828Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

f41ca6b5

Build fixes for LLVM 3 backend · c38fc12e

authored Apr 11, 2019

Ctlz and Cttz are stubbed for now. Will fix after the builds turn green.

Bug: b/130343040
Tests: dEQP-VK.glsl.builtin.precision.*
Tests: dEQP-VK.glsl.builtin.function.integer.findMSB.*
Change-Id: Ibff6a52bee7f5440c536dfc7a61ad4ba3e96743d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28868Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

c38fc12e

Fix implicit string cast to boolean warning (treated as error) · da617059

authored Apr 11, 2019

Change-Id: I94a2fd3a900fb1e2c625eaa76dcce8fa785360cd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28850
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

da617059

Fixed all warnings in the Vulkan build on Windows · 5078d48f

authored Apr 10, 2019

There were a bunch of warnings on Windows:
- Precision loss through type conversion
- Switch statement containing only default case
- Zero sized array

Bug b/130335507

Change-Id: I809db29db16f5dfd62d03d40353f4f2e0f6c3c93
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28768Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

5078d48f

External image/buffer/fence/semaphore properties · 00835736

authored Apr 10, 2019

Added functions to return properties for external objects.
All properties are currently disabled.

Bug b/117974925

Change-Id: I3322ab7125bddef41f50b0160c22687a1182ae16
Tests: dEQP-VK.api.external.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28770Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

00835736

Regres: Update test lists @ · 4548b66b

authored Apr 11, 2019

Change-Id: Ib23900cfd0c7d7013301dbee559be5a42256ccf5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28829Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

4548b66b

Enable multiprocess compilation for all Visual Studio projects · 3f0d3eff

authored Apr 06, 2019

Should speed up the build a little.

Also removes Minimal Rebuild. It has been deprecated:
https://docs.microsoft.com/en-us/cpp/build/reference/gm-enable-minimal-rebuild?view=vs-2019

Bug b/129772660

Change-Id: I44622edc2fc88ca6b2b6bcb6a515d1e3326d3dbd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28769
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

3f0d3eff

Fix Subzero backend builds. · 147c4916

authored Apr 11, 2019

Stub all functions unimplemented by the subzero backend.

Change-Id: I9dd3a1f7dd633934f4ee76d6807a89a4b117232a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28849
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

147c4916

Fix windows build. · 5d64ec4c

authored Apr 10, 2019

Remove duplicate definitions of Extract and Insert for UInt4

Change-Id: Ib2d54606ead6b953b93f28e9f0dfd7987b1da774
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28848
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

5d64ec4c

SpirvShader: Document ops requiring capabilities · 3954a0ba

authored Apr 10, 2019

... that will not be required for Pastel 1.0.

Bug: b/126873455
Change-Id: I024296dd39ae74613577bd5dbd8d75051b7f4f5c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28790Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

3954a0ba

SpirvShader: Implement GLSLstd450FindILsb · 3f007c4d

authored Apr 10, 2019

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.integer.findlsb.*
Change-Id: I46671fe6b64814a5c9cbc8dd9fe4cc449a328f42
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28789Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

3f007c4d

SpirvShader: Implement GLSLstd450Find[U,S]Msb · 6095826b

authored Apr 10, 2019

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.function.integer.findMSB.*
Change-Id: I6337998f725334c31d8adeae05fc441bb3895908
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28788Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

6095826b

SpirvShader: Implement GLSLstd450Determinant · 1fb633c3

authored Apr 09, 2019

Bug: b/126873455
Tests: dEQP-VK.glsl.matrix.determinant.*
Change-Id: I81ae56951b9fa2e1aedb327039160cf44f7f0a18
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28728Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

1fb633c3

SpirvShader: Implement GLSLstd450NClamp · 4d63312f

authored Apr 09, 2019

Beware: the dEQP tests here are very weak - they do not seem to properly test the NaN handling of this instruction.

Bug: b/126873455
Tests: dEQP-VK.spirv_assembly.instruction.compute.opnclamp.all
Change-Id: I8d1f80f5536996ca46c30ee4895d9f6e2c29a03e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28711Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

4d63312f