Change-Id: Ie75927a91a168ea0ec06ee9c97e6a248a5309c19
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29933Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Bug: b/119620767
Test: dEQP-VK.pipeline.image_view.view_type.1d.format.r8g8b8a8_unorm.subresource_range.lod_base_mip_level_remaining_levels
Change-Id: I977598ee0513928e6a6ce6ba5d0b698653c74fdc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29968
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

Change-Id: Ib4974a5f0dea325e198905cb94bae138ccac4c6e
Test: dEQP-VK.texture.swizzle.component_mapping.*
Bug: b/129523279
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29950Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

- Collect input attachment formats from the current subpass
- Include InputAttachmentIndex in descriptor decorations
- Make window-space integer coords available to fragment shader
- Rework EmitImageLoad to use VkFormat rather than spirv format
- Use window-space-coord-relative addressing for GetTexelPointer
  on spv::DimSubpassData images
- Use input attachment format rather than OpTypeImage baked-in
  format for spv::DimSubpassData images.

Bug: b/131171141
Test: dEQP-VK.renderpass*.input.*
Change-Id: I15412e66516ea907d4b2ffd913a9eb1a3f8a9bb9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29689Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

This was claiming depth, integer, etc were all filterable which is
nonsense. Rearrange to just two blocks: filterable, and not.

Bug: b/117974925
Change-Id: I5228454a3f1ac05e9d46e19af4dc98418885fa90
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29850Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Test: dEQP-VK.texture.swizzle.component_mapping.*
Bug: b/129523279
Change-Id: Ib4f7cd6c90fe7bde7d1abd2ecf77e3abbe121438
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29949Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Test: dEQP-VK.texture.swizzle.component_mapping.*
Bug: b/129523279
Change-Id: Ib081a299d77e9e165fa3dbb7764c5ead8e507406
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29948Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/119620767
Change-Id: Ia00deb9b225f38b7faf8bf0fb41d02b0f8b36ebc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29849Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Android builds fail for this warning.

Bug: b/130335507
Bug: b/130461662
Change-Id: I2c5be9199f9a393d477345c194cdf940cc7404eb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29870Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Addresses this review comment:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/29810/5/tests/VulkanUnitTests/VkInstanceFuncs.hpp#20

Change-Id: If8ea18b2090f00067e346bf55b8db1ac4c22d751
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29869Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

We were building both and only using one.

Speeds up builds.

Change-Id: I37af0973c50c38610e1d7322e29966cf36ae0e23
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29056Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Apparently there's "Clang" and "AppleClang".

CMAKE_CXX_COMPILER_ID MATCHES "Clang"
matches against both, where as STREQUAL will not consider "AppleClang" as a match.

Bug: b/130343040
Bug: b/130335507
Change-Id: I3d09a726924a7bbf8dc061349fc9fa504f7d08e2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29868Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: I1c858cf3f3d3733453d8aec19730581c7235e42d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29871Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

1D images are currently sampled as if they're 2D images, by setting the
second coordinate to 0.

Bug: b/129523279
Test: dEQP-VK.binding_model.shader_access.primary_cmd_buf.combined_image_sampler_mutable.fragment.single_descriptor.1d
Change-Id: I9aa20cb8b4d43cfdce28c1ec697a72fb6c49c6b5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29775Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Emit a call to a different trampoline function for generating the
sampler code, which unifies the implementation with
OpImageSampleExplicitLod's by using a common EmitImageSample which
takes a sampler 'method' enum. This is then passed at shader execution
time to emitSamplerFunction.

The lod parameter is parsed from the instruction stream in
EmitImageSample. Other (optional) image operands are left unimplemented
for now.

Bug: b/129523279
Test: dEQP-VK.binding_model.shader_access.primary_cmd_buf.combined_image_sampler_mutable.fragment.single_descriptor.2d
Change-Id: I265b81d953fe5a0496d029704a0f5eeff4229823
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29774Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

Use a common method for updating mutable and immutable sampler
descriptors.

Bug: b/129523279
Test: dEQP-VK.texture.filtering.2d.formats.r8g8b8a8_unorm.*
Change-Id: I1ef82c8fe2cbb2e92f3dadce794346be525648b8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29848
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

This does nothing, and breaks the Android build since the toolchain
there uses -Wignored-qualifiers. This is the only case of it in
SwiftShader.

Change-Id: Ida06e695bd3f303200864a4fd2a797cb4c78dc15
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29888Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Android recently split vulkan_headers (vulkan.h etc) from
hwvulkan_headers (HAL module plumbing, etc). Adjust to match.

Change-Id: I912cfa900363307abb271f74d9c8ebc683cada42
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29772
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Fix all code that had trailing semicolons.

Some downstream projects also consider these as errors, so this change catches the breakages at the source.

Bug: b/130343040
Bug: b/130335507
Change-Id: I19ef3b5c682524542cde68f917ca9310a19da286
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29810Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

set_cpp_flag affects everything, including 3rd party code.

We need to perform this separation as 3rd party code has unfixed warnings that we want to check for in our code.

This also has the added benefit that we can use build switches (DCHECK_ALWAYS_ON, REACTOR_EMIT_DEBUG_INFO) without requring a full rebuild of LLVM.

Bug: b/130343040
Bug: b/130335507
Change-Id: I577653e8eb3c4e588fc582f324b5ab6095662e54
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29809Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: Id110c8775a1ea905e4025225c3a72a5a4364de11
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29771
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

It appears to be undefined for me.
Let Kokoro decide if it is required.

Change-Id: I0052703552dd0727e6d3dc12f7947ce06faee5f6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29054Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/129523279
Change-Id: Id77a2168c11a66dddebf893d1527647b30584832
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29773Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

- Implement support for mipmapping:
  Involved fixing retrieving correct texel pointers for each mip level.
- Implement addressing mode.
- Implement filter mode.
- Removed textureSize(). We already have an implementation of
  OpImageQuerySize which doesn't require the sampling code.

For now, these parameters are converted to the legacy sampler enum
values to avoid a big refactoring which may break functionality before
we pass the tests. Future changes will eliminate them in favor of using
the Vulkan sampler parameters directly.

Bug: b/129523279
Test: dEQP-VK.texture.filtering.2d.formats.r8g8b8a8_unorm.*
Test: dEQP-VK.pipeline.sampler.view_type.2d.format.r8g8b8a8_unorm.*
Change-Id: I313e598ae61c0016a5a929bf5c1a53b66b3ff0d1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29770Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Vulkan 1.1 section 15.3.5 table 24 specifies "Conversion to RGBA"
to use 'one' as the last component when it's not present in the format,
where "one = 1.0f for floating-point formats and depth aspects, and
one = 1 for integer formats and stencil aspects", and 0 for the other
missing components.

Bug b/129523279

Change-Id: I9e4b0b9a8d1d696e51fc76b6554045835966c4b0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29274
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

The fixed-function OpenGL ES 1.1 and Direct3D 8 texture sampling
operations used 4.12 fixed-point values. SPIR-V only returns float4
or int4 results.

Also eliminate handling of 'null' textures. Vulkan 1.1 demands valid
descriptors

Bug b/129523279

Change-Id: I692bcaced55082b41a9c8a18551c23b03cb18430
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29272
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

There's only one type of pointer now.

Bug: b/131224163
Change-Id: Ie285affbdd05fdfc878f8144b3c6569547634f6d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29570Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Use these for a fast-path for Load() and Store().

This is an attempt to fix the severe performance hit we incurred with robustness.

Bug: b/131224163
Change-Id: I3e244bed5ed723cf29538ff022781c813caaa5eb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29454Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

This change moves all calls to rr::Load() and rr::Store() to two
new functions: SIMD::Load() and SIMD::Store(). This attempts to
consolodate the SIMD memory ops into reusable functions, while
also adding bounds checking on the accesses.

The additional branches hurts the JIT codegen performance.
This will be resolved with a future change.

Tests: dEQP-VK.robustness.*
Bug: b/131224163
Change-Id: I3a392a1f4f5366fa5134c081e0a2479575f92d80
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29334Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

These may be required with the new SIMD::Load and SIMD::Store implementations.

Bug b/127472316
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.load
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.store

Change-Id: I89db49d7c27c268d37d1bb768adfefd99c11c7c0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29449
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

This code was added just before LLVM 3 was removed, and can be considered a merge conflict.

Bug: b/130460252
Change-Id: If7d6f46c78a94cb8f3cc07ec4ba7c91a58e5926d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29813
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Change-Id: Ic67efe0d3977417dcc941e103cd37d4ac09998cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29788Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

These work the same way; differences are in coordinate handling and
where we find the image format.

Bug: b/131171141
Change-Id: I9dccfd88e686102d6200bdba8a8ad64b7debeca3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29688Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Bug: b/119620767
Test: dEQP-VK.renderpass*
Change-Id: I749c26e9924d69735f45ca981957016718fe5b0a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29708Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Previously if sample count were 1, we would skip the setup for the
centroid 1/w, and then blindly use it, leading to NaN in all interpolants marked `centroid`.

Bug: b/118386749
Test: dEQP-VK.glsl.linkage.varying.*
Change-Id: I4f5d0b052f2defaad86706b85790ef14cd42f53f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29650Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

alphaReference is not used. It previously provided a configurable
threshold for alphaToCoverage, before that was explicitly managed by
pipeline state.

The sample mask is not dynamic state, so it can never change between
draws without a complete context change.

sRGB write control is not context state, it is determined by the image
view format.

Bug: b/118386749
Change-Id: Id631732fad52cf6b75c1635bcd7ef464dda10e54
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29649Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

All the real work was already done; this just needed connecting.

Bug: b/118386749
Test: dEQP-VK.pipeline.multisample.alpha_to_coverage.*
Change-Id: Ib1e2b7a64a76d8d7df9ed5c93e4cc738efdd83b3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29648Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

The template-based descriptor write mechanism had got left behind as
more descriptor types were added. Reimplement the classic mechanism in
terms of a template entry, and implement all the current logic there.

Bug: b/123244275
Test: dEQP-VK.binding_model.*
Test: dEQP-VK.spirv_assembly.*
Test: dEQP-VK.glsl.*
Change-Id: Ide5a6bf70978774170f79d42652c746c2b5b8abd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29608Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

- OpLoad of pointer to descriptor is passthrough; reflect that in Kind.
- Actually pass through all the descriptor types in EmitLoad
- Fix Walk*AccessChain to not create useless divergence; constant offset
  was added in the wrong place.
- Adjust WalkAccessChain to adjust pointers into descriptor arrays using
  the descriptor stride
- Adjust storage image descriptor content to not assume layerPitch ==
slicePitch, since that isn't true.

Bug: b/131082089
Test: dEQP-VK.binding_model.*
Test: dEQP-VK.spirv_assembly.*
Test: dEQP-VK.glsl.*
Change-Id: I6cc4ae7b0fdeb54ede111f532c7e3fd1f108803c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29549Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

We already have the pointer available; no need to recompute it from the decorations.
This is groundwork for being able to index into arrays of storage image
descriptors correctly.

Bug: b/131082089
Change-Id: I574968b6ab8d205d5e4e3fcb4df5d08d2b88dcfa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29568Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>