`LoopDivergentMergePhi` was attempting to use the same merge block for a `OpLoopMerge` and a `OpSelectionMerge`. This is not legal, and was caught by improvements to the SPIR-V tools validator.

The fix is simple: Add a new merge block for the inner `OpSelectionMerge` that immediately jumps to the merge block for the `OpLoopMerge`.

Bug: b/123642959
Bug: b/133440380
Bug: b/133481698
Change-Id: I8b5da04a1cd2db3e44bb5b50f1619a8565e5bc9d

Changes:
  204cd131c Merge pull request #134 from Tobski/patch-1
  e0adad52b Off-by-one errors
  6045738ac Reserve a new block of 64 opcodes

Commands:
  git subtree pull --prefix third_party/SPIRV-Headers https://github.com/KhronosGroup/SPIRV-Headers master --squash

Bug: b/123642959
Change-Id: I9389ad9ea7916464745c2dfedefe46e3ef3a52e4

204cd131c Merge pull request #134 from Tobski/patch-1
e0adad52b Off-by-one errors
6045738ac Reserve a new block of 64 opcodes

git-subtree-dir: third_party/SPIRV-Headers
git-subtree-split: 204cd131c42b90d129073719f2766293ce35c081

While debugging the 1.2.1 dEQP-VK.graphicsfuzz.* tests, noticed a crash
here where a non-constant failed to have its intermediate pointer set.

An assert here is clearer than exploding.

Bug: b/146653181
Change-Id: I23aae701edce1595cd145930d304c9f6e4b82924
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39808Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

It was already unused.

Bug: b/129403963
Change-Id: Idd4d7d1b64bb6380364e86823787ce54bc1cf8ab
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39730
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

Surface::size() adds 4 padding bytes due to reading byte4 as 8 bytes for
efficient unpacking to short4 (less efficient prior to SSE 4.1 pmovzxbw
instruction). This padding is never addressed separately so the offset
can't overflow a signed 32-bit integer if we keep the total size minus
the padding below 2 GiB.

On the OpenGL side we currently impose a further limit of 1 GiB, but
this should also take the padding into account to allow for effective
image data up to this limit (e.g.  8192 * 8192 of four samples of 32-bit
elements). Note that our scanline limit is also 8192 so allowing more
than 1 GiB would run into that limit instead.

Bug: chromium:835299
Bug: b/145229887
Change-Id: I4280fca88584235c0da6282ca622ee15b31bc34b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39690
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

* Add rr::BackendName() to dynamically return the name of the backend
* Set VkPhysicalDeviceProperties::deviceName to include backend name

Bug: b/130459196
Change-Id: I028f3607e4eda9de55bc4cec8af78e7b4793160d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39552
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

If enabled, TRACE macros (in Reactor and Vulkan) will use
OutputDebugString on Windows, printf otherwise, to print the trace. On
Windows, this allows us to use DbgView to monitor and filter the trace
easily, especially useful when running with Chrome, for e.g.

Bug: b/146051794
Change-Id: I15a46f5f0e8bc4e9edcacaf63c15dc605323356d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39568
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

Change-Id: I092acdfdd47e91aca0530abba035e8b575fcf0db
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39788
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

Exposing GL_OES_depth_texture requires that at least
depth only format are filterable, so making sure at
least D16_UNORM and D32_SFLOAT can be filtered.

Tests: dEQP-VK.*d16_unorm*
Tests: dEQP-VK.*d32_sfloat*
Bug: b/146563038
Change-Id: I2c5a10b03eab19d179c005e2f0f8f22a4921830c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39748
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

Checks for Bug: line, licenses, clang-format (v 8.0.0) and gofmt.

These checks are performed by a separate kokoro instance.

Fixed up broken licenses that it found.

Counterpart: cl/286343852
Bug: b/144825072
Bug: b/141892461
Change-Id: If4ffda0b6144efe3cd5560cf17a6f4ad33bf985a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39708Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: I923f535fdec3a139e5d4d9be204ecd5a6b99a4b3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39709Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

The fix for graphicsfuzz tests having invalid control flow is now
landed, so we no longer need to carry the patch.

Bug: b/144183516
Change-Id: Ic65a853ddf90b085068874f0c50ab0793f109f8e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39728Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

In order for SwANGLE to expose GL_OES_texture_float_linear,
VK_FORMAT_R.*32_SFLOAT formats must expose the
VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT bit.

Tests: dEQP-VK.pipeline.sampler*32_sfloat*filter.linear
Bug: b/146488564
Change-Id: I0b3d2832a76488f778a1978f6e33fb9bdb5ca05a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39689Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

These are unused by the Vulkan implementation. We have sw::float4
instead for vector data type needs.

Bug: b/146224130
Change-Id: Icbb01e3ea82b760ad60f99c10e65c38e825ef12d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39688
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Change-Id: Ic0491111099041909c723e622fd2ef89f55b860e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39660Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

- Enabled the feature
- Removed restriction from SpirvShader::getImageSampler()
- Added support for it in SpirvShader::convertFilterMode()

The rest of the logic to compute anisotropic filtering was
still there.

Tests: dEQP-VK.texture.filtering_anisotropy.*
Bug: b/146438763
Change-Id: I2a36d00b6da88091202abe6d4f4f7f9b49507eb3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39668
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

We use the sample count from the pipeline in all cases, so we don't have
to do anything special for this.

Bug: b/146387550
Change-Id: I1f1fd33a257bcb9d528efef94d0c919a42d56400
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39608Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/144825072

Change-Id: Iabb4e1b2f4bb3da842fdeaa3ad2c6c3816810ae6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39659
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/144825072

Change-Id: I1bd5196b34a7974a41dcb95814a1ae8643b26f22
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39658
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/144825072

Change-Id: Ifc469786ac5fa2a8ed00e95069e1a2839e320e96
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39657
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/144825072

Change-Id: I1f14af4446536c760d11d32aa03edb5f497e75e4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39656
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/144825072

Change-Id: I869aef91d6318bf6955581e5dad762800bd46296
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39655Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/144825072

Change-Id: I2e9c18aa5e3d394d18f86ca597aed6d6dc8dfe93
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39654
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Also add clang-format-all.sh and clang-format-separate.sh to perform this operation.

These files sit in the ./src directory.

Bug: b/144825072
Change-Id: I5228ac59f7781ad1307c305949af7e7f9e0c31d1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/24308Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Spaces are useful to separate independent constructs, but can cause
confusion when added between dependent ones. For example "a*b [i]"
is hard for humans to read correctly at a glance. "a*b[i]" is better,
and "a * b[i]" is the easiest to understand immediately.

Control statements are no different. "if (a)if (b)x;" is hard to parse.
"if (a) if (b) x;" is better, but "if(a) if(b) x;" leaves no confusion
of what belongs where.

This recommendation also follows the 'zero one infinity' rule of thumb:
https://en.wikipedia.org/wiki/Zero_one_infinity_rule
Whether we write "a + b" or "a  +  b", they are equally readable, and
the additional spaces may help with alignment of surrounding
expressions. "for  (int i : c)" on the other hand makes the keyword
unintentionally even more dissociated from its header than
"for (int i : c)" already does.

The argument that the space helps set it apart from function calls seems
moot when practically every editor supports keyword highlighting,
function names are typically longer than 2-3 characters, and function
calls are not followed by curly brackets (which while optional for
singular statements, are still recommended for reasons other than this
one).

Bug: b/144825072
Change-Id: I3432fadae8e5604123f5c537097323504fecbc8c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39588Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

In order for SwANGLE to expose GL_EXT_float_blend,
R32F, RG32F and RGBA32F must all allow blending.
The code already supports this, we just need to
expose the VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT
bit for these formats.

Bug: b/146340613
Tests: dEQP-VK.pipeline.blend.*32_sfloat*
Change-Id: I39fc67fa8c26e8296f5e837a8b228a71df9149f1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39631
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Also disable the assignment operator implicitly doing a broadcast.
Instead the explicit constructor must be used. This prevents bugs like
assigning a scalar to one element, while it was intended to broadcast
(especially when using [] on an array of vectors).

Bug: b/146224130
Bug: b/144825072
Change-Id: I43c977e256e134f6707b5c19252ded08db73b270
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39630
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

Bug: b/146224130
Change-Id: Icdbb738ddc286c67a18456529e0137a9d504a8ed
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39629
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

This prepares for having other vector sizes (e.g. byte8) support member
methods such as broadcast assignment.

Note the partial specialization for N=4, to have x,y,z,w members.

Bug: b/146224130
Change-Id: I09a341812ddfa14d247e94fd3f9345db951824ed
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39554
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

This prepares for simplifying assigning the same scalar to all elements.

Bug: b/146224130
Change-Id: I8499c671f98090ae38fd12bab59f30ef360eff69
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39508
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

Since the alignas() specifier is part of the type, it cannot be used in
a typedef, and compiler-specific attributes have to be used. We
abstracted these into the ALIGN() macro before, but used them in other
cases where alignas() can be used.

Using it where possible avoids formatting weirdness with clang-format.

Bug: b/144825072
Change-Id: If4185df296f0b525dd811103ac5bf1191833b154
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39468
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

- Moved the R11G11B10F conversion code from the Blitter to
  ShaderCore
- Used the conversion code in PixelRoutine where appropriate
  to make the R11G11B10F work as a renderable format
- Added the VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT and
  VK_FORMAT_FEATURE_BLIT_DST_BIT to the
  VK_FORMAT_B10G11R11_UFLOAT_PACK32 format

This allows ANGLE to expose the GL_EXT_color_buffer_float
(and GL_EXT_color_buffer_half_float, which depends on
GL_EXT_color_buffer_float in ANGLE, due a driver issue).

Bug: b/146223877
Tests: dEQP-VK.*b10g11r11*
Change-Id: I04ad29f7b7d497705186ae290a05868abfc13c42
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39550
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

Bug: b/145348318
Change-Id: I62c8cdf388182a6b30de7bd7d13a49c8dfc1da46
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39528
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Change-Id: Ief1db6fb999d8e49a3a13ba1e0f56fd13c77dae5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39488
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolas.capens@gmail.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

LLVMReactor was using default memory mapper when creating
SectionMemoryManager. The default memory mapper calls mmap() to allocate
memory on all platforms except Windows. It doesn't specify MAP_JIT flag
that is required to create executable memory on Mac and Fuchsia. As
result the allocated memory is not executable, which leads to crashes
when trying to run the generated code. Update LLVMRector to use a custom
MemoryMapper implementation.

Bug: chromium:1032622, b/145348318
Change-Id: Id188af269d80371b709e625c29b92ff546e9ba28
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39408
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

There was a missing prepareForSampling call after
doing an image copy between 2 compressed textures.

This cl fixes these angle end to end tests:
CopyCompressedTextureTest.Basic/ES3_Vulkan_SwiftShader
CopyCompressedTextureTest.Basic/ES2_Vulkan_SwiftShader

Bug: b/146052572 b/146157683
Change-Id: I8703fa71557509e9ecb0d52a4ad2da4c72fa6812
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39448
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

The expression "IfThenElse(e < 24, mantissa >> e, Int(0))" gets
rewritten into "IfThenElse(e<24, mantissa> > e, Int(0))" by some
versions of clang-format, thus breaking the build.

It's likely a clang-format bug that should be fixed, but the workaround
is simple and still quite elegant:
"IfThenElse(e < 24, (mantissa >> e), Int(0))"

Bug: b/144825072
Change-Id: I9cc19c6cae31bb0452b4e5402f6a742d15c45e55
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39428
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

Added a block compression (BCn) decoder and logic for all
formats for n in the [1, 5] range.

The decompression follows the same logic as the ETC2
decompression in vk::Image.

Tests: dEQP-VK.*bc*
Bug: b/146052572
Change-Id: I64fac0a7af52e1be209c1cfd5373744918c7df14
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39369
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

This block declares variables, so should be scoped.

Bug: b/145351270
Change-Id: I90b750a81f4ff93f1c618a2ae969fa321961673c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39311Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>