- 07 Jun, 2019 3 commits
-
-
Alexis Hetu authored
- Added separate mutexes for both caches in the Blitter and used std::mutex instead of MutexLock. - Removed some now unused inclusions/forward declaration from the Context class and fixed the fallout of doing that in other files. - Also moved SwiftConfig to std::thread/std::mutex - Removed unused inclusions of System/Thread.hpp where possible. Bug b/132280877 Change-Id: Ic1a992ee3161c141ec1a16471420955c6309f58f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31031Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
sw::Resource is only used by the Renderer class and the functionality used is simply one of a WaitGroup. The sync variables has been changed from a Resource to a WaitGroup and the Resource class has been removed. Bug b/133127573 Change-Id: Ic6843be44fcf57f7ac7bef6f3a14726f94761863 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31689 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I459419261b9b236dbdd617a92abb61fe5ce3ced1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32508 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-
- 06 Jun, 2019 4 commits
-
-
SwiftShader Regression Bot authored
Change-Id: I7801bcbaab10863011b3fb5016fc0e00b66ee11d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32468 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-
Nicolas Capens authored
Currently our SamplerCore code performs sampling for four SIMD lanes simultaneously. With implicit LOD calculation for fragment shaders, all four pixels in a quad share the same LOD and thus sample from the same mipmap level. But for the vertex shader the LOD is always explicitly provided, and can vary significantly between completely unrelated vertices. Previously we only used the LOD of the first one in each group of four. As a workaround, process explicit-lod sampling instructions in a lane-by-lane manner. Bug: b/133868964 Tests: dEQP-VK.glsl.texture_functions.* Change-Id: If4e0d3c04d29529300111d73801124080cb4b544 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32488 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Saman Sami authored
MCWasmObjectTargetWriter and TargetIntrinsicInfo never appear in the file. ARMTargetStreamer is declared on all platforms so move it from the ARM-only target to the shared target. Bug: chromium:971333 Change-Id: I04229323af68e5b4d24a1d5ad6524c96460108eb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32428Tested-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
The initial issue that the workaround was fixing was that, on x86, there are various C calling conventions (__stdcall, __fastcall, __vectorcall) that mangle in the number of bytes used to pass the parameters. Both Clang and the Visual Studio compiler were crashing while attempting to calculate the number of bytes necessary so that it can mangle the name of the function. It needs the mangled name to emit deviceFunctionPointers, which is some large table of function pointers. The crashes happened because not all of the parameters of the function in question are complete, i.e. some of them are uninstantiated templates or forward declarations. The fix is then to include template instantiation directly into the VK_DEFINE_NON_DISPATCHABLE_HANDLE macro. Because template instantiation of an already specialized template causes a warning (treated as an error in Chromium), an extra layer of indirection was added to make sure we don't hit this issue. Bug b/129979580 Change-Id: Id811b107be51f494f45fab2ff0cec18e7cfbafaf Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32449 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 05 Jun, 2019 1 commit
-
-
Chris Forbes authored
Change-Id: I063e3590d4ea79b2d28cc1af3a213ab37b76723d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31248Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 04 Jun, 2019 2 commits
-
-
Alexis Hetu authored
Change-Id: I4b1939f68fd99b41a12654b28cc0b0f3bb5af64c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32389Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
There was linux specific code in Vulkan's BUILD.gn file. Change-Id: I22b8cd0b97bd6acfb545e582c6e1dc784f00b2cb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32388 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 03 Jun, 2019 6 commits
-
-
Alexis Hetu authored
Notes: - INSTANTIATE_TEST_CASE_P is now deprecated, so changed it to INSTANTIATE_TEST_SUITE_P. This requires and update to third_party/googletest. - Updated Driver's loadSwiftShader() function to include the non standalone path, in order to run the tests in Chromium - Added Vulkan unit tests to swiftshader_tests - Added a new GN file for Vulkan unit tests. Note that it relies on Chromium's version of SPIR-V Tools, not on SwiftShader's version, in order to avoid build conflicts Change-Id: I87727f6a858a720d0f5fb8f262ac290818945ac4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32349 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Sean Risser authored
The compiler tries to allocate arrays of uniforms before it checks their size. So large arrays will cause the compiler to allocate all of its memory. This change makes the compiler reject oversized arrays and returns a compilation error. Bug chromium:872321 Change-Id: I3441232cca129bd2abd181990bec457ad7f43d05 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29333Tested-by:
Sean Risser <srisser@google.com> Presubmit-Ready: Sean Risser <srisser@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Chris Forbes authored
Change-Id: I1eefd7ec6356df26de0a191691f7746debccbf02 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32348Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
Change-Id: Ifadb6a0731dc1ebbb85d0b35809476c425385d45 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32029Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
This reverts commit af29bcdcd889ed8508d52ce31a3d1019ea1c8ba2. Change-Id: I9be9386258f353f4bf9a0245da4fd41f1109a78a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32028 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I02f9ac96f3031aef018694680dc3473fe3ff1c10 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32308Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 02 Jun, 2019 1 commit
-
-
Nicolas Capens authored
Vulkan cubemaps use six consecutive layers for the faces, so we can reuse the same addressing logic as for 2D array textures. Hence the 3D lookup vector becomes a 2D coordinate plus layer coordinate after projection. The only difference is we don't have to clamp to the range of layers. This simplifies the sampled image descriptor since we only have to store a single pointer per mipmap level. We also avoid the per-lane lookup (gather) operation. YCbCr sampling was adjusted to not use the same array of buffer pointers. Also eliminate the unused lodOrBias parameter from computeLod*(). It's added afterwards. Bug: b/134164485 Bug: b/129523279 Change-Id: I5c349ff458aabb1d77e32104429b635d96237292 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31088Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 31 May, 2019 2 commits
-
-
Alexis Hetu authored
BuiltInPointCoord is defined as: "The following formulas are used to evaluate s and t: s = 1/2 + (xp - xf) / size t = 1/2 + (yp - yf) / size where size is the point’s size; (xp,yp) is the location at which the point sprite coordinates are evaluated - this may be the framebuffer coordinates of the fragment center, or the location of a sample; and (xf,yf) is the exact, unrounded framebuffer coordinate of the vertex for the point." So it was implemented by writing (xf,yf) in SetupRoutine, where this information is present and using the fragment's x and y coordinates as (xp,yp), which passes the test. Tests: dEQP-VK.glsl.builtin_var.simple.pointcoord Change-Id: I9146349bcce0f7c31dd0464c0f210a7306d5d033 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31992 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
This cl fixes all issues related to building Vulkan using the x86 compiler in Visual Studio: - Added dummy function to prevent compiler crash in VkGetProcAddress.cpp - Added missing WIN32 check in SwiftShader's Vulkan unit tests - Removed alignment code which broke Win32 DLL. Removing all of it should work on all other platforms as well. Minor nit fix: - Renamed VkWrapper to VkNonDispatchableHandle, which is a more accurate name. Bug b/129979580 Change-Id: Ib2bf305433e9aae71ff6f9d796fb86bc7ea733b0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31609Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 30 May, 2019 2 commits
-
-
Alexis Hetu authored
This warning was hit almost 2000 times and was causing a lot of noise in the output. Change-Id: I53f80de3eeebc9f70d780d3d7bc1e374582ffb10 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32289Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
The assumption that Cast(VkDescriptorSetLayout) is nothing but a noop cast no longer hold on 32 bit, since the handle and the pointer don't have the same size. Used the Cast() function to solve the issue. Bug chromium:968313 Change-Id: I0349d1f4f00ca983bbc4ca9c39be77d3a0b3d5bc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32229Tested-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 29 May, 2019 11 commits
-
-
Chris Forbes authored
Change-Id: I95825844509af7a30600fe48752b3f5cef10d017 Bug: b/129979580 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32208 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Chris Forbes authored
- VK_EXPORT was not defined, causing all kinds of trouble - Android WSI code was based on an earlier version which didnt require aspect mask to be passed to some functions - More missing files for ARM target Change-Id: Ia5f88c5692d48f2d7898c86c26347bed6e4b4f22 Repro: external/swiftshader$ mma Bug: b/129979580 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32188 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Chris Forbes authored
Change-Id: Ie80381527e9c8672d1a6e57aea78582ccee33021 Repro: external/swiftshader$ mma Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32109Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Hernan Liatis authored
Have Vk synchronization objects fire in vkAcquireImageANDROID as per described in https://source.android.com/devices/graphics/implement-vulkan Tests: dEQP-VK.wsi.android.swapchain.modify.resize Bug: b/133520634 Change-Id: I9b045df3b5ed0fff8efde9c0207e4a1da9c94b8f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31968Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Hernan Liatis <hliatis@google.com>
-
Hernan Liatis authored
When swapchain images were being destroyed on Android, the backing memory was not being destroyed, causing a crash. Tests: dEQP-VK.wsi.android.swapchain.create.min_image_count Bug: 133346002 Change-Id: Ib2383a6c41ac2917f6e6630eca96e5c180996507 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31870Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Hernan Liatis <hliatis@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Sean Risser authored
For OpenGL on Mac, Swiftshader renders directly to the IOSurface given to us by the OS. This surface is not necessarily vertically padded so its height is a multiple of 2. Since we render 4 pixels at a time in a quad, the bottom 2 pixels may not be written to legal memory if the height of the target surface is an odd number. This change prevents Swiftshader from rendering quads on Mac if doing so would overflow the buffer. Bug: chromium:944796 Bug: angleproject:2764 Change-Id: I08bec895980b42f99b8a4434969edcaf7d331284 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32030 Presubmit-Ready: Sean Risser <srisser@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Sean Risser <srisser@google.com>
-
Nicolas Capens authored
SpirvShader::InterfaceComponent is used as part of the state that comprises the lookup key for cached Reactor routines. It uses 1-bit bitfields for Boolean values, and the bits following it for padding may be left uninitialized by the compiler. Computing the hash of all the state is done by XORing together the memory, so it shouldn't have any- thing uninitialized. While we memset all of SetupProcessor::State to 0, the InterfaceComponent state copied in still contained the uninitialized bits. Computing a hash from it was detected by MemorySanitizer. Bug chromium:967824 Change-Id: If1676831fc838bf2a6ca869d13e6f6d2052fa6d8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32128 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Sean Risser <srisser@google.com>
-
Saman Sami authored
swiftshader_reactor_base doesn't need to depend on swiftshader_opengl_common. This causes failures when building for Vulkan. Instead make swiftshader_libGLESv2_static depend on it directly. Bug: chromium:967704 Change-Id: I4c62c975c72ad42ee0a5cd59e58bd840ad8ab71e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32068Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Saman Sami <samans@chromium.org>
-
Saman Sami authored
The alignment of VkWrapper is currently set to match the alignment of uint64_t which isn't always correct. On some platforms (e.g. Linux x86) the alignment of uint64_t inside and outside of a struct differ (8 vs 4). Using an alignment of 8 will cause swiftshader to miscalculate the size of structs containing VkWrappers and the offset of different fields into the struct. This is why the alignment of VkWrapper should match that of uint64_t inside a struct, not outside of it. Bug: chromium:967831 Change-Id: Ibf8240d13406413481cf87e9d45df4478c35be2f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32108 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Saman Sami <samans@chromium.org>
-
Sean Risser authored
supports_llvm needs to include is_mac. Bug chromium:966543 Change-Id: Ieedf1bba3948de8c75d8bd07473fa2cb0a1e4299 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32032Reviewed-by:
Alexis Hétu <sugoi@google.com> Presubmit-Ready: Sean Risser <srisser@google.com> Tested-by:
Sean Risser <srisser@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I4fb809cd80b0eef249df24de45f4e1c92912e0c1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32052 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 28 May, 2019 8 commits
-
-
Ben Clayton authored
The printf specifiers expect an int, passing a smaller width integer could lead to weirdness being printed. Change-Id: I1e75e3fdade270a4bfa55c48efe82ca9f331b2fe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31272 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-
Ben Clayton authored
Yet another horrible phi/loop edge case (pun intended). Added test. Bug: b/133440380 Bug: b/133481698 Change-Id: I327842fa2d4314bce938454da81f67f890cf9e12 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31845 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
The 'existsPath' condition is not required, and worse still breaks some future fixes. Bug: b/133440380 Bug: b/133481698 Change-Id: I9c5d20bf7782443b0e0e3eb0aacebae251687164 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32048 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
TSAN claims there are data races in the compileLayer. Specifically, it takes objection to compileLayer.addModule() being called at the same time as compileLayer.removeModule(). Bug: b/133127573 Change-Id: I19196d0c952bc308c2e47a848c93b092d5eea1ea Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31832 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Odd that these don't exist already. Change-Id: I018dc4eb5144cb4c359c790aadabc35516bdd745 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31430Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
DebugInfo::NotifyObjectEmitted and NotifyFreeingObject have become statics as the free-object callback happens after the DebugInfo instance is destroyed. This isn't an issue as the JITEventListener is a singleton in LLVM. Bug: b/133399620 Change-Id: I93fa73d0e416ba3c09c6550cc0d3abd56354e862 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31837Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Chris Forbes authored
!IsStorageInterleavedByLane is not quite the same as IsExplicitLayout-- workgroup memory is the exception. Bug: b/133509497 Change-Id: I4dd055109c0e0f70fa415a75ee383e251cbd509c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31929Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
This missing op causes horrible template errors when attempting to use UInt4 swizzles. Change-Id: I02f9381c1d4da45b1fc32e53ad9c7fd248e21673 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31273 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com>
-