We were hitting an assert in the assembler due to an instruction that had not been properly legalized. Now we ensure that mul instructions take at most one immediate. It is not clear why these instructions were not removed by upstream optimizations. This is possibly a result of values only being known at link time but somehow missed by LTO. This CL includes some minor cleanup as well: * Running lit tests does not actually require the Subzero runtime, so that is removed from the dependencies list. * Removes unused capture clauses that were causing warnings treated as errors on newer compilers. Reviewed-on: https://chromium-review.googlesource.com/896962Reviewed-by:Jim Stichnoth <stichnot@chromium.org> Reviewed-by:
Karl Schimpf <kschimpf@chromium.org> Signed-off-by:
Antonio Maiorano <amaiorano@google.com> Bug: b/120208871 Change-Id: Ibf33b6961ee99311ca18c7179c56df28af6faf17 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/49068 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| bloat | Loading commit data... | |
| crosstest | Loading commit data... | |
| docs | Loading commit data... | |
| pnacl-llvm | Loading commit data... | |
| runtime | Loading commit data... | |
| src | Loading commit data... | |
| unittest | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| DESIGN.rst | Loading commit data... | |
| LICENSE.TXT | Loading commit data... | |
| Makefile | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README-wasm.md | Loading commit data... | |
| README.rst | Loading commit data... | |
| c2wasm-exe.sh | Loading commit data... | |
| codereview.settings | Loading commit data... | |
| fetch-torture-tests.sh | Loading commit data... |