When we decompress ETC2 RGB into a 4-channel texture, *almost* everything just works as long as we ensure the alpha channel has the correct values -- except that to the sampler, this is now a 4-channel texture and so no channel replacement will be performed. This interacts badly with border texel replacement, which occurs before channel replacement. When a transparent border mode is used, we end up with non-1 values in the returned alpha channel, which is wrong. Instead, drive missing channels to 0/1 with the swizzle, which we control independently of the texture format. Bug: b/119620767 Test: dEQP-VK.pipeline.sampler.* Change-Id: I2816e18fc1c36bd4de51a3e3871c75c7dc1b8867 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31388Tested-by:Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .vscode | Loading commit data... | |
| build | Loading commit data... | |
| docs | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gitmodules | Loading commit data... | |
| .travis.yml | Loading commit data... | |
| AUTHORS.txt | Loading commit data... | |
| Android.bp | Loading commit data... | |
| Android.mk | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CONTRIBUTING.txt | Loading commit data... | |
| CONTRIBUTORS.txt | Loading commit data... | |
| LICENSE.txt | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README.md | Loading commit data... | |
| SwiftShader.sln | Loading commit data... |