The following cl had broken all fragment uniform buffers: https://swiftshader-review.googlesource.com/6950 Since the null pointer check was only made on the vertex uniform buffer, it was preventing the fragment uniform buffer from being set, which was causing a crash when this happened. There was a second issue with this cl, which was allowing 'uniformBuffers[-1].get()' to be called, which should not have been allowed. Also, it is safer to call VertexProcessor::setUniformBuffer and PixelProcessor::setUniformBuffer unconditionally in order to set the null pointers correctly when no buffers are set. Change-Id: I275b0bca6173ee3df4e0e369926ed0a94500e1ba Reviewed-on: https://swiftshader-review.googlesource.com/7216Tested-by:Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| Android.mk | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| Buffer.cpp | Loading commit data... | |
| Buffer.h | Loading commit data... | |
| Context.cpp | Loading commit data... | |
| Context.h | Loading commit data... | |
| Device.cpp | Loading commit data... | |
| Device.hpp | Loading commit data... | |
| Fence.cpp | Loading commit data... | |
| Fence.h | Loading commit data... | |
| Framebuffer.cpp | Loading commit data... | |
| Framebuffer.h | Loading commit data... | |
| IndexDataManager.cpp | Loading commit data... | |
| IndexDataManager.h | Loading commit data... | |
| Program.cpp | Loading commit data... | |
| Program.h | Loading commit data... | |
| Query.cpp | Loading commit data... | |
| Query.h | Loading commit data... | |
| Renderbuffer.cpp | Loading commit data... | |
| Renderbuffer.h | Loading commit data... | |
| ResourceManager.cpp | Loading commit data... | |
| ResourceManager.h | Loading commit data... | |
| Sampler.h | Loading commit data... | |
| Shader.cpp | Loading commit data... | |
| Shader.h | Loading commit data... | |
| Texture.cpp | Loading commit data... | |
| Texture.h | Loading commit data... | |
| TransformFeedback.cpp | Loading commit data... | |
| TransformFeedback.h | Loading commit data... | |
| VertexArray.cpp | Loading commit data... | |
| VertexArray.h | Loading commit data... | |
| VertexDataManager.cpp | Loading commit data... | |
| VertexDataManager.h | Loading commit data... | |
| exports.map | Loading commit data... | |
| libGLESv2.cbp | Loading commit data... | |
| libGLESv2.cpp | Loading commit data... | |
| libGLESv2.def | Loading commit data... | |
| libGLESv2.hpp | Loading commit data... | |
| libGLESv2.rc | Loading commit data... | |
| libGLESv2.vcxproj | Loading commit data... | |
| libGLESv2.vcxproj.filters | Loading commit data... | |
| libGLESv3.cpp | Loading commit data... | |
| main.cpp | Loading commit data... | |
| main.h | Loading commit data... | |
| mathutil.h | Loading commit data... | |
| resource.h | Loading commit data... | |
| utilities.cpp | Loading commit data... | |
| utilities.h | Loading commit data... |