This method previously always recursively checked both the left-hand side and right-hand side of binary operations for splatted (broadcast) values to determine if the parent DAG node is a splat. For chained operations, such as the 10,000 adds of the dEQP-VK.spirv_assembly. instruction.graphics.spirv_ids_abuse.lots_ids_frag/vert tests, very deep recursion could result in stack overflow. Like several other SelectionDAG methods, limit the recursion depth to MaxRecursionDepth (6). Bug: b/173785481 Change-Id: I22ee0453db7cf1311267291a331ad8fa3b57b1d9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50672 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:Jason Macnak <natsu@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Jason Macnak <natsu@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .vscode | Loading commit data... | |
| build | Loading commit data... | |
| build_overrides | Loading commit data... | |
| docs | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| tools/cmake_generate_graphviz | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gitmodules | Loading commit data... | |
| AUTHORS.txt | Loading commit data... | |
| Android.bp | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CMakeSettings.json | Loading commit data... | |
| CONTRIBUTING.txt | Loading commit data... | |
| CONTRIBUTORS.txt | Loading commit data... | |
| LICENSE.txt | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README.md | Loading commit data... | |
| codereview.settings | Loading commit data... |