The assert() can be safely removed. This was tested by doing the following on my Linux machine. 1) remove the assert() in third_party/swiftshader/third_party/subzero/src/IceTargetLoweringX86BaseImpl.h:6491 2) change the 11 into 1 in src/Reactor/ReactorUnitTests.cpp:492 (to ensure full coverage of the Blend operation) 3) cd build && cmake .. -DCMAKE_BUILD_TYPE=Debug -DREACTOR_BACKEND=Subzero && make -j32 && ./ReactorUnitTests Without step 1), ReactorUnitTests crasehs with an assertion in debug builds only. Bug: None Change-Id: I3ab3600eee0bb7a9c9a1bfc3fe091e24c4dfc366 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39053 Kokoro-Presubmit: David Turner <digit@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:Chris Forbes <chrisforbes@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| Makefile.standalone-help | Loading commit data... | |
| bloat | Loading commit data... | |
| crosstest | Loading commit data... | |
| docs | Loading commit data... | |
| pnacl-llvm | Loading commit data... | |
| pydir | Loading commit data... | |
| runtime | Loading commit data... | |
| src | Loading commit data... | |
| tests_lit | Loading commit data... | |
| unittest | Loading commit data... | |
| wasm-tests | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| DESIGN.rst | Loading commit data... | |
| LICENSE.TXT | Loading commit data... | |
| Makefile | Loading commit data... | |
| Makefile.standalone | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README-wasm.md | Loading commit data... | |
| README.rst | Loading commit data... | |
| c2wasm-exe.sh | Loading commit data... | |
| codereview.settings | Loading commit data... | |
| fetch-torture-tests.sh | Loading commit data... |