| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| Common | ||
| D3D8 | ||
| D3D9 | ||
| Device | ||
| Main | ||
| OpenGL | ||
| Pipeline | ||
| Reactor | ||
| Renderer | ||
| Shader | ||
| SwiftShader | ||
| System | ||
| Vulkan | ||
| WSI | ||
| Android.bp | ||
| SwiftShader.workspace | ||
| clang-format-all.sh | ||
| clang-format-separate.sh | ||
| commit_id.py | ||
| swiftshader.gni |
It's valid in Vulkan for a shader to have specialization constants and the pipeline to be lacking specialization constant data. This could lead to a key match between the two even though there should be a different shader payload. From the spec: > It is legal for a SPIR-V module with specializations to be > compiled into a pipeline where no specialization info was provided. > SPIR-V specialization constants contain default values such that > if a specialization is not provided. Fix this by adding in the required checks. Should not affect perf. Bug: b/150449637 Bug: angleproject:4426 Change-Id: I5f384420bdc1f03a36852db0b20393ae56452b62 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41728Tested-by:Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: Jamie Madill <jmadill@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| Common | Loading commit data... | |
| D3D8 | Loading commit data... | |
| D3D9 | Loading commit data... | |
| Device | Loading commit data... | |
| Main | Loading commit data... | |
| OpenGL | Loading commit data... | |
| Pipeline | Loading commit data... | |
| Reactor | Loading commit data... | |
| Renderer | Loading commit data... | |
| Shader | Loading commit data... | |
| SwiftShader | Loading commit data... | |
| System | Loading commit data... | |
| Vulkan | Loading commit data... | |
| WSI | Loading commit data... | |
| Android.bp | Loading commit data... | |
| SwiftShader.workspace | Loading commit data... | |
| clang-format-all.sh | Loading commit data... | |
| clang-format-separate.sh | Loading commit data... | |
| commit_id.py | Loading commit data... | |
| swiftshader.gni | Loading commit data... |