Halide users reported this here: https://llvm.org/pr46176 I reported the issue to MSVC here: https://developercommunity.visualstudio.com/content/problem/1179643/msvc-copies-overaligned-non-trivially-copyable-par.html This codepath is apparently not covered by LLVM's unit tests, so I added coverage in a unit test. If we want to support this configuration going forward, it means that is in general not safe to pass a SmallVector<T, N> by value if alignof(T) is greater than 4. This doesn't appear to come up often because passing a SmallVector by value is inefficient and not idiomatic: it copies the inline storage. In this case, the SmallVector<LLT,4> is captured by value by a lambda, and the lambda is passed by value into std::function, and that's how we hit the bug. Differential Revision: https://reviews.llvm.org/D87475 NOTE from amaiorano@ : applied this LLVM patch (without the unittest) to SwiftShader. Bug: b/173512119 Change-Id: If036f61386b51f9b4a20427812b4ac92d901244d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50469Tested-by:Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| PowerVR_Examples @ 409c9d54 | ||
| SPIRV-Headers | Loading commit data... | |
| SPIRV-Tools | Loading commit data... | |
| angle | Loading commit data... | |
| astc-encoder | Loading commit data... | |
| benchmark @ e5ea03ce | ||
| boost | Loading commit data... | |
| cppdap @ 1fd23dda | ||
| glslang @ 81112685 | ||
| googletest @ 8ffb7e5c | ||
| json @ ed554144 | ||
| libbacktrace | Loading commit data... | |
| llvm-10.0 | Loading commit data... | |
| llvm-subzero | Loading commit data... | |
| marl | Loading commit data... | |
| stlport-cpp11-extension | Loading commit data... | |
| subzero | Loading commit data... | |
| .clang-format | Loading commit data... | |
| update-llvm-10.sh | Loading commit data... | |
| update-marl.sh | Loading commit data... | |
| update-spirvheaders.sh | Loading commit data... | |
| update-spirvtools.sh | Loading commit data... |