Wasn't sure how to allow TargetX8632 and TargetARM32 to both define "ConstantInteger32::emit(GlobalContext *)", and define them differently if both targets happen to be ifdef'ed into the code. Rearranged things so that it's now "TargetFoo::emit(ConstantInteger32 *)", so that each TargetFoo can have a separate definition. Some targets may allow emitting some types of constants while other targets do not (64-bit int for x86-64?). Also they emit constants with a different style. E.g., the prefix for x86 is "$" while the prefix for ARM is "#" and there isn't a prefix for mips(?). Renamed emitWithoutDollar to emitWithoutPrefix. Did this sort of multi-method dispatch via a visitor pattern, which is a bit verbose though. We may be able to remove the emitWithoutDollar/Prefix for ConstantPrimitive by just inlining that into the few places that need it (only needed for ConstantInteger32). This undoes the unreachable methods added by: https://codereview.chromium.org/1017373002/diff/60001/src/IceTargetLoweringX8632.cpp The only place extra was for emitting calls to constants. There was already an inlined instance for OperandX8632Mem. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Review URL: https://codereview.chromium.org/1129263005
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| IceAPFloat.h | Loading commit data... | |
| IceAPInt.h | Loading commit data... | |
| IceBrowserCompileServer.cpp | Loading commit data... | |
| IceBrowserCompileServer.h | Loading commit data... | |
| IceCfg.cpp | Loading commit data... | |
| IceCfg.h | Loading commit data... | |
| IceCfgNode.cpp | Loading commit data... | |
| IceCfgNode.h | Loading commit data... | |
| IceClFlags.cpp | Loading commit data... | |
| IceClFlags.h | Loading commit data... | |
| IceClFlagsExtra.h | Loading commit data... | |
| IceCompileServer.cpp | Loading commit data... | |
| IceCompileServer.h | Loading commit data... | |
| IceCompiler.cpp | Loading commit data... | |
| IceCompiler.h | Loading commit data... | |
| IceConditionCodesX8632.h | Loading commit data... | |
| IceConverter.cpp | Loading commit data... | |
| IceConverter.h | Loading commit data... | |
| IceDefs.h | Loading commit data... | |
| IceELFObjectWriter.cpp | Loading commit data... | |
| IceELFObjectWriter.h | Loading commit data... | |
| IceELFSection.cpp | Loading commit data... | |
| IceELFSection.h | Loading commit data... | |
| IceELFStreamer.h | Loading commit data... | |
| IceFixups.cpp | Loading commit data... | |
| IceFixups.h | Loading commit data... | |
| IceGlobalContext.cpp | Loading commit data... | |
| IceGlobalContext.h | Loading commit data... | |
| IceGlobalInits.cpp | Loading commit data... | |
| IceGlobalInits.h | Loading commit data... | |
| IceInst.cpp | Loading commit data... | |
| IceInst.def | Loading commit data... | |
| IceInst.h | Loading commit data... | |
| IceInstARM32.cpp | Loading commit data... | |
| IceInstARM32.def | Loading commit data... | |
| IceInstARM32.h | Loading commit data... | |
| IceInstX8632.cpp | Loading commit data... | |
| IceInstX8632.def | Loading commit data... | |
| IceInstX8632.h | Loading commit data... | |
| IceIntrinsics.cpp | Loading commit data... | |
| IceIntrinsics.h | Loading commit data... | |
| IceLiveness.cpp | Loading commit data... | |
| IceLiveness.h | Loading commit data... | |
| IceOperand.cpp | Loading commit data... | |
| IceOperand.h | Loading commit data... | |
| IceRNG.cpp | Loading commit data... | |
| IceRNG.h | Loading commit data... | |
| IceRegAlloc.cpp | Loading commit data... | |
| IceRegAlloc.h | Loading commit data... | |
| IceRegistersARM32.h | Loading commit data... | |
| IceRegistersX8632.h | Loading commit data... | |
| IceTLS.h | Loading commit data... | |
| IceTargetLowering.cpp | Loading commit data... | |
| IceTargetLowering.h | Loading commit data... | |
| IceTargetLoweringARM32.cpp | Loading commit data... | |
| IceTargetLoweringARM32.def | Loading commit data... | |
| IceTargetLoweringARM32.h | Loading commit data... | |
| IceTargetLoweringX8632.cpp | Loading commit data... | |
| IceTargetLoweringX8632.def | Loading commit data... | |
| IceTargetLoweringX8632.h | Loading commit data... | |
| IceThreading.cpp | Loading commit data... | |
| IceThreading.h | Loading commit data... | |
| IceTimerTree.cpp | Loading commit data... | |
| IceTimerTree.def | Loading commit data... | |
| IceTimerTree.h | Loading commit data... | |
| IceTranslator.cpp | Loading commit data... | |
| IceTranslator.h | Loading commit data... | |
| IceTypeConverter.cpp | Loading commit data... | |
| IceTypeConverter.h | Loading commit data... | |
| IceTypes.cpp | Loading commit data... | |
| IceTypes.def | Loading commit data... | |
| IceTypes.h | Loading commit data... | |
| IceUtils.h | Loading commit data... | |
| Makefile | Loading commit data... | |
| PNaClTranslator.cpp | Loading commit data... | |
| PNaClTranslator.h | Loading commit data... | |
| README.SIMD.rst | Loading commit data... | |
| assembler.cpp | Loading commit data... | |
| assembler.h | Loading commit data... | |
| assembler_arm32.h | Loading commit data... | |
| assembler_ia32.cpp | Loading commit data... | |
| assembler_ia32.h | Loading commit data... | |
| main.cpp | Loading commit data... |