OpDecorateId was added to SPIR-V 1.2, but was missing from SwiftShader. OpDecorateString and OpMemberDecorateString were added in SPIR-V 1.4 as a part of the SPV_GOOGLE_decorate_string extension being integrated as a core part of SPIR-V 1.4. All of the decorations for these operations are to support HLSL at a level before the graphics driver is involved, to include debug information in the SPIR-V code, or to inform the SPIR-V compiler about potential optimizations that SwiftShader currently doesn't implement. Test: dEQP-VK.spirv_assembly.instruction.spirv1p4.hlsl_functionality1.* Test: dEQP-VK.spirv_assembly.instruction.spirv1p4.uniformid.* Bug: b/174693410 Change-Id: I7a22b335da9f5566e3d08869a80ea6701f035155 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50850Tested-by:Sean Risser <srisser@google.com> Commit-Queue: Sean Risser <srisser@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .vscode | Loading commit data... | |
| build | Loading commit data... | |
| build_overrides | Loading commit data... | |
| docs | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| infra/config | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| tools/cmake_generate_graphviz | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gitmodules | Loading commit data... | |
| AUTHORS.txt | Loading commit data... | |
| Android.bp | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CMakeSettings.json | Loading commit data... | |
| CONTRIBUTING.txt | Loading commit data... | |
| CONTRIBUTORS.txt | Loading commit data... | |
| LICENSE.txt | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README.md | Loading commit data... | |
| codereview.settings | Loading commit data... |