Sanitizer tools desire having the vtables of any class with non-pure virtual methods, even when none of them are called in the current linkage unit. In the case of sw::FrameBuffer, to work around this we can make the class pure abstract by making the destructor pure virtual. Note that the destructor still has a non-empty definition, since all non- default destructors need a defintion, and it will get called as part of the destructor chain. Bug swiftshader:31 Change-Id: I7601b1a725c513ff484cd34a8965636b7f21513c Reviewed-on: https://swiftshader-review.googlesource.com/9912Reviewed-by:Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <capn@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| Config.cpp | Loading commit data... | |
| Config.hpp | Loading commit data... | |
| FrameBuffer.cpp | Loading commit data... | |
| FrameBuffer.hpp | Loading commit data... | |
| FrameBufferAndroid.cpp | Loading commit data... | |
| FrameBufferAndroid.hpp | Loading commit data... | |
| FrameBufferDD.cpp | Loading commit data... | |
| FrameBufferDD.hpp | Loading commit data... | |
| FrameBufferGDI.cpp | Loading commit data... | |
| FrameBufferGDI.hpp | Loading commit data... | |
| FrameBufferOSX.hpp | Loading commit data... | |
| FrameBufferOSX.mm | Loading commit data... | |
| FrameBufferWin.cpp | Loading commit data... | |
| FrameBufferWin.hpp | Loading commit data... | |
| FrameBufferX11.cpp | Loading commit data... | |
| FrameBufferX11.hpp | Loading commit data... | |
| SwiftConfig.cpp | Loading commit data... | |
| SwiftConfig.hpp | Loading commit data... | |
| libX11.cpp | Loading commit data... | |
| libX11.hpp | Loading commit data... |