`debug::LocalVariable` expects the parent scope to contain a `debug::LexicalScope`. If it doesn't, then the variable is never registered, and doesn't show up in the watch windows. DXC emits `DebugLocalVariable`s for parameters, with the parent scope set to the immediate function, with no lexical block. To make parameters show up, make `debug::Function` inherit from `debug::LexicalBlock`. This makes all the existing logic that uses `debug::find<debug::LexicalBlock>()` work for both `DebugLexicalBlock` and `DebugFunction` scope types. Fixes: b/170320768 Change-Id: I296353eae9bb7f04bc649174b9f33a29d1dcc6e7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/49088 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| ComputeProgram.cpp | Loading commit data... | |
| ComputeProgram.hpp | Loading commit data... | |
| Constants.cpp | Loading commit data... | |
| Constants.hpp | Loading commit data... | |
| PixelProgram.cpp | Loading commit data... | |
| PixelProgram.hpp | Loading commit data... | |
| PixelRoutine.cpp | Loading commit data... | |
| PixelRoutine.hpp | Loading commit data... | |
| SamplerCore.cpp | Loading commit data... | |
| SamplerCore.hpp | Loading commit data... | |
| SetupRoutine.cpp | Loading commit data... | |
| SetupRoutine.hpp | Loading commit data... | |
| ShaderCore.cpp | Loading commit data... | |
| ShaderCore.hpp | Loading commit data... | |
| SpirvID.hpp | Loading commit data... | |
| SpirvShader.cpp | Loading commit data... | |
| SpirvShader.hpp | Loading commit data... | |
| SpirvShaderArithmetic.cpp | Loading commit data... | |
| SpirvShaderControlFlow.cpp | Loading commit data... | |
| SpirvShaderDebug.hpp | Loading commit data... | |
| SpirvShaderDebugger.cpp | Loading commit data... | |
| SpirvShaderEnumNames.cpp | Loading commit data... | |
| SpirvShaderGLSLstd450.cpp | Loading commit data... | |
| SpirvShaderGroup.cpp | Loading commit data... | |
| SpirvShaderImage.cpp | Loading commit data... | |
| SpirvShaderInstructions.cpp | Loading commit data... | |
| SpirvShaderInstructions.inl | Loading commit data... | |
| SpirvShaderMemory.cpp | Loading commit data... | |
| SpirvShaderSampling.cpp | Loading commit data... | |
| SpirvShaderSpec.cpp | Loading commit data... | |
| VertexProgram.cpp | Loading commit data... | |
| VertexProgram.hpp | Loading commit data... | |
| VertexRoutine.cpp | Loading commit data... | |
| VertexRoutine.hpp | Loading commit data... |