For MemorySanitizer builds which do not have Reactor routine instrumentation enabled, mark all Call() arguments as initialized by calling __msan_unpoison_param(). This prevents false positives. Note that we also already unpoisoned all memory writes, when proper instrumentation is not enabled. While it's preferable to set REACTOR_ENABLE_MEMORY_SANITIZER_INSTRUMENTATION=1 to avoid the false negatives caused by unpoisoning, it currently causes slowdowns which result in timeouts. Bug: b/187467599 Change-Id: I5fdcbceb5cd795f5e3684df0cdc1ba6c1bef06e9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/54348 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .vscode | Loading commit data... | |
| build | Loading commit data... | |
| build_overrides | Loading commit data... | |
| docs | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| infra/config | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| tools/cmake_generate_graphviz | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gitmodules | Loading commit data... | |
| AUTHORS.txt | Loading commit data... | |
| Android.bp | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CMakeSettings.json | Loading commit data... | |
| CONTRIBUTING.txt | Loading commit data... | |
| CONTRIBUTORS.txt | Loading commit data... | |
| DIR_METADATA | Loading commit data... | |
| LICENSE.txt | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README.md | Loading commit data... | |
| codereview.settings | Loading commit data... |