Some SampledImageDescriptor members are assumed to be 16-byte aligned, such as the sw::Mipmap::pitchP member accessed by sampleFloat2D(). To guarantee this while descriptor sets can contain multiple types of descriptor, all descriptors are made a multiple of 16 bytes in size. Also, each descriptor set starts with a pointer to its layout, followed by the actual descriptor content. To ensure the latter is 16-byte aligned, the layout pointer was placed in a header structure which itself is 16-byte aligned and thus includes the necessary padding. The placement of the descriptor set itself is guaranteed to be 16-byte aligned by vk::REQUIRED_MEMORY_ALIGNMENT = 16 being used for descriptor pool allocation. Bug: b/129523279 Bug: b/123244275 Change-Id: I72fb92d9ff5a8d100d05f5b9e38170ade557d434 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29970 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:Ben Clayton <bclayton@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| Version.h | Loading commit data... | |
| VkBuffer.cpp | Loading commit data... | |
| VkBuffer.hpp | Loading commit data... | |
| VkBufferView.cpp | Loading commit data... | |
| VkBufferView.hpp | Loading commit data... | |
| VkCommandBuffer.cpp | Loading commit data... | |
| VkCommandBuffer.hpp | Loading commit data... | |
| VkCommandPool.cpp | Loading commit data... | |
| VkCommandPool.hpp | Loading commit data... | |
| VkConfig.h | Loading commit data... | |
| VkDebug.cpp | Loading commit data... | |
| VkDebug.hpp | Loading commit data... | |
| VkDescriptorPool.cpp | Loading commit data... | |
| VkDescriptorPool.hpp | Loading commit data... | |
| VkDescriptorSet.hpp | Loading commit data... | |
| VkDescriptorSetLayout.cpp | Loading commit data... | |
| VkDescriptorSetLayout.hpp | Loading commit data... | |
| VkDescriptorUpdateTemplate.cpp | Loading commit data... | |
| VkDescriptorUpdateTemplate.hpp | Loading commit data... | |
| VkDestroy.h | Loading commit data... | |
| VkDevice.cpp | Loading commit data... | |
| VkDevice.hpp | Loading commit data... | |
| VkDeviceMemory.cpp | Loading commit data... | |
| VkDeviceMemory.hpp | Loading commit data... | |
| VkEvent.hpp | Loading commit data... | |
| VkFence.hpp | Loading commit data... | |
| VkFormat.cpp | Loading commit data... | |
| VkFormat.h | Loading commit data... | |
| VkFramebuffer.cpp | Loading commit data... | |
| VkFramebuffer.hpp | Loading commit data... | |
| VkGetProcAddress.cpp | Loading commit data... | |
| VkGetProcAddress.h | Loading commit data... | |
| VkImage.cpp | Loading commit data... | |
| VkImage.hpp | Loading commit data... | |
| VkImageView.cpp | Loading commit data... | |
| VkImageView.hpp | Loading commit data... | |
| VkInstance.cpp | Loading commit data... | |
| VkInstance.hpp | Loading commit data... | |
| VkMemory.cpp | Loading commit data... | |
| VkMemory.h | Loading commit data... | |
| VkObject.hpp | Loading commit data... | |
| VkPhysicalDevice.cpp | Loading commit data... | |
| VkPhysicalDevice.hpp | Loading commit data... | |
| VkPipeline.cpp | Loading commit data... | |
| VkPipeline.hpp | Loading commit data... | |
| VkPipelineCache.cpp | Loading commit data... | |
| VkPipelineCache.hpp | Loading commit data... | |
| VkPipelineLayout.cpp | Loading commit data... | |
| VkPipelineLayout.hpp | Loading commit data... | |
| VkPromotedExtensions.cpp | Loading commit data... | |
| VkQueryPool.cpp | Loading commit data... | |
| VkQueryPool.hpp | Loading commit data... | |
| VkQueue.cpp | Loading commit data... | |
| VkQueue.hpp | Loading commit data... | |
| VkRenderPass.cpp | Loading commit data... | |
| VkRenderPass.hpp | Loading commit data... | |
| VkSampler.hpp | Loading commit data... | |
| VkSemaphore.hpp | Loading commit data... | |
| VkShaderModule.cpp | Loading commit data... | |
| VkShaderModule.hpp | Loading commit data... | |
| Vulkan.rc | Loading commit data... | |
| libVulkan.cpp | Loading commit data... | |
| libvk_swiftshader.def | Loading commit data... | |
| libvk_swiftshader.lds | Loading commit data... | |
| main.cpp | Loading commit data... | |
| resource.h | Loading commit data... | |
| vk_swiftshader_icd.json | Loading commit data... | |
| vk_swiftshader_icd.json.tmpl | Loading commit data... | |
| vulkan.vcxproj | Loading commit data... | |
| vulkan.vcxproj.filters | Loading commit data... |