Remove the `Context::Lock` parameter from `enter()`. We don't want to force the lock to be held for the entire duration of the call. Add `UpdateFrame` type alias. Add the `UpdateFrame` parameter to `enter()` - you usually want to update the frame as soon as you've pushed the stack. Switch `pauseAtFrame` from a `shared_ptr` to a `weak_ptr`. If the frame is released before the thread finds it to pause, then the thread will instead pause at the next frame (following the logic of a null `pauseAtFrame`). Fixed the assignment of `pauseAtFrame` in `stepOut()` - it was looking at the current frame, not the next one up. Bug: b/145351270 Change-Id: I1cb85af58c666a7793145480abc95a4ec82e1859 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48695Tested-by:Ben Clayton <bclayton@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .vscode | Loading commit data... | |
| build | Loading commit data... | |
| build_overrides | Loading commit data... | |
| docs | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| tools/cmake_generate_graphviz | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gitmodules | Loading commit data... | |
| AUTHORS.txt | Loading commit data... | |
| Android.bp | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CMakeSettings.json | Loading commit data... | |
| CONTRIBUTING.txt | Loading commit data... | |
| CONTRIBUTORS.txt | Loading commit data... | |
| LICENSE.txt | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README.md | Loading commit data... | |
| codereview.settings | Loading commit data... |