On MacOS, a Surface constructor receiving the 'pitchPprovided' parameter wasn't using it for the surface's external pitch, which was causing an error when using the Image::getPitch() function, which returns getExternalPitchB(). Image::getPitch() is used within Image::loadImageData(), which is used by gl functions like glTexImage2D() and glTexSubImage2D(). Both the internal and external buffers now use the parameter to solve this issue. Bug b/19979104 Change-Id: I9762ed53b535ae9eb052f57ee1ceed8ee87cb29c Reviewed-on: https://swiftshader-review.googlesource.com/18828Tested-by:Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| Blitter.cpp | Loading commit data... | |
| Blitter.hpp | Loading commit data... | |
| Clipper.cpp | Loading commit data... | |
| Clipper.hpp | Loading commit data... | |
| Color.cpp | Loading commit data... | |
| Color.hpp | Loading commit data... | |
| Context.cpp | Loading commit data... | |
| Context.hpp | Loading commit data... | |
| ETC_Decoder.cpp | Loading commit data... | |
| ETC_Decoder.hpp | Loading commit data... | |
| LRUCache.hpp | Loading commit data... | |
| Matrix.cpp | Loading commit data... | |
| Matrix.hpp | Loading commit data... | |
| PixelProcessor.cpp | Loading commit data... | |
| PixelProcessor.hpp | Loading commit data... | |
| Plane.cpp | Loading commit data... | |
| Plane.hpp | Loading commit data... | |
| Point.cpp | Loading commit data... | |
| Point.hpp | Loading commit data... | |
| Polygon.hpp | Loading commit data... | |
| Primitive.hpp | Loading commit data... | |
| QuadRasterizer.cpp | Loading commit data... | |
| QuadRasterizer.hpp | Loading commit data... | |
| Rasterizer.hpp | Loading commit data... | |
| Renderer.cpp | Loading commit data... | |
| Renderer.hpp | Loading commit data... | |
| RoutineCache.hpp | Loading commit data... | |
| Sampler.cpp | Loading commit data... | |
| Sampler.hpp | Loading commit data... | |
| SetupProcessor.cpp | Loading commit data... | |
| SetupProcessor.hpp | Loading commit data... | |
| Stream.hpp | Loading commit data... | |
| Surface.cpp | Loading commit data... | |
| Surface.hpp | Loading commit data... | |
| TextureStage.cpp | Loading commit data... | |
| TextureStage.hpp | Loading commit data... | |
| Triangle.hpp | Loading commit data... | |
| Vector.cpp | Loading commit data... | |
| Vector.hpp | Loading commit data... | |
| Vertex.hpp | Loading commit data... | |
| VertexProcessor.cpp | Loading commit data... | |
| VertexProcessor.hpp | Loading commit data... |