For MemorySanitizer builds which do not have Reactor routine instrumentation enabled, mark all Call() arguments as initialized by calling __msan_unpoison_param(). This prevents false positives. Note that we also already unpoisoned all memory writes, when proper instrumentation is not enabled. While it's preferable to set REACTOR_ENABLE_MEMORY_SANITIZER_INSTRUMENTATION=1 to avoid the false negatives caused by unpoisoning, it currently causes slowdowns which result in timeouts. Bug: b/187467599 Change-Id: I5fdcbceb5cd795f5e3684df0cdc1ba6c1bef06e9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/54348 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CPUID.cpp | Loading commit data... | |
| CPUID.hpp | Loading commit data... | |
| Coroutine.hpp | Loading commit data... | |
| Debug.cpp | Loading commit data... | |
| Debug.hpp | Loading commit data... | |
| EmulatedIntrinsics.cpp | Loading commit data... | |
| EmulatedIntrinsics.hpp | Loading commit data... | |
| ExecutableMemory.cpp | Loading commit data... | |
| ExecutableMemory.hpp | Loading commit data... | |
| LLVMAsm.cpp | Loading commit data... | |
| LLVMAsm.hpp | Loading commit data... | |
| LLVMJIT.cpp | Loading commit data... | |
| LLVMReactor.cpp | Loading commit data... | |
| LLVMReactor.hpp | Loading commit data... | |
| LLVMReactorDebugInfo.cpp | Loading commit data... | |
| LLVMReactorDebugInfo.hpp | Loading commit data... | |
| Nucleus.hpp | Loading commit data... | |
| OptimalIntrinsics.cpp | Loading commit data... | |
| OptimalIntrinsics.hpp | Loading commit data... | |
| Optimizer.cpp | Loading commit data... | |
| Optimizer.hpp | Loading commit data... | |
| Print.hpp | Loading commit data... | |
| Reactor.cpp | Loading commit data... | |
| Reactor.hpp | Loading commit data... | |
| ReactorDebugInfo.cpp | Loading commit data... | |
| ReactorDebugInfo.hpp | Loading commit data... | |
| Routine.hpp | Loading commit data... | |
| SubzeroReactor.cpp | Loading commit data... | |
| Traits.hpp | Loading commit data... | |
| Traits.inl | Loading commit data... | |
| reactor.gni | Loading commit data... | |
| x86.hpp | Loading commit data... |