We weren't checking the return status of an XGetWindowAttributes() call while checking for a resized window. It appears that it can start to fail possibly due to an out-of-memory situation or the window being destroyed before the EGL surface. Note that the EGL spec does not have a recommendation on how to handle this situation. Generating EGL_BAD_ALLOC is intended for eglCreate* call failures, while EGL_BAD_NATIVE_WINDOW appears to be reserved for calls that take a native window as a parameter. eglSwapBuffers is neither. Bug chromium:819481 Change-Id: I270730567b5179ee43b814e8bd017b601dfbe079 Reviewed-on: https://swiftshader-review.googlesource.com/17708Tested-by:Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| Android.mk | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| Config.cpp | Loading commit data... | |
| Config.h | Loading commit data... | |
| Context.hpp | Loading commit data... | |
| Display.cpp | Loading commit data... | |
| Display.h | Loading commit data... | |
| OSXUtils.hpp | Loading commit data... | |
| OSXUtils.mm | Loading commit data... | |
| Surface.cpp | Loading commit data... | |
| Surface.hpp | Loading commit data... | |
| Sync.hpp | Loading commit data... | |
| Texture.hpp | Loading commit data... | |
| libEGL.cpp | Loading commit data... | |
| libEGL.def | Loading commit data... | |
| libEGL.hpp | Loading commit data... | |
| libEGL.lds | Loading commit data... | |
| libEGL.rc | Loading commit data... | |
| libEGL.vcxproj | Loading commit data... | |
| libEGL.vcxproj.filters | Loading commit data... | |
| main.cpp | Loading commit data... | |
| main.h | Loading commit data... | |
| resource.h | Loading commit data... |