Block members were getting decorations applied from all previous
block members. For example, in this case:
in InterfaceBlock {
layout(location = 0) in vec4 in_color_smooth;
layout(location = 1) in flat vec4 in_color_flat;
layout(location = 2) in noperspective vec4 in_color_noperspective;
layout(location = 3) in centroid vec4 in_color_centroid;
}
- the member at location 2 would get decorated with both flat and
noperspective
- the member at location 3 would get decorated with both flat,
noperspective and centroid
I added a local variable for the member decorations in order to not
bleed information between block members.
Bug: b/163600604
Change-Id: I6b79609f19ae2f2f48909af929f798a48b4cde34
Tests: dEQP-VK.draw.multiple_interpolation.structured.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/47649
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by:
Alexis Hétu <sugoi@google.com>
Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| ComputeProgram.cpp | Loading commit data... | |
| ComputeProgram.hpp | Loading commit data... | |
| Constants.cpp | Loading commit data... | |
| Constants.hpp | Loading commit data... | |
| PixelProgram.cpp | Loading commit data... | |
| PixelProgram.hpp | Loading commit data... | |
| PixelRoutine.cpp | Loading commit data... | |
| PixelRoutine.hpp | Loading commit data... | |
| SamplerCore.cpp | Loading commit data... | |
| SamplerCore.hpp | Loading commit data... | |
| SetupRoutine.cpp | Loading commit data... | |
| SetupRoutine.hpp | Loading commit data... | |
| ShaderCore.cpp | Loading commit data... | |
| ShaderCore.hpp | Loading commit data... | |
| SpirvID.hpp | Loading commit data... | |
| SpirvShader.cpp | Loading commit data... | |
| SpirvShader.hpp | Loading commit data... | |
| SpirvShaderArithmetic.cpp | Loading commit data... | |
| SpirvShaderControlFlow.cpp | Loading commit data... | |
| SpirvShaderDebug.hpp | Loading commit data... | |
| SpirvShaderDebugger.cpp | Loading commit data... | |
| SpirvShaderEnumNames.cpp | Loading commit data... | |
| SpirvShaderGLSLstd450.cpp | Loading commit data... | |
| SpirvShaderGroup.cpp | Loading commit data... | |
| SpirvShaderImage.cpp | Loading commit data... | |
| SpirvShaderInstructions.cpp | Loading commit data... | |
| SpirvShaderInstructions.inl | Loading commit data... | |
| SpirvShaderMemory.cpp | Loading commit data... | |
| SpirvShaderSampling.cpp | Loading commit data... | |
| SpirvShaderSpec.cpp | Loading commit data... | |
| VertexProgram.cpp | Loading commit data... | |
| VertexProgram.hpp | Loading commit data... | |
| VertexRoutine.cpp | Loading commit data... | |
| VertexRoutine.hpp | Loading commit data... |