The BlendState structure is part of the cache key used to look up pixel routines, which must not contain any uninitialized bits. The PixelProcessor::States structure gets zero-initialized as a whole by the Memset<> base class, but when writing BlendState structures into it any uninitialized bits may get copied over. Thus BlendState must also be zero-initialized, using Memset<>. Bug: b/140286664 Bug: b/140193782 Change-Id: I031ec1a5f3be4329ae16366bfd4c8f17e2371384 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35768Tested-by:Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| Blitter.cpp | Loading commit data... | |
| Blitter.hpp | Loading commit data... | |
| Clipper.cpp | Loading commit data... | |
| Clipper.hpp | Loading commit data... | |
| Color.cpp | Loading commit data... | |
| Color.hpp | Loading commit data... | |
| Config.cpp | Loading commit data... | |
| Config.hpp | Loading commit data... | |
| Context.cpp | Loading commit data... | |
| Context.hpp | Loading commit data... | |
| ETC_Decoder.cpp | Loading commit data... | |
| ETC_Decoder.hpp | Loading commit data... | |
| LRUCache.hpp | Loading commit data... | |
| Matrix.cpp | Loading commit data... | |
| Matrix.hpp | Loading commit data... | |
| Memset.hpp | Loading commit data... | |
| PixelProcessor.cpp | Loading commit data... | |
| PixelProcessor.hpp | Loading commit data... | |
| Plane.cpp | Loading commit data... | |
| Plane.hpp | Loading commit data... | |
| Point.cpp | Loading commit data... | |
| Point.hpp | Loading commit data... | |
| Polygon.hpp | Loading commit data... | |
| Primitive.hpp | Loading commit data... | |
| QuadRasterizer.cpp | Loading commit data... | |
| QuadRasterizer.hpp | Loading commit data... | |
| Rasterizer.hpp | Loading commit data... | |
| Renderer.cpp | Loading commit data... | |
| Renderer.hpp | Loading commit data... | |
| RoutineCache.hpp | Loading commit data... | |
| Sampler.hpp | Loading commit data... | |
| SetupProcessor.cpp | Loading commit data... | |
| SetupProcessor.hpp | Loading commit data... | |
| Stream.hpp | Loading commit data... | |
| Triangle.hpp | Loading commit data... | |
| Vector.cpp | Loading commit data... | |
| Vector.hpp | Loading commit data... | |
| Vertex.hpp | Loading commit data... | |
| VertexProcessor.cpp | Loading commit data... | |
| VertexProcessor.hpp | Loading commit data... |